Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b34943c5097195c1560a30e86a36594085586d0a https://github.com/WebKit/WebKit/commit/b34943c5097195c1560a30e86a36594085586d0a Author: Chris Dumez <cdu...@apple.com> Date: 2024-04-11 (Thu, 11 Apr 2024)
Changed paths: M Source/WebKit/GPUProcess/GPUProcess.h M Source/WebKit/GPUProcess/GPUProcess.messages.in M Source/WebKit/GPUProcess/cocoa/GPUProcessCocoa.mm M Source/WebKit/ModelProcess/ModelProcess.h M Source/WebKit/ModelProcess/ModelProcess.messages.in M Source/WebKit/ModelProcess/cocoa/ModelProcessCocoa.mm M Source/WebKit/NetworkProcess/NetworkProcess.h M Source/WebKit/NetworkProcess/NetworkProcess.messages.in M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm M Source/WebKit/Shared/AuxiliaryProcess.h M Source/WebKit/Shared/AuxiliaryProcess.messages.in M Source/WebKit/UIProcess/AuxiliaryProcessProxy.h M Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm M Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm M Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm M Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp M Source/WebKit/WebProcess/WebProcess.h M Source/WebKit/WebProcess/WebProcess.messages.in M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm Log Message: ----------- [Cocoa] WebProcessPool::notifyPreferencesChanged() may notify the Network / GPU process too many times https://bugs.webkit.org/show_bug.cgi?id=272503 Reviewed by Per Arne Vollan. WebProcessPool::notifyPreferencesChanged() may notify the Network / GPU process too many times. The GPUProcess and the network process are singletons, therefore, we shouldn't notify them once per process pool. Also avoid duplicating the IPC for each AuxiliaryProcess subclass by moving the IPC to AuxiliaryProcess itself. This simplifies things a bit and will avoid duplicating code when I introduce a cache in a follow-up. * Source/WebKit/GPUProcess/GPUProcess.h: * Source/WebKit/GPUProcess/GPUProcess.messages.in: * Source/WebKit/ModelProcess/ModelProcess.h: * Source/WebKit/ModelProcess/ModelProcess.messages.in: * Source/WebKit/NetworkProcess/NetworkProcess.h: * Source/WebKit/NetworkProcess/NetworkProcess.messages.in: * Source/WebKit/Shared/AuxiliaryProcess.h: * Source/WebKit/Shared/AuxiliaryProcess.messages.in: * Source/WebKit/UIProcess/AuxiliaryProcessProxy.h: * Source/WebKit/UIProcess/Cocoa/AuxiliaryProcessProxyCocoa.mm: (WebKit::AuxiliaryProcessProxy::notifyPreferencesChanged): * Source/WebKit/UIProcess/Cocoa/PreferenceObserver.mm: (-[WKPreferenceObserver preferenceDidChange:key:encodedValue:]): * Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::notifyPreferencesChanged): * Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm: * Source/WebKit/WebProcess/WebProcess.h: Canonical link: https://commits.webkit.org/277369@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes