Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b3d9884a0a1634cb1ff3d24748264f759173d35f https://github.com/WebKit/WebKit/commit/b3d9884a0a1634cb1ff3d24748264f759173d35f Author: Dana Estra <des...@apple.com> Date: 2023-08-22 (Tue, 22 Aug 2023)
Changed paths: A LayoutTests/http/tests/media/resources/hls/subtitles/verticalrl.vtt A LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line-expected.txt A LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line.html M Source/WebCore/html/track/VTTCue.cpp Log Message: ----------- WebVTT vertical multiline captions are cut off https://bugs.webkit.org/show_bug.cgi?id=260148 rdar://112951878 Reviewed by Eric Carlson. Currently, vertical webvtt captions (such as Japanese) are not Displayed correctly on Safari: long cues will get cut off, rather Than wrapping and displaying multiple lines. This is because the height Of the div with pseudo-class webkit-media-text-track-display was Not being calculated with the correct unit. To fix this, I changed The unit from CQW to CQH. Added one layout test. * LayoutTests/http/tests/media/resources/hls/subtitles/verticalrl.vtt: Added. * LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line-expected.txt: Added. * LayoutTests/http/tests/media/track/track-webvtt-vertical-multi-line.html: Added. * Source/WebCore/html/track/VTTCue.cpp: (WebCore::VTTCueBox::applyCSSProperties) Canonical link: https://commits.webkit.org/267162@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes