Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b8288eb0b2ed4be5bac8f8a4765a751cf62b2e0b
https://github.com/WebKit/WebKit/commit/b8288eb0b2ed4be5bac8f8a4765a751cf62b2e0b
Author: novov <anon185...@gmail.com>
Date: 2024-05-13 (Mon, 13 May 2024)
Changed paths:
M
Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js
M
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js
M
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js
M
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js
Log Message:
-----------
Web Inspector: Fix issues with go to property arrow in Computed CSS pane when
details sidebar is unified
https://bugs.webkit.org/show_bug.cgi?id=272876
Reviewed by Devin Rousso.
When using the Elements tab of the Inspector, the Computed pane has a button to
jump to
the respective CSS property. This works well with the default two-column view,
but when
"show independent Styles sidebar" is disabled, it can fail to scroll the
respective CSS
into view or replace it with white space.
This commit fixes this problem:
- When opening details panes, do not reset the scroll position.
- Fix a bug that meant that focused/highlighted properties failed to update the
layout when
being initialised (this also can happen for other reasons,
but is outside the scope of this commit).
- Ensure that all previous properties are always deselected, as occurs already
in the
two-column view.
Combined changes:
* Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
(WI.GeneralStyleDetailsSidebarPanel.prototype.layout):
*
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
*
Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.deselectProperties):
*
Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
* Source/WebInspectorUI/UserInterface/Views/StyleDetailsPanel.js:
Canonical link: https://commits.webkit.org/278686@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
