Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c1fefa0bb16a18b82461ac3111b56f3395e7a1b7
https://github.com/WebKit/WebKit/commit/c1fefa0bb16a18b82461ac3111b56f3395e7a1b7
Author: Alex Christensen <achristen...@apple.com>
Date: 2024-04-26 (Fri, 26 Apr 2024)
Changed paths:
M Source/WebCore/editing/cocoa/AttributedString.h
M Source/WebCore/editing/cocoa/AttributedString.mm
M Source/WebKit/Shared/ContextMenuContextData.cpp
M Source/WebKit/Shared/ContextMenuContextData.h
M Source/WebKit/Shared/ContextMenuContextData.serialization.in
M Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
Log Message:
-----------
Simplify ContextMenuContextData serialization
https://bugs.webkit.org/show_bug.cgi?id=273329
rdar://124958882
Reviewed by Wenson Hsieh.
Instead of taking an AttributedString, extracting an NSAttributedString,
extracting an NSData, serializing the data, then reconstructing the
NSAttributedString on the other side, just serialize the AttributedString
then do one extraction operation to get an NSAttributedString.
* Source/WebCore/editing/cocoa/AttributedString.h:
* Source/WebKit/Shared/ContextMenuContextData.cpp:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledDataIsEditable const):
* Source/WebKit/Shared/ContextMenuContextData.h:
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::controlledSelection const):
(WebKit::ContextMenuContextData::controlledSelectionData const): Deleted.
* Source/WebKit/Shared/ContextMenuContextData.serialization.in:
* Source/WebKit/UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::setupServicesMenu):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleSelectionServiceClick):
Canonical link: https://commits.webkit.org/278074@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
