Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c5b08c20f512784e37cc065945098dc26b90c755 https://github.com/WebKit/WebKit/commit/c5b08c20f512784e37cc065945098dc26b90c755 Author: Ben Nham <n...@apple.com> Date: 2024-08-20 (Tue, 20 Aug 2024)
Changed paths: M Source/WebKit/webpushd/PushClientConnection.mm M Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h M Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm Log Message: ----------- Fix webpushtool on iOS https://bugs.webkit.org/show_bug.cgi?id=278404 rdar://134359279 Reviewed by Brady Eidson. webpushtool no longer works on iOS as of 282035@main since that patch expects all connections to webpushd to be associated with a host app. Fix this by allowing direct peers with the injection entitlement (like webpushtool) to not need a host app. I also changed the inject command in webpushtool to no longer take in bundleIdentifier and pushPartition, since there are already existing global flags on the tool that control that. This also allows this patch to play more nicely with an upcoming change (bug 278367) which restricts incoming connections to known bundle IDs. * Source/WebKit/webpushd/PushClientConnection.mm: (WebPushD::PushClientConnection::create): * Source/WebKit/webpushd/webpushtool/WebPushToolConnection.h: * Source/WebKit/webpushd/webpushtool/WebPushToolMain.mm: (printUsageAndTerminate): (pushMessageFromArguments): (WebKit::WebPushToolMain): Canonical link: https://commits.webkit.org/282526@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes