Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ca61c4e9a1033605f980bd6a33188e8bd5c08e5f https://github.com/WebKit/WebKit/commit/ca61c4e9a1033605f980bd6a33188e8bd5c08e5f Author: Alex Christensen <achristen...@apple.com> Date: 2023-06-17 (Sat, 17 Jun 2023)
Changed paths: M Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.h M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp M Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h M Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.cpp M Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.h M Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp M Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.h M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMFactory.cpp M Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMFactory.h M Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp M Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.h M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp M Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h M Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.cpp M Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.h M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp M Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h M Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp M Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.h M Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp M Source/WebKit/WebProcess/Notifications/WebNotificationManager.h M Source/WebKit/WebProcess/WebProcess.cpp M Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.cpp M Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.h M Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp M Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h M Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp M Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h Log Message: ----------- Use WebProcess::singleton instead of unnecessarily storing a duplicate pointer https://bugs.webkit.org/show_bug.cgi?id=257778 rdar://110364959 Reviewed by Michael Catanzaro. This reduces memory use. I'm not aware of any reason why we should store duplicate pointers to a singleton object. I'm not aware of plans to make it not a singleton. We need to still pass WebProcess& as a parameter to functions called from the WebProcess constructor, or we get infinite recursion in the singleton call. * Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.cpp: (WebKit::RemoteAudioHardwareListener::create): (WebKit::RemoteAudioHardwareListener::RemoteAudioHardwareListener): * Source/WebKit/WebProcess/GPU/media/RemoteAudioHardwareListener.h: * Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.cpp: (WebKit::RemoteAudioSession::create): (WebKit::RemoteAudioSession::RemoteAudioSession): * Source/WebKit/WebProcess/GPU/media/RemoteAudioSession.h: * Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.cpp: (WebKit::RemoteCDMFactory::RemoteCDMFactory): (WebKit::RemoteCDMFactory::gpuProcessConnection): * Source/WebKit/WebProcess/GPU/media/RemoteCDMFactory.h: * Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.cpp: (WebKit::RemoteImageDecoderAVFManager::RemoteImageDecoderAVFManager): * Source/WebKit/WebProcess/GPU/media/RemoteImageDecoderAVFManager.h: * Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMFactory.cpp: (WebKit::RemoteLegacyCDMFactory::RemoteLegacyCDMFactory): (WebKit::RemoteLegacyCDMFactory::gpuProcessConnection): * Source/WebKit/WebProcess/GPU/media/RemoteLegacyCDMFactory.h: * Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.cpp: (WebKit::RemoteMediaEngineConfigurationFactory::RemoteMediaEngineConfigurationFactory): (WebKit::RemoteMediaEngineConfigurationFactory::gpuProcessConnection): * Source/WebKit/WebProcess/GPU/media/RemoteMediaEngineConfigurationFactory.h: * Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp: (WebKit::RemoteMediaPlayerManager::RemoteMediaPlayerManager): * Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.h: (WebKit::RemoteMediaPlayerManager::parentProcess const): Deleted. * Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.cpp: (WebKit::RemoteRemoteCommandListener::create): (WebKit::RemoteRemoteCommandListener::RemoteRemoteCommandListener): * Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.h: * Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.cpp: (WebKit::RemoteMediaSessionHelper::RemoteMediaSessionHelper): (WebKit::RemoteMediaSessionHelper::ensureConnection): * Source/WebKit/WebProcess/GPU/media/ios/RemoteMediaSessionHelper.h: * Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.cpp: (WebKit::WebGeolocationManager::WebGeolocationManager): (WebKit::WebGeolocationManager::registerWebPage): (WebKit::WebGeolocationManager::unregisterWebPage): (WebKit::WebGeolocationManager::setEnableHighAccuracyForPage): * Source/WebKit/WebProcess/Geolocation/WebGeolocationManager.h: * Source/WebKit/WebProcess/Notifications/WebNotificationManager.cpp: (WebKit::WebNotificationManager::WebNotificationManager): * Source/WebKit/WebProcess/Notifications/WebNotificationManager.h: * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::transformHandlesToObjects): (WebKit::WebProcess::setUseGPUProcessForMedia): * Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.cpp: (WebKit::AudioSessionRoutingArbitrator::AudioSessionRoutingArbitrator): (WebKit::AudioSessionRoutingArbitrator::beginRoutingArbitrationWithCategory): (WebKit::AudioSessionRoutingArbitrator::leaveRoutingAbritration): (WebKit::AudioSessionRoutingArbitrator::canLog const): * Source/WebKit/WebProcess/cocoa/AudioSessionRoutingArbitrator.h: * Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.cpp: (WebKit::UserMediaCaptureManager::UserMediaCaptureManager): (WebKit::UserMediaCaptureManager::~UserMediaCaptureManager): * Source/WebKit/WebProcess/cocoa/UserMediaCaptureManager.h: * Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::transformHandlesToObjects): * Source/WebKit/WebProcess/glib/UserMediaCaptureManager.cpp: (WebKit::UserMediaCaptureManager::UserMediaCaptureManager): (WebKit::UserMediaCaptureManager::~UserMediaCaptureManager): * Source/WebKit/WebProcess/glib/UserMediaCaptureManager.h: Canonical link: https://commits.webkit.org/265274@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes