Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cd58fda2512a566be80f30aa8cf43285ff414dda
https://github.com/WebKit/WebKit/commit/cd58fda2512a566be80f30aa8cf43285ff414dda
Author: Alex Christensen <achristen...@apple.com>
Date: 2024-08-03 (Sat, 03 Aug 2024)
Changed paths:
M Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm
M Source/WebKit/Shared/WebErrors.cpp
M Source/WebKit/Shared/WebErrors.h
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm
Log Message:
-----------
Image decode failures should not be WebKit internal errors
https://bugs.webkit.org/show_bug.cgi?id=277595
rdar://133136320
Reviewed by Tim Horton.
If an image fails to decode, that should not be reported as an internal error,
it should be a decode error. Otherwise we get these in stderr:
ERROR: WebKit encountered an internal error. This is a WebKit bug.
Also, the process was getting shut down during the message, so in practice
if an image took more than a moment to load it would fail. I manually verified
that adding preventProcessShutdownScope to the message fixes this issue.
* Source/WebKit/Shared/Cocoa/WebErrorsCocoa.mm:
(WebKit::decodeError):
* Source/WebKit/Shared/WebErrors.cpp:
(WebKit::decodeError):
* Source/WebKit/Shared/WebErrors.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadAndDecodeImage):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/LoadAndDecodeImage.mm:
(TestWebKitAPI::TEST(WebKit, LoadAndDecodeImage)):
Canonical link: https://commits.webkit.org/281813@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
