Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: d9061430480df20b709c6a4014bf5eee587e8c73 https://github.com/WebKit/WebKit/commit/d9061430480df20b709c6a4014bf5eee587e8c73 Author: Karl Dubost <karl...@apple.com> Date: 2023-02-12 (Sun, 12 Feb 2023)
Changed paths: M LayoutTests/platform/gtk/fast/forms/basic-inputs-expected.txt M LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.txt M LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.txt M LayoutTests/platform/gtk/fast/forms/input-appearance-disabled-expected.txt M LayoutTests/platform/gtk/fast/forms/input-disabled-color-expected.txt M LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt M LayoutTests/platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt M LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt M LayoutTests/platform/ios/fast/forms/basic-inputs-expected.txt M LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt M LayoutTests/platform/ios/fast/forms/input-appearance-disabled-expected.txt M LayoutTests/platform/ios/fast/forms/input-disabled-color-expected.txt M LayoutTests/platform/ios/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt M LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt M LayoutTests/platform/ios/fast/forms/textarea-placeholder-pseudo-style-expected.txt M LayoutTests/platform/mac-bigsur/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt M LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt M LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt M LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt M LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt M LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt M LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt M LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt M LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt M Source/WebCore/css/html.css M Source/WebCore/css/parser/CSSParserContext.cpp M Source/WebCore/html/HTMLTextFormControlElement.cpp M Source/WebCore/rendering/RenderTheme.cpp M Source/WebCore/rendering/RenderTheme.h Log Message: ----------- CSS color gets adjusted for disabled input elements https://bugs.webkit.org/show_bug.cgi?id=54643 rdar://99826522 Reviewed by Tim Nguyen. Currently WebKit overrides any style which is being chosen for input:disabled by web developers. This fixes this by adjusting a simpler default and making it possible for developers to adjust the CSS. The solution proposed by Tim Nguyen is using color-mix(). * LayoutTests/platform/gtk/fast/forms/basic-inputs-expected.txt: * LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.txt: * LayoutTests/platform/gtk/fast/forms/basic-textareas-quirks-expected.txt: * LayoutTests/platform/gtk/fast/forms/input-appearance-disabled-expected.txt: * LayoutTests/platform/gtk/fast/forms/input-disabled-color-expected.txt: * LayoutTests/platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt: * LayoutTests/platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt: * LayoutTests/platform/ios-wk2/fast/forms/basic-textareas-quirks-expected.txt: * LayoutTests/platform/ios/fast/forms/basic-inputs-expected.txt: * LayoutTests/platform/ios/fast/forms/basic-textareas-expected.txt: * LayoutTests/platform/ios/fast/forms/input-appearance-disabled-expected.txt: * LayoutTests/platform/ios/fast/forms/input-disabled-color-expected.txt: * LayoutTests/platform/ios/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: * LayoutTests/platform/ios/fast/forms/placeholder-pseudo-style-expected.txt: * LayoutTests/platform/ios/fast/forms/textarea-placeholder-pseudo-style-expected.txt: * LayoutTests/platform/mac-bigsur/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: * LayoutTests/platform/mac/fast/forms/basic-inputs-expected.txt: * LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt: * LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt: * LayoutTests/platform/mac/fast/forms/input-appearance-disabled-expected.txt: * LayoutTests/platform/mac/fast/forms/input-disabled-color-expected.txt: * LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt: * LayoutTests/platform/mac/fast/forms/placeholder-pseudo-style-expected.txt: * LayoutTests/platform/mac/fast/forms/textarea-placeholder-pseudo-style-expected.txt: * Source/WebCore/css/html.css: (input:disabled, textarea:disabled): * Source/WebCore/css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext): * Source/WebCore/html/HTMLTextFormControlElement.cpp: (WebCore::HTMLTextFormControlElement::adjustInnerTextStyle const): * Source/WebCore/rendering/RenderTheme.cpp: (WebCore::RenderTheme::disabledTextColor const): Deleted. * Source/WebCore/rendering/RenderTheme.h: Co-authored-by: Tim Nguyen <n...@apple.com> Canonical link: https://commits.webkit.org/260180@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes