Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dc5b85ccaaa794bae50ea2e87ba296e40d311912 https://github.com/WebKit/WebKit/commit/dc5b85ccaaa794bae50ea2e87ba296e40d311912 Author: Jonathan Bedard <jbed...@apple.com> Date: 2023-04-18 (Tue, 18 Apr 2023)
Changed paths: M Tools/Scripts/webkitpy/tool/commands/commandtest.py M Tools/Scripts/webkitpy/tool/commands/upload.py M Tools/Scripts/webkitpy/tool/commands/upload_unittest.py M Tools/Scripts/webkitpy/tool/steps/__init__.py A Tools/Scripts/webkitpy/tool/steps/checkforredactedissue.py Log Message: ----------- [webkit-patch] Check issue redaction before upload https://bugs.webkit.org/show_bug.cgi?id=255565 rdar://108169167 Rubber-stamped by Alan Baradlay. webkit-patch should check if a patch references a redacted issue, just like git-webkit. * Tools/Scripts/webkitpy/tool/commands/commandtest.py: (CommandsTest.assert_execute_outputs): Check command output, even when exceptions are raised. * Tools/Scripts/webkitpy/tool/commands/upload.py: (AbstractPatchUploadingCommand._issues): List all issues associated with patch being uploaded. (AbstractPatchUploadingCommand._prepare_state): Cache issues associated with patch. (Post): Check that associated issues are not redacted. (LandSafely): Ditto. (Upload): Ditto. (Upload._prepare_state): Cache issues associated with patch. * Tools/Scripts/webkitpy/tool/commands/upload_unittest.py: (MockIssue): (MockRedaction): (UploadCommandsTest.test_upload_blocked): (UploadCommandsTest.test_upload_exempt): * Tools/Scripts/webkitpy/tool/steps/__init__.py: Export CheckForRedactedIssue. * Tools/Scripts/webkitpy/tool/steps/checkforredactedissue.py: Added. (CheckForRedactedIssue): Abandon upload if associated issues are redacted. Canonical link: https://commits.webkit.org/263104@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes