Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: dd8a70a9a04ae18662927c72e36264c4c8b2701d https://github.com/WebKit/WebKit/commit/dd8a70a9a04ae18662927c72e36264c4c8b2701d Author: Ryosuke Niwa <rn...@webkit.org> Date: 2023-05-19 (Fri, 19 May 2023)
Changed paths: M Source/WebCore/accessibility/AccessibilityRenderObject.cpp M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm M Source/WebCore/editing/AlternativeTextController.cpp M Source/WebCore/editing/Editor.cpp M Source/WebCore/editing/Editor.h M Source/WebCore/editing/EditorCommand.cpp M Source/WebCore/editing/FrameSelection.cpp M Source/WebCore/editing/FrameSelection.h M Source/WebCore/editing/SpellingCorrectionCommand.cpp M Source/WebCore/editing/TypingCommand.cpp M Source/WebCore/editing/cocoa/EditorCocoa.mm M Source/WebCore/page/DOMSelection.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/FocusController.cpp M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp M Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm M Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm M Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm M Source/WebKitLegacy/mac/WebView/WebFrame.mm M Source/WebKitLegacy/mac/WebView/WebFrameInternal.h M Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm Log Message: ----------- Convert more enums in FrameSelection.h into enum classes https://bugs.webkit.org/show_bug.cgi?id=257003 Reviewed by Chris Dumez. * Source/WebCore/accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::setSelectedTextRange): (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine const): (WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const): * Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: (-[WebAccessibilityObjectWrapper accessibilityModifySelection:increase:]): (-[WebAccessibilityObjectWrapper accessibilityMoveSelectionToMarker:]): * Source/WebCore/editing/AlternativeTextController.cpp: (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection): * Source/WebCore/editing/Editor.cpp: (WebCore::TemporarySelectionChange::setSelection): (WebCore::Editor::appliedEditing): (WebCore::Editor::markAndReplaceFor): (WebCore::Editor::setIgnoreSelectionChanges): (WebCore::Editor::insertTextPlaceholder): (WebCore::Editor::removeTextPlaceholder): (WebCore::Editor::respondToChangedSelection): * Source/WebCore/editing/Editor.h: * Source/WebCore/editing/EditorCommand.cpp: (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection): * Source/WebCore/editing/FrameSelection.cpp: (WebCore::FrameSelection::moveTo): (WebCore::FrameSelection::moveWithoutValidationTo): (WebCore::FrameSelection::setSelectionByMouseIfDifferent): (WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::updateAndRevealSelection): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWasReplaced): (WebCore::FrameSelection::willBeModified): (WebCore::FrameSelection::textSelectionIntent): (WebCore::FrameSelection::modify): (WebCore::FrameSelection::willBeRemovedFromFrame): (WebCore::FrameSelection::setStart): (WebCore::FrameSelection::setEnd): (WebCore::FrameSelection::setBase): (WebCore::FrameSelection::setExtent): (WebCore::FrameSelection::selectAll): (WebCore::FrameSelection::setSelectedRange): (WebCore::FrameSelection::revealSelection): (WebCore::FrameSelection::rangeByMovingCurrentSelection const): (WebCore::FrameSelection::rangeByExtendingCurrentSelection const): (WebCore::FrameSelection::wordSelectionContainingCaretSelection): (WebCore::FrameSelection::rangeByAlteringCurrentSelection const): * Source/WebCore/editing/FrameSelection.h: (WebCore::FrameSelection::defaultSetSelectionOptions): * Source/WebCore/editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply): * Source/WebCore/editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): * Source/WebCore/editing/cocoa/EditorCocoa.mm: (WebCore::Editor::replaceNodeFromPasteboard): * Source/WebCore/page/DOMSelection.cpp: (WebCore::DOMSelection::modify): * Source/WebCore/page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): (WebCore::setInitialKeyboardSelection): (WebCore::handleKeyboardSelectionMovement): * Source/WebCore/page/FocusController.cpp: (WebCore::FocusController::advanceFocusInDocumentOrder): * Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm: (WebKit::WebPage::replaceImageForRemoveBackground): * Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp: (WebKit::WebFoundTextRangeController::flashTextIndicatorAndUpdateSelectionWithRange): * Source/WebKit/WebProcess/WebPage/ios/FindControllerIOS.mm: (WebKit::FindController::didFindString): * Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::didConcludeEditDrag): (WebKit::WebPage::selectWithGesture): (WebKit::WebPage::updateSelectionWithTouches): (WebKit::WebPage::selectWithTwoTouches): (WebKit::WebPage::setSelectedRangeDispatchingSyntheticMouseEventsIfNeeded): (WebKit::WebPage::selectWordBackward): (WebKit::WebPage::moveSelectionByOffset): (WebKit::WebPage::selectPositionAtPoint): (WebKit::WebPage::selectPositionAtBoundaryWithDirection): (WebKit::WebPage::moveSelectionAtBoundaryWithDirection): (WebKit::WebPage::setSelectionRange): (WebKit::WebPage::updateSelectionWithExtentPointAndBoundary): (WebKit::WebPage::updateSelectionWithExtentPoint): (WebKit::WebPage::prepareSelectionForContextMenuWithLocationInView): (WebKit::WebPage::updateSelectionWithDelta): (WebKit::WebPage::focusTextInputContextAndPlaceCaret): * Source/WebKitLegacy/mac/DOM/DOMUIKitExtensions.mm: (-[DOMRange move:inDirection:]): (-[DOMRange extend:inDirection:]): * Source/WebKitLegacy/mac/WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::imageForCurrentSharingServicePickerItem): * Source/WebKitLegacy/mac/WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebFrame revealSelectionAtExtent:]): (-[WebFrame setSelectedDOMRange:affinity:closeTyping:userTriggered:]): (-[WebFrame selectNSRange:onElement:]): * Source/WebKitLegacy/mac/WebView/WebFrameInternal.h: * Source/WebKitLegacy/mac/WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]): Canonical link: https://commits.webkit.org/264238@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes