Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e88ecb4429f7cd842238e5571aaa7f5557bc23c8
https://github.com/WebKit/WebKit/commit/e88ecb4429f7cd842238e5571aaa7f5557bc23c8
Author: Alan Baradlay <za...@apple.com>
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
A
LayoutTests/fast/text/overflow-ellipsis-on-negative-letter-spacing-expected.txt
A LayoutTests/fast/text/overflow-ellipsis-on-negative-letter-spacing.html
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp
Log Message:
-----------
ASSERTION FAILED: displayLine.lineBoxLogicalRect().x() +
displayLine.contentLogicalLeft() + displayLine.contentLogicalWidth() +
ellipsisWidth > displayLine.lineBoxLogicalRect().maxX()
https://bugs.webkit.org/show_bug.cgi?id=262261
<rdar://problem/116503423>
Reviewed by Antti Koivisto.
Negative (large) letter spacing produces negative ellipsis width.
- such negative widths confuse truncation logic
- harden the case when line box has negative width too due to large negative
letter spacing
- expand the assert to cover cases when line has inline-box trailing content.
*
LayoutTests/fast/text/overflow-ellipsis-on-negative-letter-spacing-expected.txt:
Added.
* LayoutTests/fast/text/overflow-ellipsis-on-negative-letter-spacing.html:
Added.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilder.cpp:
(WebCore::Layout::truncateOverflowingDisplayBoxes):
(WebCore::Layout::InlineDisplayLineBuilder::trailingEllipsisVisualRectAfterTruncation):
Canonical link: https://commits.webkit.org/276125@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
