Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ebc58cded3cedd1d63ee3489de51c0765cbe45c5 https://github.com/WebKit/WebKit/commit/ebc58cded3cedd1d63ee3489de51c0765cbe45c5 Author: Antoine Quint <grao...@apple.com> Date: 2023-01-12 (Thu, 12 Jan 2023)
Changed paths: M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h M Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h M Source/WebCore/platform/graphics/ca/PlatformCAFilters.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm M Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm M Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp M Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.h M Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h M Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm Log Message: ----------- Clean up PlatformCAFilters https://bugs.webkit.org/show_bug.cgi?id=250509 Reviewed by Simon Fraser. PlatformCAFilters has a `USE_CA_FILTERS` compile-time flag that can no longer be false on Cocoa ports and the notion of an "internalFilterPropertyIndex" which is no longer relevant without `USE_CA_FILTERS`. The removal of internalFilterPropertyIndex percolates up to GraphicsLayerCA since it was used for animation purposes, so we remove any trace of an animation "sub-index" there too. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::updateAnimations): (WebCore::GraphicsLayerCA::createAnimationFromKeyframes): (WebCore::GraphicsLayerCA::appendToUncommittedAnimations): (WebCore::GraphicsLayerCA::setFilterAnimationEndpoints): (WebCore::GraphicsLayerCA::setFilterAnimationKeyframes): (WebCore::GraphicsLayerCA::dumpAnimations): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation): (WebCore::GraphicsLayerCA::LayerPropertyAnimation::animationIdentifier const): * Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h: * Source/WebCore/platform/graphics/ca/PlatformCAFilters.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h: * Source/WebCore/platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm: (WebCore::PlatformCAAnimationCocoa::setFromValue): (WebCore::PlatformCAAnimationCocoa::setToValue): (WebCore::PlatformCAAnimationCocoa::setValues): * Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm: (WebCore::PlatformCAFilters::setFiltersOnLayer): (WebCore::PlatformCAFilters::filterValueForOperation): (WebCore::PlatformCAFilters::colorMatrixValueForFilter): (WebCore::PlatformCAFilters::setBlendingFiltersOnLayer): (WebCore::PlatformCAFilters::isAnimatedFilterProperty): (WebCore::PlatformCAFilters::animatedFilterPropertyName): (WebCore::PlatformCAFilters::numAnimatedFilterProperties): Deleted. * Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp: (PlatformCAAnimationWin::setFromValue): (PlatformCAAnimationWin::setToValue): (PlatformCAAnimationWin::setValues): * Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.h: * Source/WebCore/platform/graphics/ca/win/PlatformCAFiltersWin.cpp: (PlatformCAFilters::setFiltersOnLayer): (PlatformCAFilters::isAnimatedFilterProperty): (PlatformCAFilters::animatedFilterPropertyName): (PlatformCAFilters::numAnimatedFilterProperties): Deleted. * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm: (WebKit::PlatformCAAnimationRemote::setFromValue): (WebKit::PlatformCAAnimationRemote::setToValue): (WebKit::PlatformCAAnimationRemote::setValues): (WebKit::animationValueFromKeyframeValue): Canonical link: https://commits.webkit.org/258836@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes