Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: ed93c318ea694da22ab23080a68b7f6240ed997f https://github.com/WebKit/WebKit/commit/ed93c318ea694da22ab23080a68b7f6240ed997f Author: Marcos Caceres <mar...@marcosc.com> Date: 2023-09-29 (Fri, 29 Sep 2023)
Changed paths: M LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt M LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue.html A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground-expected.txt A LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical.html M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor-expected.txt M LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor.html M LayoutTests/inspector/model/remote-object/dom-expected.txt M LayoutTests/media/track/texttrackcue/texttrackcue-constructor-expected.txt M LayoutTests/media/track/texttrackcue/texttrackcue-constructor.html M Source/WebCore/html/HTMLAttributeNames.in M Source/WebCore/html/HTMLElement.idl M Source/WebCore/html/track/TextTrackCue.cpp Log Message: ----------- Implement updated TextTrackCue constructor proposal https://bugs.webkit.org/show_bug.cgi?id=262053 rdar://116002871 Reviewed by Eric Carlson. Implements spec changes suggested at: https://github.com/whatwg/html/pull/9771 Specifically: * supports `b` and `i` elements, to match WebVTT * drops support for allowing `img` in the cue fragment * implements more robust error checking to prevent malformed ::cue and :cuebackground hierarchies * As such, ::tagPseudoObjects() can now throw * Switch from InvalidStateError to InvalidNodeTypeError for when required attributes are missing * implements cuebackground and cue global attributes * LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html: * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cue.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/cuebackground.html: Added. * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/historical.html: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/constructor.html: * LayoutTests/inspector/model/remote-object/dom-expected.txt: * LayoutTests/media/track/texttrackcue/texttrackcue-constructor-expected.txt: * LayoutTests/media/track/texttrackcue/texttrackcue-constructor.html: * Source/WebCore/html/HTMLAttributeNames.in: * Source/WebCore/html/HTMLElement.idl: * Source/WebCore/html/track/TextTrackCue.cpp: (WebCore::isLegalNode): (WebCore::tagPseudoObjects): (WebCore::removePseudoAttributes): (WebCore::TextTrackCue::create): (WebCore::TextTrackCue::setPauseOnExit): (WebCore::cueAttributName): Deleted. (WebCore::cueBackgroundAttributName): Deleted. Canonical link: https://commits.webkit.org/268644@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes