[webkit-changes] [WebKit/WebKit] eff576: [JSC] Use JavaScriptCore framework dyld UUID for c...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: eff5765b8477190745b7957c20f46e56c6e89fb5
      
https://github.com/WebKit/WebKit/commit/eff5765b8477190745b7957c20f46e56c6e89fb5
  Author: Yijia Huang <yijia_hu...@apple.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M Source/JavaScriptCore/CMakeLists.txt
    M Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
    M Source/JavaScriptCore/Sources.txt
    M Source/JavaScriptCore/runtime/CachedTypes.cpp
    A Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp
    R Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp.in
    M Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.h
    M Source/JavaScriptCore/runtime/JSGlobalObjectFunctions.cpp
    M Source/WTF/wtf/spi/darwin/dyldSPI.h

  Log Message:
  -----------
  [JSC] Use JavaScriptCore framework dyld UUID for computing bytecode cache 
version
https://bugs.webkit.org/show_bug.cgi?id=272660
rdar://126195542

Reviewed by Yusuke Suzuki.

Previously, we used the JSCBuiltins.o, CachedTypes.o, and project source version
number for computing JSC bytecode cache version. That may not strong enough
to reject a stale bytecode cache. This patch utilizes JavaScriptCore.framework’s
UUID to compute the bytecode cache hash version for Darwin OSes and uses
__TIMESTAMP__ for the others.

* Source/JavaScriptCore/CMakeLists.txt:
* Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:
* Source/JavaScriptCore/Sources.txt:
* Source/JavaScriptCore/runtime/CachedTypes.cpp:
(JSC::GenericCacheEntry::GenericCacheEntry):
(JSC::GenericCacheEntry::isUpToDate const):
* Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp: Added.
(JSC::computeJSCBytecodeCacheVersion):
* Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.cpp.in: Removed.
* Source/JavaScriptCore/runtime/JSCBytecodeCacheVersion.h:

Canonical link: https://commits.webkit.org/277548@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes