[webkit-dev] A question about SubresourceLoader

2008-12-19 Thread Cameron Zwarich
Why is SubresourceLoader::m_client a pointer, and why is it also null- checked? It is only set by its private constructor that is called from ::create(), which is always called from a SubresourceLoaderClient with 'this' as the client parameter. Shouldn't it just be a reference? Maybe I am mi

Re: [webkit-dev] A question about SubresourceLoader

2008-12-19 Thread Cameron Zwarich
On 19-Dec-08, at 1:01 AM, Cameron Zwarich wrote: Why is SubresourceLoader::m_client a pointer, and why is it also null-checked? It is only set by its private constructor that is called from ::create(), which is always called from a SubresourceLoaderClient with 'this' as the client parameter

Re: [webkit-dev] Huge Memory Leak: How to restrict?

2008-12-19 Thread Dhananjoy Chutia
Hi, Thank you for your information. I had done the following modification in WebKit-r39293 & observed the VmSize of GtkLauncher for more than 40 minutes & found no increase. Please let me know whether my modification is correct or not. It is to be noted that WebKit is configured with *--with-tar

Re: [webkit-dev] How webkit on android implements magnifying glass?

2008-12-19 Thread Cary Clark
On Thursday 18 December 2008 07:50:00 ying lcs wrote: > In webkit on android, it has a 'magnifying glass' feature: in the zoom > out view, it has a viewing rectangle which shows the content in 100%. > > Can you please point to me where is the code how webkit on android > implements magnifying glass

Re: [webkit-dev] Huge Memory Leak: How to restrict?

2008-12-19 Thread Dhananjoy Chutia
Hi, The statement *d->m_msg = NULL* is removed as I observed that *m_msg* is g_object_unref ed at ResourceHandleInternal::~ResourceHandleInternal() { if (m_msg) { g_object_unref(m_msg); m_msg = 0; } } but never executed. So, as per my understanding, the statement* d->m

Re: [webkit-dev] Huge Memory Leak: How to restrict?

2008-12-19 Thread David Kilzer
Please file a bug on following these instructions, and attach your patch for review (setting the "review?" flag): http://webkit.org/coding/contributing.html Be sure to include a ChangeLog entry with your patch. Thanks! Dave From:

[webkit-dev] Extending Web Inspector

2008-12-19 Thread alvaro
Hi all, I want to share an an article that I wrote on how to extend WebKit Web Inspector http://obvioushints.blogspot.com/2008/12/extending-webkit-web-inspector-with-fun.html Cheers, Alvaro ___ webkit-dev mailing list webkit-dev@lists.webkit.org h

Re: [webkit-dev] Build error of Web kit on ubuntu

2008-12-19 Thread Meryl Silverburgh
I reget the source code. It looks like the problem goes away. On Thu, Dec 18, 2008 at 11:47 PM, Meryl Silverburgh wrote: > And I do have 'glib-mkenums ' in usr/bin > > Here are the error I get. I am building using this > 'WebKitTools/Scripts/build-webkit --gtk --debug' > > WebKit was configured