Re: [webkit-dev] Review Queue

2009-05-21 Thread Zoltan Herczeg
Hi, > If a bug totally stalls, and is sitting in the bug database untouched, > I view that as the responsible reviewers' implicit rejection of the > bug. I, as a responsible reviewer, am simply making explicit that > implicit rejection. Personally, I'd rather get a "closed" on my bugs > than have

Re: [webkit-dev] Notifications API

2009-05-21 Thread Ian Hickson
On Thu, 21 May 2009, John Gregg wrote: > > On the security question, a substantial amount of thought has gone into > how to prevent unwanted popups (and in general how to control access to > HTML5 application features). We think user opt-in on an origin-basis is > the best policy and it's what

Re: [webkit-dev] Review Queue

2009-05-21 Thread Kevin Ollivier
Hi Eric, On May 21, 2009, at 9:47 PM, Eric Seidel wrote: Interesting analogy. However, closing means to me that the community is done with the bug. Denying a patch because no one's working on it anymore (aka, no one is there to respond to review comments even if you make them) is not the same

[webkit-dev] Notifications API

2009-05-21 Thread John Gregg
I circulated a proposal several weeks ago which specified a notifications API for workers (desktop toasts), and the feedback was that (a) persistent workers are still far away, (b) is a notifications api necessary given it's basically a new window?, and (c) have we thought through the security issu

Re: [webkit-dev] Review Queue

2009-05-21 Thread Peter Kasting
On Thu, May 21, 2009 at 10:08 PM, Maciej Stachowiak wrote: > If you want to r- a patch for a reason, such as being too big, or having > feedback already that hasn't been addressed, that's fine. But I think it > would be a bad idea to reject patches just because they haven't been > reviewed for to

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 9:47 PM, Eric Seidel wrote: Interesting analogy. However, closing means to me that the community is done with the bug. Denying a patch because no one's working on it anymore (aka, no one is there to respond to review comments even if you make them) is not the same as closi

Re: [webkit-dev] Review Queue

2009-05-21 Thread Eric Seidel
Interesting analogy. However, closing means to me that the community is done with the bug. Denying a patch because no one's working on it anymore (aka, no one is there to respond to review comments even if you make them) is not the same as closing a bug. There is a "forgotten patches" link on th

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 9:10 PM, Peter Kasting wrote: On Thu, May 21, 2009 at 8:52 PM, Eric Seidel wrote: Our current defacto policy requires involvement on both sides. Submitters need to be involved in finding people to review their patches. Posting patches to the review queue does not automatic

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 9:18 PM, Ojan Vafai wrote: It makes no sense to me to r- a patch because reviewers don't have time to review it. It put incentive in the wrong place. There are other solutions to this problem that put incentive in the right place (i.e. with reviewers). I don't necessari

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 9:36 PM, Geoffrey Garen wrote: Our current defacto policy requires involvement on both sides. Submitters need to be involved in finding people to review their patches. Posting patches to the review queue does not automatically get you a review, except occasionally by Darin

Re: [webkit-dev] Review Queue

2009-05-21 Thread Geoffrey Garen
Our current defacto policy requires involvement on both sides. Submitters need to be involved in finding people to review their patches. Posting patches to the review queue does not automatically get you a review, except occasionally by Darin Adler or myself. If a bug totally stalls, and is sitt

Re: [webkit-dev] Review Queue

2009-05-21 Thread Ojan Vafai
It makes no sense to me to r- a patch because reviewers don't have time to review it. It put incentive in the wrong place. There are other solutions to this problem that put incentive in the right place (i.e. with reviewers). I don't necessarily think these are good ideas, but I'll throw them out t

Re: [webkit-dev] Review Queue

2009-05-21 Thread Peter Kasting
On Thu, May 21, 2009 at 8:52 PM, Eric Seidel wrote: > Our current defacto policy requires involvement on both sides. > Submitters need to be involved in finding people to review their > patches. Posting patches to the review queue does not automatically > get you a review, except occasionally by

Re: [webkit-dev] Review Queue

2009-05-21 Thread Eric Seidel
Sorry I missed on on IRC, I would have been happy to chat further. Our current defacto policy requires involvement on both sides. Submitters need to be involved in finding people to review their patches. Posting patches to the review queue does not automatically get you a review, except occasion

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 7:57 PM, Eric Seidel wrote: I think it's better to get things out of the queue then to leave them rot. But it's not the patch submitter's fault if the reviewers have been delinquent in review. And making them resubmit the same patch after a blanket r- is useless busyw

Re: [webkit-dev] Review Queue

2009-05-21 Thread Eric Seidel
I think it's better to get things out of the queue then to leave them rot. Your review are most welcome. :) -eric On Fri, May 22, 2009 at 12:48 PM, Maciej Stachowiak wrote: > > On May 21, 2009, at 7:27 PM, Eric Seidel wrote: > >> Our review process seems to be failing.  As a reviewer, let me ex

Re: [webkit-dev] Review Queue

2009-05-21 Thread Maciej Stachowiak
On May 21, 2009, at 7:27 PM, Eric Seidel wrote: Our review process seems to be failing. As a reviewer, let me extend my apologies to the WebKit community as I am part of this failure. We have over 100 patches in the review queue at the moment: http://webkit.org/pending-review I've started go

[webkit-dev] Review Queue

2009-05-21 Thread Eric Seidel
Our review process seems to be failing. As a reviewer, let me extend my apologies to the WebKit community as I am part of this failure. We have over 100 patches in the review queue at the moment: http://webkit.org/pending-review I've started going through the list and reviewing what patches I ca

Re: [webkit-dev] How to add a attribute for "object" tag and can be modified by JavaScript

2009-05-21 Thread naixuan guan
yes , I know "object" tag use "data" not "src", but I want to realize the "src" attribute :) 2009/5/21 Eric Seidel > tags use data="" not src="". Blame HTML 4. > http://www.w3.org/TR/REC-html40/struct/objects.html#h-13.3 > > -eric > > 2009/5/22 Darin Adler : > > On May 21, 2009, at 7:12 AM,

Re: [webkit-dev] Webkit JavaScript question

2009-05-21 Thread Zoltan Herczeg
Hi, The JavaScript engine does 3 steps: 1) Parse JS files 2) Generate SquirellFish byte code (ByteCodeGenerator.h is part of it) 3) Compile SF byte code to machine code by its JIT compiler (optional) The last step depends on the architecture (supported or not) and C++ compiler directives. If JIT

Re: [webkit-dev] policyBaseURL and mainDocumentURL

2009-05-21 Thread Adam Barth
On Thu, May 21, 2009 at 10:54 AM, Darin Adler wrote: > On May 20, 2009, at 11:22 PM, Adam Barth wrote: > >> I'm trying to sort out all the security / privacy URLs we have, and I'm a >> bit puzzled by ResourceRequestBase::mainDocumentURL and >> Document::policyBaseURL.  They both seem connected to

[webkit-dev] Webkit JavaScript question

2009-05-21 Thread Lucius Fox
Hi, Can you please tell me what is the difference between ByteCodeGenerator.h and JIT.h? I assume ByteCodeGenerator is convert a raw .js file into JavaScript VM opecode and will be executed by Webkit JavaScript VM. and JIT convert a raw .js file into native machine code and will be executed by op

Re: [webkit-dev] policyBaseURL and mainDocumentURL

2009-05-21 Thread Darin Adler
On May 20, 2009, at 11:22 PM, Adam Barth wrote: I'm trying to sort out all the security / privacy URLs we have, and I'm a bit puzzled by ResourceRequestBase::mainDocumentURL and Document::policyBaseURL. They both seem connected to third-party cookie blocking. Are they the same? I believ

Re: [webkit-dev] How to add a attribute for "object" tag and can be modified by JavaScript

2009-05-21 Thread Eric Seidel
tags use data="" not src="". Blame HTML 4. http://www.w3.org/TR/REC-html40/struct/objects.html#h-13.3 -eric 2009/5/22 Darin Adler : > On May 21, 2009, at 7:12 AM, naixuan guan wrote: > >> when I open the HTML page like follow: >> >> >> >> alert(document.StormPlayer.src); >> >> >> the warning

Re: [webkit-dev] How to add a attribute for "object" tag and can be modified by JavaScript

2009-05-21 Thread Darin Adler
On May 21, 2009, at 7:12 AM, naixuan guan wrote: when I open the HTML page like follow: OBJECT> alert(document.StormPlayer.src); the warning message will show "undefined". why? Because not every HTML attribute has a corresponding JavaScript property. But alert(document.getElementById(

[webkit-dev] How to add a attribute for "object" tag and can be modified by JavaScript

2009-05-21 Thread naixuan guan
when I open the HTML page like follow: alert(document.StormPlayer.src); the warning message will show "undefined". why? can I add the "src" attribute to "object" tag and can be modified by JavaScript? ___ webkit-dev mailing list webkit-dev@lists.web

Re: [webkit-dev] KJS::JSObject question

2009-05-21 Thread Jack Wootton
Hello, Having read through the following document "Using JavaScript From Objective-C": http://developer.apple.com/documentation/AppleApplications/Conceptual/SafariJSProgTopics/Tasks/ObjCFromJavaScript.html#//apple_ref/doc/uid/30001215-BBCBFJCD It seems that the method: WebView::windowScriptObje

Re: [webkit-dev] Need help/Suggestions to understand the framework of webkit

2009-05-21 Thread guruhb
Thanks for the early response. We are implementing web 2.0 framework for mobile phone and we need to know below. 1. Javascript execution in webkit 2. DOM interaction with Javascriptcore. can i install a safari tool kit on windows environment and is it possible for me to debug and get the ca

[webkit-dev] Need help/Suggestions to understand the framework of webkit

2009-05-21 Thread guruhb
Hi All, Please guide me to understand the core framework used in webkit. Suggest me if any book or any URL which gives us documentation of webkit modules. Thanks in Advance, Guru ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.w