Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Darin Fisher
On Wed, Jul 22, 2009 at 10:52 PM, Alexey Proskuryakov a...@webkit.org wrote: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing the same. Was that a recent

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Maciej Stachowiak
On Jul 22, 2009, at 11:24 PM, Darin Fisher wrote: On Wed, Jul 22, 2009 at 10:52 PM, Alexey Proskuryakov a...@webkit.org wrote: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat

[webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Luke Kenneth Casson Leighton
starting here: https://bugs.webkit.org/show_bug.cgi?id=27435#c3 the issue is raised and noted that the W3C specification has several functions with the exact same name and several parameters, and that c simply is not equipped to cope with this. the reason why i'm raising this on webkit-dev is

Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Maciej Stachowiak
Responding to review comments should be done in the relevant bugzilla bug, not on the mailing list. It's ok to post here if you think an issue needs wider input from the community, but that doesn't seem to be the case with this issue. Regards, Maciej On Jul 23, 2009, at 5:18 AM, Luke

[webkit-dev] Changing two unit tests: 'alt' as accessible name instead of description

2009-07-23 Thread Mario Sanchez Prada
Hi, As the result of working in bug 25524 (see [1] for more details), we have reached the conclusion (and not only to fix that bug) that perhaps it would be good to change how the 'alt' attribute is exposed to ATs, switching from being the accessible description to be the accessible name. This

Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Luke Kenneth Casson Leighton
On 7/23/09, Maciej Stachowiak m...@apple.com wrote: Responding to review comments should be done in the relevant bugzilla bug, not on the mailing list. It's ok to post here if you think an issue needs wider input from the community, but that doesn't seem to be the case with this issue.

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread 신정식, 申政湜
Thank you all for the comments. I'll write to whatwg and public-html about adding it to window.navigator (yes, I meant navigator :-)) ). 2009/7/22 Alexey Proskuryakov a...@webkit.org: 22.07.2009, в 22:36, Darin Fisher написал(а): Firefox and Chrome send very similar A-L headers.  Given FF's

Re: [webkit-dev] Changing two unit tests: 'alt' as accessible name instead of description

2009-07-23 Thread Chris Fleizach
I don't think you want to return the altTag in stringValue(). That should only be for things that have actual strings (textfields, text rendered onto the screen) Right now titleAttr is exposed for all elements in the ::title() method. Perhaps that is incorrect, but its hard to get this

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Darin Adler
On Jul 22, 2009, at 10:36 PM, Darin Fisher wrote: Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing the same. Was that a recent observation? Can you provide more details about the issues you observed? I’m not

[webkit-dev] Name Getters

2009-07-23 Thread Eric Seidel
Is it possible to move a name getter onto a different JavaScript object? Example: JSValue JSHTMLFormElement::nameGetter(ExecState* exec, const Identifier propertyName, const PropertySlot slot) { JSHTMLElement* jsForm = static_castJSHTMLFormElement*(asObject(slot.slotBase()));

Re: [webkit-dev] Name Getters

2009-07-23 Thread Eric Seidel
Ah! Nevermind. nameGetter is static. static JSC::JSValue nameGetter(JSC::ExecState*, const JSC::Identifier, const JSC::PropertySlot); -eric On Thu, Jul 23, 2009 at 3:04 PM, Eric Seidele...@webkit.org wrote: Is it possible to move a name getter onto a different JavaScript object?

[webkit-dev] document()-frame()-script()-globalObject()

2009-07-23 Thread Eric Seidel
It seems all lookups of the current globalObject go through the frame. document()-frame()-script()-globalObject() is one example. Another: JSValue toJS(ExecState*, DOMWindow* domWindow) { if (!domWindow) return jsNull(); Frame* frame = domWindow-frame(); if (!frame)

Re: [webkit-dev] document()-frame()-script()-globalObject()

2009-07-23 Thread Eric Seidel
Yes, sorry to be confusing. I was attempting to provide examples of how we currently go through the frame() every time we need the JSDOMGlobalObject. It sounds like you agree with me, that the Document should have a way to get to the JSDOMGlobalObject w/o having to go through the Frame. Am I

Re: [webkit-dev] document()-frame()-script()-globalObject()

2009-07-23 Thread Maciej Stachowiak
On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote: It seems all lookups of the current globalObject go through the frame. document()-frame()-script()-globalObject() is one example. Another: JSValue toJS(ExecState*, DOMWindow* domWindow) { if (!domWindow) return jsNull(); Frame*

Re: [webkit-dev] document()-frame()-script()-globalObject()

2009-07-23 Thread Eric Seidel
I'm trying to get a JSDOMGlobalObject from a Node*. A Node* should always have one, but our current path through Frame* can sometimes fail. -eric On Thu, Jul 23, 2009 at 5:33 PM, Maciej Stachowiakm...@apple.com wrote: On Jul 23, 2009, at 5:23 PM, Eric Seidel wrote: It seems all lookups of

[webkit-dev] waf build patches

2009-07-23 Thread Kevin Ollivier
Hi all, Well, I've finally submitted the patches for building wxWebKit using waf. They're available from here: https://bugs.webkit.org/show_bug.cgi?id=27619 I've tried to keep the patches how you guys like them - under 5KB each. ;-) There's only 6, with one being about 20KB but that can

Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Holger Freyther
On Thursday 23 July 2009 18:31:32 Luke Kenneth Casson Leighton wrote: i trust that this comprehensive answer illustrates to you that it was, although extremely quick, not without sound reasons that i chose to raise this matter on the lists, and i trust that you will in future do myself and

Re: [webkit-dev] incompatibility between DOM spec (IDL) and c-based (gobject) language bindings

2009-07-23 Thread Eric Seidel
Zecke, you are great you made my day with your note k, thx, bai. -eric On Thu, Jul 23, 2009 at 7:27 PM, Holger Freytherze...@selfish.org wrote: On Thursday 23 July 2009 18:31:32 Luke Kenneth Casson Leighton wrote: i trust that this comprehensive answer illustrates to you that it was,