On Feb 25, 2010, at 4:11 PM, Jian Li wrote:
> I like option 3 since it seems to be the one to involve far less changes.
> However, people who read the code really need to get a good understanding of
> differences between FormData and DOMFormData.
Lets start with this, and later if we think of s
I like option 3 since it seems to be the one to involve far less changes.
However, people who read the code really need to get a good understanding of
differences between FormData and DOMFormData.
On Thu, Feb 25, 2010 at 4:07 PM, Michael Nordman wrote:
> option 3: We could name any new classes b
option 3: We could name any new classes backing the new scriptable object as
DOMFormData (similar in sprirt to DOMWindow), and leave the existing
FormData classes as they are.
On Thu, Feb 25, 2010 at 3:31 PM, Jian Li wrote:
> Hi,
>
> I am looking into the work to support FormData interface as de
Hi,
I am looking into the work to support FormData interface as defined in
XMLHttpRequest Level 2 (
http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata). To support the
new FormData interface, we need to add the FormData object that collides
with the name that has already existed. Currently w
On Thu, Feb 25, 2010 at 3:03 PM, Oliver Hunt wrote:
> But any regressions would have been blamed on eric.
>
> webkit-patch land does the correct thing, but i disable the testing prior to
> commit because a 25 minute delay prior to committing is more or less
> guaranteed to cause it to fail to comm
But any regressions would have been blamed on eric.
webkit-patch land does the correct thing, but i disable the testing
prior to commit because a 25 minute delay prior to committing is more
or less guaranteed to cause it to fail to commit due to someone else
landing.
--Oliver
On Feb 25,
OK, thanks, that appears to have fixed it.
How about that commit queue? Would have caught the crashes before they
were checked in.
-Ken
On Thu, Feb 25, 2010 at 2:53 PM, Oliver Hunt wrote:
> Update to r55258 or later :D
>
> --Oliver
>
> On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote:
>
>> A
Update to r55258 or later :D
--Oliver
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote:
A change committed some time since yesterday evening has introduced
many crashes in JSC's GC during testing. A representative stack trace
is attached.
If you have made changes in this area recently, can
My bad, fixing now.
--Oliver
On Feb 25, 2010, at 2:47 PM, Maciej Stachowiak wrote:
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote:
A change committed some time since yesterday evening has introduced
many crashes in JSC's GC during testing. A representative stack trace
is attached.
If y
On Feb 25, 2010, at 2:46 PM, Kenneth Russell wrote:
A change committed some time since yesterday evening has introduced
many crashes in JSC's GC during testing. A representative stack trace
is attached.
If you have made changes in this area recently, can you please look
into this?
Thanks,
A change committed some time since yesterday evening has introduced
many crashes in JSC's GC during testing. A representative stack trace
is attached.
If you have made changes in this area recently, can you please look into this?
Thanks,
-Ken
Thread 0 Crashed: Dispatch queue: com.apple.main-thr
Also, I think that the argument that the (common) "commit-queue breaks
annotate" is not really accurate.
The commit-queue does change what user name it puts next to the line
in the default annotate view (in the command line)[1]. But the
username in that view is almost entirely useless (at least f
I agree, I think a commit-...@webkit.org user would be slightly better
than e...@webkit.org committing everyone's patches.
I disagree that committers should feel any need to land their own
patches. Humans suck at repetitive tasks. Humans break the build all
the time and then go AFK. The bot has
On Thu, Feb 25, 2010 at 9:48 AM, Jochen Eisinger wrote:
> Here's a bit of context. When a database is opened, right now you
> don't have any context from where it is opened. The problem is that
> the actual calls that open a database go through the sqlite3 vfs
> layer, so there's no easy way to pa
I already started the process of doing a revert and submitting it with a
better change log.
J
On Thu, Feb 25, 2010 at 7:11 PM, Alexey Proskuryakov wrote:
>
> On 25.02.2010, at 10:00, David Levin wrote:
>
> All the information being provided now explains the why. Unfortunately,
> this thread doe
On 25.02.2010, at 10:00, David Levin wrote:
All the information being provided now explains the why.
Unfortunately, this thread doesn't fix the problem that the
ChangeLog as checked in only explains "what" as opposed to
"why" (even fixing the ChangeLog will leave it disconnected from the
Done.
On Thu, Feb 25, 2010 at 7:18 PM, Jeremy Orlow wrote:
> I already started the process of doing a revert and submitting it with a
> better change log.
>
> J
>
> On Thu, Feb 25, 2010 at 7:11 PM, Alexey Proskuryakov wrote:
>
>>
>> On 25.02.2010, at 10:00, David Levin wrote:
>>
>> All the infor
There are a number of individual patches for MathML that need review:
https://bugs.webkit.org/show_bug.cgi?id=34277
- munder, mover, and munderover support
https://bugs.webkit.org/show_bug.cgi?id=34278
- msubsup, msub, and msup support
https://bugs.webkit.org/show_bug.cgi?id=34347
Often when I have to understand the history of code, I look back at
changelog's/commit messages to understand why a change was done.
All the information being provided now explains the why. Unfortunately, this
thread doesn't fix the problem that the ChangeLog as checked in only
explains "*what*" a
Here's a bit of context. When a database is opened, right now you
don't have any context from where it is opened. The problem is that
the actual calls that open a database go through the sqlite3 vfs
layer, so there's no easy way to pass this function down to to
platform/sql/chromium/SQLFileSystemCh
I agree with Jeremy and David. If you are a committer you should try to land
patches on your own when you can. I mainly think this because it lets svn/git
blame work as intended instead of always blaming who ran the bot. Maybe we
should have a commit-...@webkit.org user?
On Feb 25, 2010, at 5:4
On Thu, Feb 25, 2010 at 5:26 AM, Jeremy Orlow wrote:
> It also frees up the queue for those who need it.
A common misconception, but looking at the logs the commit-queue looks
to be no where near capacity. I believe it could commit every change
done to WebKit in a day and still not be near capac
The only time I've ever had an issue with committing is when I forgot to add
the file myself. The bot uses the same scripts that committers do. I think
it'd be worth your time to become comfortable with them. If nothing else,
so you can land fixes for when you break the build. It also frees up
The only time I've ever had an issue with committing is when I forgot to add
the file myself. The bot uses the same scripts that committers do. I think
it'd be worth your time to become comfortable with them. If nothing else,
so you can land fixes for when you break the build. It also frees up
hi
Is there a way to cancel image loading in WebKit browsers?
To change the src attribute does not stop loading -> slow map
The first step is to file a bug at bugs.webkit.org, with a simple testcase.
Done:
https://bugs.webkit.org/show_bug.cgi?id=35377
Is there no workaround for this
25 matches
Mail list logo
