Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Benjamin Meyer
On Apr 12, 2010, at 6:28 PM, Alexey Proskuryakov wrote: > One thing that wasn't mentioned at the meeting is that git doesn't seem to > have the same monotonously increasing revision numbers as svn does. It will > be a problem to replace REGRESSION(r12345) with > REGRESSION(96c3b0300ccf16b64efc

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Maciej Stachowiak
On Apr 12, 2010, at 9:44 PM, Maciej Stachowiak wrote: On Apr 12, 2010, at 8:15 PM, Timothy Hatcher wrote: Only the first 5-7 characters are needed to identify a single commit (enough of the hash prefix to be unique). So REGRESSION (96c3b0) vs REGRESSION(r12345). How long will 7 character

[webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
Have you ever wanted WebKit's URL parsing to be awesome? Do crazy characters in URLs keep you up at night? Do you love writing tests? If you answered yes to any of these questions, you might want to join the URL hackathon. In this hackathon, we're adding a ton of test of our URL parsing code by

[webkit-dev] Request: Include Import Library with win32 Nightly Builds

2010-04-13 Thread Brian Barnes
I thought I'd bring this up again in hopes my life (and I assume others who are in the same boat as me) a bit easier. My application use JavaScriptCore and is both in OS X and win32. When I want to upgrade JSC to get bug fixes, I can download the nightly OS X build and then just drop in the f

Re: [webkit-dev] help with webkit installation for kde-4.4.2 (amd64 linux)

2010-04-13 Thread Julien Chaffraix
Hi, > I am having a go at compiling kde4.4.2.  I am now  trying to build webkit for > KDE4.4.2 (pure-64bit -non-multilib -amd64 linux  setup).  (it is needed by > google-gadgets)  I downloaded qtwebkit from > http://gitorious.org/+qtwebkit-developers/webkit/qtwebkit > > and it compiles OK with the

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Alexey Proskuryakov
13.04.2010, в 00:10, Benjamin Meyer написал(а): >> One thing that wasn't mentioned at the meeting is that git doesn't seem to >> have the same monotonously increasing revision numbers as svn does. It will >> be a problem to replace REGRESSION(r12345) with >> REGRESSION(96c3b0300ccf16b64efc260c

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread David Levin
On Tue, Apr 13, 2010 at 8:14 AM, Alexey Proskuryakov wrote: > > 13.04.2010, в 00:10, Benjamin Meyer написал(а): > > >> One thing that wasn't mentioned at the meeting is that git doesn't seem > to have the same monotonously increasing revision numbers as svn does. It > will be a problem to replace

[webkit-dev] OpenVG - AmanithVG SRE + EGL evaluation Linux X11 builds (x86 and x86_64) pre release.

2010-04-13 Thread Info
Hi guys, I'm Matteo Muratori from Mazatech S.r.l., the company behind AmanithVG. As I've seen that an OpenVG backend for Webkit is in development, I'd like to share with you all developers the binary evaluation builds (AmanithVG source code is not public), that could be used also to try/develo

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Geoffrey Garen
> If Mark would add tags for the nightlies one could type "git tag -- > contains=COMMIT" to figure out which tags include the version. This still doesn't scale to archived builds of individual revisions. On a related note, is there a git syntax for "one revision prior to X?" -- I use that in SVN

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Eric Seidel
COMMIT~1 or COMMIT^ both are one commit prior to COMMIT. COMMIT~2 or COMMIT^^ are both 2 commits prior. On Tue, Apr 13, 2010 at 8:35 AM, Geoffrey Garen wrote: >> If Mark would add tags for the nightlies one could type "git tag -- >> contains=COMMIT" to figure out which tags include the version. >

[webkit-dev] Buildbot Updates

2010-04-13 Thread William Siegrist
Our buildbot master has been updated to the latest python and buildbot versions. We also have new Qt bots per the previous webkit-dev thread as well as a bot using new-run-webkit-tests (mac-leopard). Let me know if you see any anomalies with the new setup. Thanks -Bill ___

Re: [webkit-dev] Buildbot Updates

2010-04-13 Thread David Kilzer
On Tue, April 13, 2010 at 9:02:39 AM, William Siegrist wrote: > Our buildbot master has been updated to the latest python and buildbot > versions. > We also have new Qt bots per the previous webkit-dev thread as well as a bot > using new-run-webkit-tests (mac-leopard). Let me know if you see a

[webkit-dev] Editing Meeting

2010-04-13 Thread Eric Seidel
- The code has old parts change that were made with a purpose in mind at Apple (like adding a span with an known "class" attribute). There is a lot of legacy code that could be removed (and should have). - There is an issue where application does not behave as expected: depending on the posit

Re: [webkit-dev] Overloads support in V8 & JSC

2010-04-13 Thread Sam Weinig
Excellent! On Mon, Apr 12, 2010 at 11:13 AM, Yaar Schnitman wrote: > Hi, > > I'm adding method overloading support to the V8 and JSC bindings > generators. A significant portion of custom bindings are needed since these > generators don't support re-declaration of functions with different sets o

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-04-13 Thread Ojan Vafai
On Mon, Mar 1, 2010 at 7:53 PM, Maciej Stachowiak wrote: > On Mar 1, 2010, at 6:46 PM, Ojan Vafai wrote: > > On Mon, Mar 1, 2010 at 6:40 PM, Maciej Stachowiak wrote: > >> On the one hand, it's good to shift the default. On the other hand, many >> render tree dumping tests do not currently need t

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-04-13 Thread David Hyatt
There are also a fair number of directories that test rendering and layout, although they are usually obvious by their names... many of the subdirectories in "fast" cannot be converted to pure text tests (clipping, margin collapsing, backgrounds, etc.). dave On Apr 13, 2010, at 1:54 PM, Ojan V

Re: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz)

2010-04-13 Thread Gustavo Sverzut Barbieri
On Fri, Apr 9, 2010 at 2:09 PM, Stephan Assmus wrote: >> - Ursprüngliche Nachricht - >> Von: Adam Barth >> Gesendet: 09.04.10 23:26 Uhr >> An: webkit-...@lists.webkit.org >> Betreff: [webkit-dev] Archiving the Haiku port? (was WebKit2 and all that jazz) > >> >> Is the Haiku port actively m

Re: [webkit-dev] Buildbot Updates

2010-04-13 Thread Eric Seidel
It seems we should add any of these builders which are green to the core builders list immediately so they don't regress. http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py#L310 Do we have any information as to how stable any of these new builders are? Or how

[webkit-dev] Gtk builder needs lovin'

2010-04-13 Thread Eric Seidel
It looks completely hosed. It's failing to many tests for it to even keep track. :( -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Qt Windows builder is down

2010-04-13 Thread Eric Seidel
Slave Lost. ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Request: Include Import Library with win32 Nightly Builds

2010-04-13 Thread Brent Fulgham
Hi Brian, On Tue, Apr 13, 2010 at 6:55 AM, Brian Barnes wrote: > Not so with the win32 build.  It has the DLLs, but not the import libraries > (.lib) which are built when the DLLs are built and used to attach the DLL to > my code.  Can you folks change the script that creates these to include > t

Re: [webkit-dev] Request: Include Import Library with win32 Nightly Builds

2010-04-13 Thread Brian Barnes
Hi Brian, On Tue, Apr 13, 2010 at 6:55 AM, Brian Barnes wrote: Not so with the win32 build. It has the DLLs, but not the import libraries (.lib) which are built when the DLLs are built and used to attach the DLL to my code. Can you folks change the script that creates these to include th

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-04-13 Thread Simon Fraser
On Apr 13, 2010, at 11:54 AM, Ojan Vafai wrote: > On Mon, Mar 1, 2010 at 7:53 PM, Maciej Stachowiak wrote: > On Mar 1, 2010, at 6:46 PM, Ojan Vafai wrote: >> On Mon, Mar 1, 2010 at 6:40 PM, Maciej Stachowiak wrote: >> On the one hand, it's good to shift the default. On the other hand, many >>

Re: [webkit-dev] Editing Meeting

2010-04-13 Thread Ojan Vafai
On Tue, Apr 13, 2010 at 11:13 AM, Eric Seidel wrote: > - There is an issue where application does not behave as expected: > depending on the position of the caret into the tag, the > behaviour is not the same. > The more general point here is that web apps need control over where editing co

[webkit-dev] Media elements meeting notes

2010-04-13 Thread Eric Uhrhane
Rough, but prompt, here they are. Eric What do people want to get out of the session? Darin Adler: Use webkit loader to get data into media elements--currently all the media elements just get a URL and work around it themselves. Sam Wienig: What new things can we do with media element? In

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-04-13 Thread Dirk Pranke
On Tue, Apr 13, 2010 at 11:54 AM, Ojan Vafai wrote: > On Mon, Mar 1, 2010 at 7:53 PM, Maciej Stachowiak wrote: >> >> On Mar 1, 2010, at 6:46 PM, Ojan Vafai wrote: >> >> On Mon, Mar 1, 2010 at 6:40 PM, Maciej Stachowiak wrote: >>> >>> On the one hand, it's good to shift the default. On the other

Re: [webkit-dev] Editing Meeting

2010-04-13 Thread Ryosuke Niwa
On Tue, Apr 13, 2010 at 2:35 PM, Ojan Vafai wrote: > Up to now, we've been assuming that the solution is to add the same > support as Firefox. The suggestion at this meeting was to instead approach > this from a policy perspective since we don't want web apps to have to > capture key/mouse even

[webkit-dev] commit-queue went nuts

2010-04-13 Thread Eric Seidel
http://trac.webkit.org/changeset/57532 http://trac.webkit.org/changeset/57534 My apologies. Investigating now. -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Recent SVG clipping change caused lots of leaks on the bot

2010-04-13 Thread Maciej Stachowiak
https://bugs.webkit.org/show_bug.cgi?id=37527 http://trac.webkit.org/changeset/57511 Regards, Maciej ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Recent SVG clipping change caused lots of leaks on the bot

2010-04-13 Thread Oliver Hunt
looks like ~RenderSVGResourceClipper should be doing deleteAllValues(m_clipper); --Oliver On Apr 13, 2010, at 3:48 PM, Maciej Stachowiak wrote: > > > https://bugs.webkit.org/show_bug.cgi?id=37527 > > http://trac.webkit.org/changeset/57511 > > Regards, > Maciej > > __

Re: [webkit-dev] Recent SVG clipping change caused lots of leaks on the bot

2010-04-13 Thread Maciej Stachowiak
On Apr 13, 2010, at 3:58 PM, Oliver Hunt wrote: looks like ~RenderSVGResourceClipper should be doing deleteAllValues (m_clipper); I'll try that locally once I have a debug build, if no one beats me to it. - Maciej --Oliver On Apr 13, 2010, at 3:48 PM, Maciej Stachowiak wrote: htt

Re: [webkit-dev] commit-queue went nuts

2010-04-13 Thread Eric Seidel
Turns out this was a regression from: http://trac.webkit.org/changeset/57531 Will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=37528 This also breaks "webkit-patch land" until bug 37528 lands. -eric On Tue, Apr 13, 2010 at 3:06 PM, Eric Seidel wrote: > http://trac.webkit.org/changese

Re: [webkit-dev] commit-queue went nuts

2010-04-13 Thread Eric Seidel
Fixed in http://trac.webkit.org/changeset/57550. If your webkit-patch checkout is between r57531 and r57550 webkit-patch land will commit with an incorrect commit message. Please update before using "webkit-patch land". -eric On Tue, Apr 13, 2010 at 4:48 PM, Eric Seidel wrote: > Turns out this

Re: [webkit-dev] Media elements meeting notes

2010-04-13 Thread pnormand
On Tue, 2010-04-13 at 14:52 -0700, Eric Uhrhane wrote: > New topic: Loader. > > Things that would be improved by unifying loading between media elements and > the > rest of webkit: > Unified resource security model. > Make application cache work for media. > Make WebCore cache work for med

Re: [webkit-dev] Editing Meeting

2010-04-13 Thread Roland Steiner
I have to say I agree with Ryosuke that this requires more consideration (see inline comments). On Wed, Apr 14, 2010 at 6:35 AM, Ojan Vafai wrote: > On Tue, Apr 13, 2010 at 11:13 AM, Eric Seidel wrote: > >> - There is an issue where application does not behave as expected: >> depending on

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Chris Jerdonek
Regarding the URL parsing code, could someone that attended the session list what steps were proposed or tentatively agreed to (of which the below is the first)? Thanks a lot, --Chris On Tue, Apr 13, 2010 at 1:46 AM, Adam Barth wrote: > Have you ever wanted WebKit's URL parsing to be awesome?

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Darin Fisher
Looking at ipv4.js, I don't see any of the comments from url_canon_unittest.cc. Is there a reason why you chose to drop them? It seems like they could be helpful to someone reading ipv4.js in the future. -Darin On Tue, Apr 13, 2010 at 1:46 AM, Adam Barth wrote: > Have you ever wanted WebKit

Re: [webkit-dev] Git meeting notes

2010-04-13 Thread Philippe Normand
On Mon, 2010-04-12 at 13:59 -0700, Benjamin wrote: > Quick and dirty notes from the Git discussion. > > - April 12th 2010 / Garage 2 / 10:15 - 11:15 > > Who was there: Rim, Nokia, Qualcomm, Sony, Apple, Google, Gtk guys > (sorry I forgot which company you were from) > Igalia :-) Philippe si

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
My thought process at the time was "just the facts," but I think the comments are valuable and we should probably put them back. Adam On Tue, Apr 13, 2010 at 10:22 PM, Darin Fisher wrote: > Looking at ipv4.js, I don't see any of the comments > from url_canon_unittest.cc.  Is there a reason why

[webkit-dev] Qt is now a "core builder"

2010-04-13 Thread Eric Seidel
http://trac.webkit.org/changeset/57561 Sheriff Bot will nag you when you break Qt. Commit Queue will block while any Qt builder is broken. Qt was green all day. The Qt devs @ WKCon seemed very interested in keeping their bots green. The goal of the "core builder" list[1] is to be descriptive, n

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
I think Maciej took notes, but my recollection is as follows: 1) Convert as many of the unit tests to LayoutTests as possible. 2) Land GURL in svn.webkit.org as is. 3) Convert GURL to WebKit style. 4) Make an ifdef that lets ports switch between KURL and GURL. Once we get to this point, it will b

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Darin Fisher
#4 is already basically done. See USE(GOOGLEURL). -Darin On Tue, Apr 13, 2010 at 11:17 PM, Adam Barth wrote: > I think Maciej took notes, but my recollection is as follows: > > 1) Convert as many of the unit tests to LayoutTests as possible. > 2) Land GURL in svn.webkit.org as is. > 3) Conve

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
Ah, sorry, I meant to the point where the library was integrated with the various build systems, etc. Maybe that's already possible today. I haven't investigated it in detail. It probably also makes sense to talk about correctness between steps (1) and (2), once we have the tests and their result

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Darin Fisher
I see. Sounds good to me. -Darin On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth wrote: > Ah, sorry, I meant to the point where the library was integrated with > the various build systems, etc. Maybe that's already possible today. > I haven't investigated it in detail. It probably also makes sen

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread David Levin
On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth wrote: > Ah, sorry, I meant to the point where the library was integrated with > the various build systems, etc. Maybe that's already possible today. > I haven't investigated it in detail. It probably also makes sense to > talk about correctness betw

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Darin Fisher
On Tue, Apr 13, 2010 at 11:39 PM, David Levin wrote: > > > On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth wrote: > >> Ah, sorry, I meant to the point where the library was integrated with >> the various build systems, etc. Maybe that's already possible today. >> I haven't investigated it in detai

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Eric Seidel
Dammit. I'm not smart enough to use mailing lists. My suggestion was WTFURL. ;) On Tue, Apr 13, 2010 at 11:51 PM, Darin Fisher wrote: > > > On Tue, Apr 13, 2010 at 11:39 PM, David Levin wrote: >> >> >> On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth wrote: >>> >>> Ah, sorry, I meant to the point

Re: [webkit-dev] Join the URL hackathon (already in progress)!

2010-04-13 Thread Adam Barth
I'd like to avoid bikeshedding about the name, but URLCore sounds like my shade of blue. :) Adam On Tue, Apr 13, 2010 at 11:51 PM, Darin Fisher wrote: > > > On Tue, Apr 13, 2010 at 11:39 PM, David Levin wrote: >> >> >> On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth wrote: >>> >>> Ah, sorry, I