Re: [webkit-dev] Style question: static, protected, or public members

2010-05-25 Thread Jeremy Orlow
On Tue, May 25, 2010 at 12:19 AM, Darin Adler wrote: > On May 20, 2010, at 8:54 PM, TAMURA, Kent wrote: > > > What's the naming rule for non-const static members? > > > > Some classes give "s_" prefixes: > > WebCore/page/DOMTimer.h:static double s_minTimerInterval; > > WebCore/page/Geoloc

Re: [webkit-dev] Style question: static, protected, or public members

2010-05-25 Thread TAMURA, Kent
2010/5/25 Darin Adler On May 20, 2010, at 8:54 PM, TAMURA, Kent wrote: > What's the naming rule for non-const static members? > > Some classes give "s_" prefixes: > WebCore/page/DOMTimer.h:        static double s_minTimerInterval; > WebCore/page/GeolocationPositionCache.h:    static int s_in

[webkit-dev] Possible issue with TCMalloc_PageHeap on Solaris 10 (amd64) ?

2010-05-25 Thread Xavier Roche
Hi folks!, [ Please redirect me if the question is off-topic here ] I am trying to build webkit (qt flavour, current 4.6.1 stable release) on Solaris, and I am facing weird SEGV issues when trying to use objects such as QWebPage. The underlying issue seems to be related to the TCMalloc* layer

[webkit-dev] free functions

2010-05-25 Thread Chris Jerdonek
Hi, I have a question regarding WebKit's stance on free functions. I sometimes come across public member functions whose implementations do not depend on private data. There is a school of thought that such functions are better non-member because it reduces the number of functions coupled to priv

Re: [webkit-dev] Possible issue with TCMalloc_PageHeap on Solaris 10 (amd64) ?

2010-05-25 Thread Zoltan Horvath
Hi, On Tuesday 25 May 2010, at 16:38, Xavier Roche wrote: > Hi folks!, > > [ Please redirect me if the question is off-topic here ] webkit-help is the appropriate channel for this. > I am trying to build webkit (qt flavour, current 4.6.1 stable release) on > Solaris, and I am facing weird SEG

Re: [webkit-dev] Style question: static, protected, or public members

2010-05-25 Thread Darin Adler
On May 25, 2010, at 3:05 AM, TAMURA, Kent wrote: >> Generally speaking I suggest we do not use the "m_" prefix for the members >> of structs. And I suggest that classes with public data members be structs >> instead of classes. Classes that have public data members only for >> historical reason

Re: [webkit-dev] free functions

2010-05-25 Thread Darin Adler
On May 25, 2010, at 7:54 AM, Chris Jerdonek wrote: > I sometimes come across public member functions whose implementations do not > depend on private data. > > There is a school of thought that such functions are better non-member > because it reduces the number of functions coupled to private

Re: [webkit-dev] Possible issue with TCMalloc_PageHeap on Solaris 10 (amd64) ?

2010-05-25 Thread Xavier Roche
Hi, On Tue, 25 May 2010, Zoltan Horvath wrote: [ Please redirect me if the question is off-topic here ] webkit-help is the appropriate channel for this. Okay - I'll send a possible patch there in this case, to build on Solaris 10. Any hint or suggestion would be appreciated :) You should

Re: [webkit-dev] Bytecode Sequence for function.apply()

2010-05-25 Thread Nyx
How would I go about building jsc in debug mode? Is it possible to build a standalone jsc shell? I'm using Qt Webkit, with the bulld-webkit and run-webkit scripts. Thank you for your help, - Maxime Oliver Hunt-2 wrote: > > If you have a debug build of jsc, you can run 'jsc -d' and that will

Re: [webkit-dev] Bytecode Sequence for function.apply()

2010-05-25 Thread Ariya Hidayat
> How would I go about building jsc in debug mode? Is it possible to build a > standalone jsc shell? See https://lists.webkit.org/pipermail/webkit-qt/2010-January/89.html for details. -- Ariya Hidayat http://www.linkedin.com/in/ariyahidayat ___

Re: [webkit-dev] Bytecode Sequence for function.apply()

2010-05-25 Thread Nyx
Well, I ran build-webkit with the "--debug" option, and when I try to run WebKit/WebKitBuild/Debug/JavaScriptCore/jsc , I get a failed assertion: ASSERTION FAILED: !isHostFunctionNonInline() (../../../JavaScriptCore/runtime/Executable.h:349 JSC::FunctionExecutable* JSC::JSFunction::jsExecutable()