Re: [webkit-dev] About fixing "old" layout bugs

2010-06-01 Thread Xianzhu Wang
Thanks Dan for reply. 2010/6/2 Dan Bernstein > Hi Xianzhu, > > On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote: > > Hi, > > I'm new to webkit development, and I'd like to hear opinions about the > problems I met. > > Now I'm trying to fix some "old" layout bugs, for example: > * white space pre

[webkit-dev] How to convert character offset into VisiblePosition?

2010-06-01 Thread Xiaomei Ji
Given a DOM Node and an InlineBox, is there a way to convert the character offset within this InlineBox to a VisiblePosition? considering bidi/RTL. Using node in the following example as an example: abc ששש def שנב abc סטז uvw זזז xyz Assume the node is node A, using "(node, offset)a" to repres

Re: [webkit-dev] About fixing "old" layout bugs

2010-06-01 Thread Dan Bernstein
Hi Xianzhu, On Jun 1, 2010, at 9:37 PM, Xianzhu Wang wrote: > Hi, > > I'm new to webkit development, and I'd like to hear opinions about the > problems I met. > > Now I'm trying to fix some "old" layout bugs, for example: > * white space preceding (https://bugs.webkit.org/show_bug.cgi?id=37

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-01 Thread Eric Seidel
Let me summarize to see if I understand what should be updated in the style guide/check-webkit-style: Class static member variables should have an s_ prefix. Protected and public member variables should be disallowed. Private member variables should have an m_ prefix. Struct member variables shoul

[webkit-dev] About fixing "old" layout bugs

2010-06-01 Thread Xianzhu Wang
Hi, I'm new to webkit development, and I'd like to hear opinions about the problems I met. Now I'm trying to fix some "old" layout bugs, for example: * white space preceding ( https://bugs.webkit.org/show_bug.cgi?id=37261) * relative font-size (https://bugs.webkit.org/show_bug.cgi?id=18413)

[webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-01 Thread Jian Li
Hi, I am working on Blob.url support as defined in the latest version of File API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a URL that can be used to refer to the blob object in a resource request, like blobdata:f81d4fae-7dec-11d0-a765-00a0c91e6bf6. The blob object can rep

Re: [webkit-dev] Table hit testing

2010-06-01 Thread Fady Samuel
Hi David, Just so I'm certain, there's no way for more than two cells to overlap in a single grid slot, is there? Thanks, Fady Samuel On Thu, May 20, 2010 at 4:43 PM, David Hyatt wrote: > On May 20, 2010, at 3:38 PM, Fady Samuel wrote: > > > So what are the rules for stacking here? do the cel

Re: [webkit-dev] Directory upload experimental feature

2010-06-01 Thread John Gregg
My proposal for that is that all the files would be listed in the form submission the same way as if it were a , but in the Content-Disposition header, the filename component would contain the path information. One alternative idea would be add a "path" component to the Content-Disposition header

Re: [webkit-dev] DRAG_SUPPORT Wrappers missing in WebCore/page/gtk/EventHandlerGtk.cpp ????

2010-06-01 Thread Eric Seidel
"How do I compile" questions are best sent to webkit-help. In this case, it sounds like you've simply found a compile error with a certain flag disabled. Please file a bug at http://bugs.webkit.org and post any patches there. -eric On Tue, Jun 1, 2010 at 8:31 AM, Deepak Mundra wrote: > Dear Al

Re: [webkit-dev] Webkit handling of SVG with rgba() color

2010-06-01 Thread David Hyatt
I think we should support rgba/hsla colors in SVG. dave On Jun 1, 2010, at 12:23 PM, Dirk Schulze wrote: > The SVG 1.1 specification has a reference to CSS2. So from the > specifications point of view, rgba() shouldn't be supported. > Nevertheless SVG 1.1se won't have a strict reference to CSS2.

Re: [webkit-dev] Webkit handling of SVG with rgba() color

2010-06-01 Thread Dirk Schulze
The SVG 1.1 specification has a reference to CSS2. So from the specifications point of view, rgba() shouldn't be supported. Nevertheless SVG 1.1se won't have a strict reference to CSS2. Also other browsers support rgba on SVG already. I'm fine with a rgba implementation and Eric wrote already what

[webkit-dev] DRAG_SUPPORT Wrappers missing in WebCore/page/gtk/EventHandlerGtk.cpp ????

2010-06-01 Thread Deepak Mundra
Dear All, I was trying to compile webkit without DRAG_SUPPORT. So i set flag ENABLE_DRAG_SUPPORT to 0 in JavaScriptCore/wtf/Platform.h. But while compiling i got some errors and found that #if ENABLE(DRAG_SUPPORT) wrappers are missing in file WebCore/page/gtk/EventHandlerGtk.cpp for PassRefPt

Re: [webkit-dev] Webkit handling of SVG with rgba() color

2010-06-01 Thread Simon Fraser
You should raise this question on the public-fx mailing list: Simon On Jun 1, 2010, at 6:56 AM, Jonathan Kliegman wrote: > I was looking at Bug 16183 (https://bugs.webkit.org/show_bug.cgi?id=16183) - > SVG doesn't support rgba() colors. I was

[webkit-dev] Webkit handling of SVG with rgba() color

2010-06-01 Thread Jonathan Kliegman
I was looking at Bug 16183 (https://bugs.webkit.org/show_bug.cgi?id=16183) - SVG doesn't support rgba() colors. I was planning on fixing this but after reading the SVG spec at http://www.w3.org/TR/SVG11/ which states that SVG supports CSS2 color specifications I'm unsure if this should be fixed or

Re: [webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

2010-06-01 Thread Jeremy Orlow
Oh, and until you can find someone to help you with the bot, the best course of action is probably to roll back your change. Sheriffbot on #webkit can help. On Tue, Jun 1, 2010 at 1:10 PM, Jeremy Orlow wrote: > On Tue, Jun 1, 2010 at 1:08 PM, Jeremy Orlow wrote: > >> This mail is full of etiqu

Re: [webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

2010-06-01 Thread Jeremy Orlow
On Tue, Jun 1, 2010 at 1:08 PM, Jeremy Orlow wrote: > This mail is full of etiquette fail. First of all, you've now cross posted > between webkit-dev and chromium-dev (using the @googlegroups address which > was deprecated) so the majority of people who might respond can only do so > to one list

Re: [webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

2010-06-01 Thread Anton Muhin
Looping in more people On Tue, Jun 1, 2010 at 3:40 PM, Anton Muhin wrote: > Dear webkitters, > > Commit queue just committed http://build.webkit.org/changes/11277 for > me which includes Chromium DEPS roll (in WebKit). > > However things didn't go smooth: > http://build.webkit.org/builders/Chromi

[webkit-dev] Troubles with Chromium DEPS roll (in WebKit)

2010-06-01 Thread Anton Muhin
Dear webkitters, Commit queue just committed http://build.webkit.org/changes/11277 for me which includes Chromium DEPS roll (in WebKit). However things didn't go smooth: http://build.webkit.org/builders/Chromium%20Win%20Release/builds/7199/steps/gclient/logs/stdio Most probably solution is to nu