Re: [webkit-dev] How to convert character offset into VisiblePosition?

2010-06-02 Thread Xiaomei Ji
Hi Dan, Thanks for your quick feedback. Please see my comments inline. On Wed, Jun 2, 2010 at 9:30 AM, Dan Bernstein wrote: > > On Jun 1, 2010, at 10:48 PM, Xiaomei Ji wrote: > > > Given a DOM Node and an InlineBox, is there a way to convert the character > offset within this InlineBox to a Vi

Re: [webkit-dev] About fixing "old" layout bugs

2010-06-02 Thread Xianzhu Wang
Hi, I'm still wondering what the best practice is to deal with many updated layout tests in a patch. It seems I must run the layout tests on all effected platforms by myself to ensure a green build after committing the patch, right? This is really difficult to me. Is there a easier way? Thanks, X

Re: [webkit-dev] Making changes to our copy of the W3C CSS1 test suite

2010-06-02 Thread Darin Adler
On Jun 2, 2010, at 11:29 AM, Eric Seidel wrote: > What's the process for making changes to those files? Here’s how I think we should do it: 1) There’s one directory with a pristine copy of the W3C test suite, with no WebKit changes. 2) If there are some tests that need to be fixed, fixe

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-02 Thread Jian Li
This will probably work for most of the platforms, except the one that uses multi-process architecture. How do we handle the case that a page is trying to access a blob URL that is created in another process (assume the accessing page is in the same security domain)? I think for the platform, like

Re: [webkit-dev] IDL attribute vs Content attribute?

2010-06-02 Thread Prasad Tammana
Thanks Kent. And thanks for the offline chat too! On Wed, Jun 2, 2010 at 5:25 PM, TAMURA, Kent wrote: > > http://www.whatwg.org/specs/web-apps/current-work/multipage/infrastructure.html#terminology > > IDL attributes mean properties of JavaScript objects defined by IDLs. > Content attributes me

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-02 Thread Darin Adler
On Jun 1, 2010, at 5:14 PM, Jian Li wrote: > I am working on Blob.url support as defined in the latest version of File API > (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a URL that > can be used to refer to the blob object in a resource request, like > blobdata:f81d4fae-7d

Re: [webkit-dev] Proposal: Link http header support

2010-06-02 Thread Peter Kasting
On Wed, Jun 2, 2010 at 3:28 PM, Gavin Peters (蓋文彼德斯) wrote: > I'm starting hacking at adding support for the Link: http header. This is > described in RFC 2068, although not RFC 2616. As well, there's a current > internet draft describing it: > http://tools.ietf.org/id/draft-nottingham-http-link

Re: [webkit-dev] IDL attribute vs Content attribute?

2010-06-02 Thread TAMURA, Kent
http://www.whatwg.org/specs/web-apps/current-work/multipage/infrastructure.html#terminology IDL attributes mean properties of JavaScript objects defined by IDLs. Content attributes mean HTML/XML attributes. 2010/6/3 Prasad Tammana I'm looking at the HTML5 spec for the command element and it t

[webkit-dev] IDL attribute vs Content attribute?

2010-06-02 Thread Prasad Tammana
I'm looking at the HTML5 spec for the command element and it talks about IDL attributes vs Content attributes? What does each mean? Thanks, Prasad ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webki

[webkit-dev] Proposal: Link http header support

2010-06-02 Thread 蓋文彼德斯
Hi, I'm starting hacking at adding support for the Link: http header. This is described in RFC 2068, although not RFC 2616. As well, there's a current internet draft describing it: http://tools.ietf.org/id/draft-nottingham-http-link-header-10.html . This header is being discussed in the IETF HT

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-02 Thread Mikhail Naganov
Used memory count can be restricted to include only objects reachable from the caller execution context. In this case, an app could only see the amount of memory consumed by itself, not by the whole engine. Another option, as Sam proposed before, is to expose things like console.profiles and conso

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
He would want 1,1. dave On Jun 2, 2010, at 3:58 PM, Peter Kasting wrote: > On Wed, Jun 2, 2010 at 1:52 PM, Antonio Gomes (:tonikitoo) > wrote: > If a port do not want to > take advantage of the new support, the current functionality should > and would be kept, i.e. Rect(x,y,1,1,) would do the

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Peter Kasting
On Wed, Jun 2, 2010 at 1:52 PM, Antonio Gomes (:tonikitoo) < toniki...@gmail.com> wrote: > If a port do not want to > take advantage of the new support, the current functionality should > and would be kept, i.e. Rect(x,y,1,1,) would do the trick. Be careful to check whether you really want 1, 1

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
Hi David. Although I understand your concern, however I still do not think the change would complicate things that much, but basically extend the current support. For example, in bool InlineTextBox::nodeAtPoint(const HitTestRequest&, HitTestResult& result, int x, int y, int tx, int ty) { (...)

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
On Jun 2, 2010, at 3:22 PM, David Hyatt wrote: >> >> Before going this way, I would like to know of any known problem or >> show stoppers. > > I really don't think hit testing needs to be modified to get what you want. > You can do a scattershot sampling using multiple candidate points within

Re: [webkit-dev] Table hit testing

2010-06-02 Thread Fady Samuel
So I have completed all the following things locally: * First fix the grid to record all the cells at a given position. This fixes a repaint bug. * Then change the hit-testing to work just like painting. This makes hit testing more efficient and ensures hit testing and painting agree. * Then opt

Re: [webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread David Hyatt
On Jun 2, 2010, at 2:46 PM, Antonio Gomes (:tonikitoo) wrote: > Hi, > > As most of you have experienced, the precision of a mouse click on > Desktop applications, including Web browsers, is much higher than the > precision of a touch tap on a mobile device. It is not a new problem, > and many sol

[webkit-dev] Proposal: Rect based HitTest for a better touch experience

2010-06-02 Thread Antonio Gomes (:tonikitoo)
Hi, As most of you have experienced, the precision of a mouse click on Desktop applications, including Web browsers, is much higher than the precision of a touch tap on a mobile device. It is not a new problem, and many solutions have been proposed to improve that situation. One of the common solu

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-02 Thread Adam Barth
I haven't looked into the details, but, in general, side channel information is a rich area for unintentional disclosure. For example, timing information leaks a ton of information. Here's a recent paper that shows a bunch of stuff you can use from the sizes of things. In this case, they're look

Re: [webkit-dev] On adding 'console.memory' API (and about the whole 'console' object.)

2010-06-02 Thread Sam Weinig
Now that I have had a little time to think about it, I think my biggest concern with this type of API is the unintentional ability for an attacker to gain information from the engine consuming specifics amount of memory. Let's take the visited link history stealing attack as an example. Even thou

Re: [webkit-dev] Directory upload experimental feature

2010-06-02 Thread Sam Weinig
I think this is only true for Mac OS X style bundles, not all folders. On Wed, Jun 2, 2010 at 3:44 AM, David Kilzer wrote: > > Other alternatives? > > I believe Safari will zip a folder and send it as a single file for you if > you attach a folder to a file upload element instead of an individua

Re: [webkit-dev] XMLHttpRequest memoryleak

2010-06-02 Thread Patrick Roland Gansterer
On Wed, 02 Jun 2010 10:07:59 -0700, Alexey Proskuryakov wrote: > 02.06.2010, в 6:55, Patrick Roland Gansterer написал(а): > >> I think WebKit (with JSC) leaks memory for every XMLHttpRequest and >> I need >> to fix this problem. >> Can somebody give me a hint where I should start? > > > I don

Re: [webkit-dev] XMLHttpRequest memoryleak

2010-06-02 Thread Alexey Proskuryakov
02.06.2010, в 6:55, Patrick Roland Gansterer написал(а): I think WebKit (with JSC) leaks memory for every XMLHttpRequest and I need to fix this problem. Can somebody give me a hint where I should start? I don't think this has been fully investigated, but the current theory is that the me

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-02 Thread Darin Adler
On Jun 1, 2010, at 10:09 PM, Eric Seidel wrote: > Let me summarize to see if I understand what should be updated in the style > guide/check-webkit-style: > > Class static member variables should have an s_ prefix. > Protected and public member variables should be disallowed. > Private member var

Re: [webkit-dev] How to convert character offset into VisiblePosition?

2010-06-02 Thread Dan Bernstein
On Jun 1, 2010, at 10:48 PM, Xiaomei Ji wrote: > > Given a DOM Node and an InlineBox, is there a way to convert the character > offset within this InlineBox to a VisiblePosition? considering bidi/RTL. Not sure how being given a DOM node helps here… > > Using node in the following example as

Re: [webkit-dev] XMLHttpRequest memoryleak

2010-06-02 Thread Mike Marchywka
> Date: Wed, 2 Jun 2010 15:55:03 +0200 > From: par...@paroga.com > To: webkit-dev@lists.webkit.org > Subject: [webkit-dev] XMLHttpRequest memoryleak > > Hi, > > I think WebKit (with JSC) leaks memory for every XMLHttpRequest and I need > to fix thi

Re: [webkit-dev] Directory upload experimental feature

2010-06-02 Thread イアンフェッティ
Zip files cannot be streamed (there was a good discussion in [1], so you are unable to do any operations on the data until the entire .zip file has been received as the central directory comes at the end. Aside from that, what if you want to upload a large amount of already compressed files, e.g. a

[webkit-dev] XMLHttpRequest memoryleak

2010-06-02 Thread Patrick Roland Gansterer
Hi, I think WebKit (with JSC) leaks memory for every XMLHttpRequest and I need to fix this problem. Can somebody give me a hint where I should start? My testpage (http://paroga.com/webkit/memory.htm) only creates a request every second. Safari on windows "leaks" about 60KB/minute. QtBrowser on W

Re: [webkit-dev] Table hit testing

2010-06-02 Thread Fady Samuel
Ohh, I see, thanks Roland. Fady On Wed, Jun 2, 2010 at 3:25 AM, Roland Steiner wrote: > AFAICT you could have an arbitrary number up to the width or height of the > table, whichever is smaller, by combining row- and colspans - e.g. with 3 > ([v]aligns just to emphasize the overlapping): > > > R

Re: [webkit-dev] Gtk 32-bit Release Bot Wedged

2010-06-02 Thread Adrian Perez
On Thu, 20 May 2010 12:54:53 -0700 Eric Seidel wrote: > We have various other bot support tools checked in under: > http://trac.webkit.org/browser/trunk/WebKitTools/BuildSlaveSupport/ > and > http://trac.webkit.org/browser/trunk/WebKitTools/EWSTools > > You should feel encouraged to add more. D

Re: [webkit-dev] Directory upload experimental feature

2010-06-02 Thread David Kilzer
> Other alternatives? I believe Safari will zip a folder and send it as a single file for you if you attach a folder to a file upload element instead of an individual file. Dave From: John Gregg To: Sam Weinig Cc: webkit-dev@lists.webkit.org Sent: Tue, June

Re: [webkit-dev] Table hit testing

2010-06-02 Thread Roland Steiner
AFAICT you could have an arbitrary number up to the width or height of the table, whichever is smaller, by combining row- and colspans - e.g. with 3 ([v]aligns just to emphasize the overlapping): R1C1R1C2\\ R2C1// - Roland On Wed, Jun 2, 2010 at 8:58 AM, Fady Samuel wrote: > Hi