Re: [webkit-dev] Clobber builds in windows bots needed?

2010-11-01 Thread Brian Weinstein
We have: Need to touch WebKit.idl whenever Interfaces changes https://bugs.webkit.org/show_bug.cgi?id=32127 Brian On Oct 30, 2010, at 12:59 PM, Eric Seidel wrote: >> From teh right address. > > On Sat, Oct 30, 2010 at 12:59 PM, Eric Seidel wrote: >> The correct fix is to fix the dependency is

Re: [webkit-dev] scroll event firing for WebKit Gtk port

2010-11-01 Thread Aneesh Bhasin
On Mon, Nov 1, 2010 at 8:50 PM, Nilesh Patil wrote: > Hi > > I think you will have to look for scrollviewgtk.cpp and scrollview.cpp - a > platform side implementation for scrollable view in Gtk. > > Thanks & Regards > Nilesh > Thanks Nilesh - that helped. For reference sake, here are the function

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-11-01 Thread Eric Seidel
I guess I meant https://developer.apple.com/ios/download.action?path=/ios/ios_sdk_4.1__final/xcode_3.2.4_and_ios_sdk_4.1.dmg -eric On Mon, Nov 1, 2010 at 4:31 PM, Eric Seidel wrote: > https://daw.apple.com/cgi-bin/WebObjects/DSAuthWeb.woa/wa/login?appIdKey=D635F5C417E087A3B9864DAC5D25920C4E9442C9

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-11-01 Thread Eric Seidel
https://daw.apple.com/cgi-bin/WebObjects/DSAuthWeb.woa/wa/login?appIdKey=D635F5C417E087A3B9864DAC5D25920C4E9442C9339FA9277951628F0291F620&path=//devcenter/mac/index.action is the direct download link. Will require you to log in, sadly. -eric On Mon, Nov 1, 2010 at 4:29 PM, Eric Seidel wrote: >

Re: [webkit-dev] Any objections to switching to Xcode 3.2.4 or newer?

2010-11-01 Thread Eric Seidel
I would like to restate Darin's request: Please upgrade to 3.2.4 or newer. It would be really nice to end the developmentRegion = English war. 3.2.4 seems to work fine, and I'm told it might actually make distcc work again. ;p -eric On Wed, Oct 6, 2010 at 5:00 PM, Darin Adler wrote: > Hi fol

Re: [webkit-dev] W3C Proposal: User Interface Independence for Accessible Rich Internet Applications

2010-11-01 Thread Chris Fleizach
Hi Ojan, You reviewed- the first pass at an implementation of this proposal https://bugs.webkit.org/show_bug.cgi?id=47301 but haven't responded to this thread. Do you have any other objections. On Oct 27, 2010, at 2:57 PM, James Craig wrote: > Sorry for the delayed response, Tony. My answers

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread David Levin
On Mon, Nov 1, 2010 at 10:06 AM, Brady Eidson wrote: > > On Nov 1, 2010, at 10:00 AM, David Hyatt wrote: > > Yeah I agree with Peter. I think blank lines after { and before } would > improve the readability of the 2nd example even without indentation. > > namespace WebCore { > > class Authentica

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread Brady Eidson
On Nov 1, 2010, at 10:00 AM, David Hyatt wrote: > Yeah I agree with Peter. I think blank lines after { and before } would > improve the readability of the 2nd example even without indentation. > > namespace WebCore { > > class AuthenticationChallenge; > class CachedFrame; > class HistoryItem;

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread David Hyatt
Yeah I agree with Peter. I think blank lines after { and before } would improve the readability of the 2nd example even without indentation. namespace WebCore { class AuthenticationChallenge; class CachedFrame; class HistoryItem; class ProtectionSpace; class ResourceLoader; class ResourceReques

Re: [webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread Peter Kasting
On Mon, Nov 1, 2010 at 9:40 AM, Brady Eidson wrote: > I think this pattern increases readability of forward declarations in > headers and we should change the style guidelines to specify its continued > use. > > Thoughts? > I don't find either one significantly better than the other, personally.

[webkit-dev] Coding style change - Indentation of forward declarations in headers

2010-11-01 Thread Brady Eidson
Currently, the style guidelines specify "The contents of an outermost namespace block (and any nested namespaces with the same scope) should not be indented." I like this rule - *most* of the time. A common pattern throughout the project is forward declaring types from different namespaces in h

Re: [webkit-dev] scroll event firing for WebKit Gtk port

2010-11-01 Thread Nilesh Patil
Hi I think you will have to look for scrollviewgtk.cpp and scrollview.cpp - a platform side implementation for scrollable view in Gtk. Thanks & Regards Nilesh On Mon, Nov 1, 2010 at 5:05 PM, Aneesh Bhasin wrote: > Hi All, > > I am trying to figure out which functions are triggered when we scrol

[webkit-dev] scroll event firing for WebKit Gtk port

2010-11-01 Thread Aneesh Bhasin
Hi All, I am trying to figure out which functions are triggered when we scroll a webpage in the Gtk port of WebKit. I am using GtkLauncher for the experiments. I could see webkit_web_view_scroll_event() and webkit_web_view_real_move_cursor() (in WebKit/gtk/webkit/webkitwebview.cpp) being triggere