Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Maciej Stachowiak
On Jan 18, 2011, at 4:50 PM, Darin Adler wrote: > On Jan 18, 2011, at 4:43 PM, Ryosuke Niwa wrote: > >> What kind of diffs you're getting for the wrappers? > > All kinds. Most are some small difference between the template and the > generated wrapper. An HTML5 DOCTYPE instead of the one in the

Re: [webkit-dev] Leopard Bot has been broken for 5 days.

2011-01-18 Thread Mihai Parparita
If this is the same as http://webkit.org/b/51807, then it's actually been broken for a couple of weeks. Mihai On Tue, Jan 18, 2011 at 10:12 PM, Adam Barth wrote: > I investigated this issue for a while.  Disabling the test just causes > the next test to fail.  I'm not very familiar with this cod

Re: [webkit-dev] Leopard Bot has been broken for 5 days.

2011-01-18 Thread Adam Barth
I investigated this issue for a while. Disabling the test just causes the next test to fail. I'm not very familiar with this code. I can spend more time investigating, but having someone familiar with ideographs would likely be more efficient. Adam On Tue, Jan 18, 2011 at 4:49 PM, Eric Seidel

Re: [webkit-dev] question re: including some python-licensed code into the tree

2011-01-18 Thread Adam Barth
In the past, we've used autoinstall to make use of library code that doesn't have a compatible license, assuming that the library is freely distributed on the Internet. However, that approach does not seem appropriate for this particular use. Adam On Tue, Jan 18, 2011 at 3:59 PM, Dirk Pranke w

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Alexey Proskuryakov
18.01.2011, в 16:30, Darin Adler написал(а): > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers script. > I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to impro

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Darin Adler
On Jan 18, 2011, at 4:49 PM, Ojan Vafai wrote: > On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser wrote: > It would be good if the generated HTML had a big in it. > > I agree this would be valuable. We should do it. > If you need a non-standard wrapper, don't put the JS file in the script-tests

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Darin Adler
On Jan 18, 2011, at 4:36 PM, James Robinson wrote: > What are the advantages of using it vs generating script tests in other ways? The concept is that you write a script test and the wrapper is automatically generated. The advantage is that you don’t have to write the wrapper yourself. The long

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Darin Adler
On Jan 18, 2011, at 4:43 PM, Ryosuke Niwa wrote: > What kind of diffs you're getting for the wrappers? All kinds. Most are some small difference between the template and the generated wrapper. An HTML5 DOCTYPE instead of the one in the wrapper. A different relative path that goes up one level f

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Ojan Vafai
On Tue, Jan 18, 2011 at 4:46 PM, Simon Fraser wrote: > On Jan 18, 2011, at 4:30 PM, Darin Adler wrote: > > Any ideas on how to improve the situation? > > I usually take an existing .html file for a script test and modify it. It > would be good if the generated HTML had a big in it. I agree this

[webkit-dev] Leopard Bot has been broken for 5 days.

2011-01-18 Thread Eric Seidel
I ran "webkit-patch failure-reason" on "Leopard Intel Release (Tests)" and got: SUCCESS: Build 26596 (r75728) was the first to show failures: set([u'fast/blockflow/broken-ideograph-small-caps.html']) Suspect revisions: r75726: http://trac.webkit.org/changeset/75726 Bug: 52364 (https://bugs.web

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Simon Fraser
On Jan 18, 2011, at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers script. > I ran the script and it created 4 files, and modified 33 others. I'm probably guilty of some

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Ryosuke Niwa
On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers > script. I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to i

Re: [webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread James Robinson
On Tue, Jan 18, 2011 at 4:30 PM, Darin Adler wrote: > It seems that a lot of people are making script tests with non-standard > wrappers. And not adding exceptions to the make-script-test-wrappers > script. I ran the script and it created 4 files, and modified 33 others. > > Any ideas on how to i

[webkit-dev] make-script-test-wrappers not being maintained

2011-01-18 Thread Darin Adler
It seems that a lot of people are making script tests with non-standard wrappers. And not adding exceptions to the make-script-test-wrappers script. I ran the script and it created 4 files, and modified 33 others. Any ideas on how to improve the situation? -- Darin

[webkit-dev] question re: including some python-licensed code into the tree

2011-01-18 Thread Dirk Pranke
Hi all, In the course of working on new-run-webkit-tests, I find myself needing to implement a variant of some code normally provided in the Python standard library. Attempting to implement this in a clean room manner will be painful and nonobvious, so I'd just as soon just cut&paste the relevant

[webkit-dev] Trac/Svn Downtime: Jan 19th 7-8am PST

2011-01-18 Thread William Siegrist
The trac and svn servers will be down from 7 to 8am PST on January 19th for a hardware upgrade. The git mirror will still be available during this time in its usual read-only mode. Thanks, -Bill ___ webkit-dev mailing list webkit-dev@lists.webkit.org h

Re: [webkit-dev] Using Git for WebKit development

2011-01-18 Thread Konstantin Tokarev
18.01.2011, 12:52, "Jeremy Orlow" : > The info is on https://trac.webkit.org/wiki/UsingGitWithWebKit as well. > > On Tue, Jan 18, 2011 at 8:42 AM, Philippe Normand wrote: >> On Tue, 2011-01-18 at 11:26 +0300, Konstantin Tokarev wrote: >>> Hi all, >>> >>> When I'm trying to cherry-pick or rebase

Re: [webkit-dev] Using Git for WebKit development

2011-01-18 Thread Jeremy Orlow
The info is on https://trac.webkit.org/wiki/UsingGitWithWebKit as well. On Tue, Jan 18, 2011 at 8:42 AM, Philippe Normand wrote: > On Tue, 2011-01-18 at 11:26 +0300, Konstantin Tokarev wrote: > > Hi all, > > > > When I'm trying to cherry-pick or rebase something in my WebKit git > clone, > > I co

Re: [webkit-dev] Using Git for WebKit development

2011-01-18 Thread Philippe Normand
On Tue, 2011-01-18 at 11:26 +0300, Konstantin Tokarev wrote: > Hi all, > > When I'm trying to cherry-pick or rebase something in my WebKit git clone, > I constantly end up with conflicts in changelog files > > How do you fight this problem? > Add in your .git/config: [merge "changelog"]

[webkit-dev] Using Git for WebKit development

2011-01-18 Thread Konstantin Tokarev
Hi all, When I'm trying to cherry-pick or rebase something in my WebKit git clone, I constantly end up with conflicts in changelog files How do you fight this problem? -- Regards, Konstantin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http