Re: [webkit-dev] About removing comments

2011-02-01 Thread Adam Barth
On Tue, Feb 1, 2011 at 9:52 PM, Simon Fraser wrote: > On Feb 1, 2011, at 9:51 PM, Adam Barth wrote: >> On Tue, Feb 1, 2011 at 9:47 PM, Alexey Proskuryakov wrote: >>> Please don't start a comment removing crusade! >>> >>> I've just noticed a patch that got landed a few hours ago, which removed a

Re: [webkit-dev] About removing comments

2011-02-01 Thread Simon Fraser
On Feb 1, 2011, at 9:51 PM, Adam Barth wrote: > On Tue, Feb 1, 2011 at 9:47 PM, Alexey Proskuryakov wrote: >> >> Please don't start a comment removing crusade! >> >> I've just noticed a patch that got landed a few hours ago, which removed a >> comment I found quite useful when fixing a bug in

Re: [webkit-dev] About removing comments

2011-02-01 Thread Adam Barth
On Tue, Feb 1, 2011 at 9:47 PM, Alexey Proskuryakov wrote: > > Please don't start a comment removing crusade! > > I've just noticed a patch that got landed a few hours ago, which removed a > comment I found quite useful when fixing a bug in related code, >

[webkit-dev] About removing comments

2011-02-01 Thread Alexey Proskuryakov
Please don't start a comment removing crusade! I've just noticed a patch that got landed a few hours ago, which removed a comment I found quite useful when fixing a bug in related code, . This was essentially a FIXME, and it also explained the end

Re: [webkit-dev] safari extension script loading within injected file

2011-02-01 Thread Nick Guenther
Cluestick (or n00b question): What's 'document' within the extension scope? - Original message - > Hello list, > > I am seeing some behavior that I cannot explain with a safari 5 > extension. First, let me show a bit of code that works as expected > outside the extension environment.  T

[webkit-dev] Proposal to Reorganize Position Classes

2011-02-01 Thread Ryosuke Niwa
Hi all, * * *While I'm not intending to write a patch for the following proposal anytime soon, I'd really like to get your feedback.* * * As you might all know, Position classes in WebCore need refactoring and cleanup. Part of it is due to legacy editing positions that do many "magics", and we're

Re: [webkit-dev] code review tool changes

2011-02-01 Thread Ojan Vafai
Forgot one. Comments from the style checker are also shown in the code review tool now. On Wed, Feb 2, 2011 at 12:09 PM, Ojan Vafai wrote: > There's been a slew of changes to the code review tool. It's probably a > good time to send a summary now that I don't intend to add significant new > feat

Re: [webkit-dev] code review tool changes

2011-02-01 Thread Kenneth Russell
On Tue, Feb 1, 2011 at 5:09 PM, Ojan Vafai wrote: > There's been a slew of changes to the code review tool. It's probably a good > time to send a summary now that I don't intend to add significant new > features. > -Side-by-side diffs: You can view the entire diff or individual files in > side-by-

[webkit-dev] Server Downtime - Feb 2nd, 7 - 8am PST

2011-02-01 Thread William Siegrist
We are upgrading another server tomorrow morning at 7am PST. Downtime should be about an hour and I will make announcements in #webkit as usual. Mail delivery to @webkit addresses and mailing lists will not happen during the downtime, but mail should catch up once we come back up. Affected servi

[webkit-dev] code review tool changes

2011-02-01 Thread Ojan Vafai
There's been a slew of changes to the code review tool. It's probably a good time to send a summary now that I don't intend to add significant new features. -Side-by-side diffs: You can view the entire diff or individual files in side-by-side diff. If you change the entire diff, we'll store that i

[webkit-dev] How to remove derived files from XCode IDE?

2011-02-01 Thread Won J Jeon
Hi all, With XCode IDE, is there a simple way to remove all the derived files and regenerate them after modifying/adding idl files and build a new WebCore project? Regards, Won ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.

[webkit-dev] safari extension script loading within injected file

2011-02-01 Thread Lou Zell
Hello list, I am seeing some behavior that I cannot explain with a safari 5 extension. First, let me show a bit of code that works as expected outside the extension environment. This loads jQuery from javascript: (function(){ var node = document.createElement('script'); node.onload = functi

Re: [webkit-dev] Upload handling

2011-02-01 Thread Nick Guenther
> From: webkit-dev-boun...@lists.webkit.org > [mailto:webkit-dev-boun...@lists.webkit.org] On Behalf Of carlos del ojo > Sent: Tuesday, February 01, 2011 1:25 PM > To: webkit-dev@lists.webkit.org > Subject: [webkit-dev] Upload handling > > Hi dev's > > I was just working with code for embbedding

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-02-01 Thread Adam Barth
On Mon, Jan 31, 2011 at 6:04 PM, Jeremy Orlow wrote: > How hard will the transition be?  If it's going to take a lot of time and > cause a lot of churn anyway, would this be a good time to try and make that > port use GYP or CMake?  (I assume the answer is probably no, but figured it > was worth a

[webkit-dev] Upload handling

2011-02-01 Thread carlos del ojo
Hi dev's I was just working with code for embbedding webkit in an interface (gtk), and I was trying to handle and upload process (or form submit), because I want to prevent the FileDialog window and make another operations instead. So, is it possible?, I had been "googling" for a while, but it se

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-02-01 Thread Jake
I regularly build qtwebkit with VS2010 so the only real issue should be with project files. I did use the conversion wizard once on webkit/chromium and was able to build successfully with only a couple of minor tweaks. I'd be happy to do the legwork on the VS2010 upgrade if it'd help. -Jake On

Re: [webkit-dev] Using Visual Studio 2010 for Apple's Windows WebKit port

2011-02-01 Thread Adam Roben
On Jan 31, 2011, at 9:04 PM, Jeremy Orlow wrote: > How hard will the transition be? If it's going to take a lot of time and > cause a lot of churn anyway, would this be a good time to try and make that > port use GYP or CMake? (I assume the answer is probably no, but figured it > was worth as