[webkit-dev] process for unreviewed commits

2011-03-03 Thread Ojan Vafai
This isn't a big deal either way, but I noticed that http://trac.webkit.org/wiki/CommitterTips#Walkingyouthroughyourfirstcommitlists the following as the process for unreviewed commits: "Unreviewed commits should include a line saying "Unreviewed." in place of the "Reviewed By..." line in each Chan

Re: [webkit-dev] WebKit Inspector - Working with Breakpoints

2011-03-03 Thread Charles Pritchard
On 3/3/2011 6:23 AM, Patrick Mueller wrote: On 3/2/11 4:25 PM, Charles Pritchard wrote: By enriched I mean: I'd like to be able to "save" and/or "load" breakpoints. So, you'd like to be able to save some set of breakpoints (all the ones currently enabled?) into a file, and be able to reload it

[webkit-dev] Canvas backing resolution

2011-03-03 Thread Charles Pritchard
Is there currently an accepted way within webkit to get the resolution which should be used for an HTML canvas backing store? Currently, on Mobile Safari and Android, I can use window.devicePixelRatio, on the desktop, I use window.outerWidth / window.innerWidth and on FF4, I use a big string of

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Dan Bates
On Thu, 3 Mar 2011 12:47:56 -0800, Adam Barth wrote: > Dan Bates has done a bunch of great work teaching svn-apply about SVN > properties. I know svn-apply understands the executable bit, but I'm > unsure about the other properties. > svn-{apply, unapply} only respect the executable bit at this

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Adam Barth
Dan Bates has done a bunch of great work teaching svn-apply about SVN properties. I know svn-apply understands the executable bit, but I'm unsure about the other properties. Adam On Thu, Mar 3, 2011 at 9:32 AM, Alexey Proskuryakov wrote: > > 03.03.2011, в 08:42, Adam Roben написал(а): > >> Sub

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Alexey Proskuryakov
03.03.2011, в 08:42, Adam Roben написал(а): > Subversion properties aren't captured in patches, so the style bot is too > early in the process. We could add a pre-commit hook to check for the right > properties, though. I've always seen subversion properties in my and others' patches, see e.g

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Osztrogonac Csaba
+1 vote for pre-commit hook. Ossy Adam Roben írta: On Mar 3, 2011, at 11:40 AM, Oliver Hunt wrote: Can the style bot be made aware of .png at least and complain if you don't set the right flags? Subversion properties aren't captured in patches, so the style bot is too early in the process.

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Oliver Hunt
webkit-patch could be made aware of them -- how does the commit-queue handle it? If a patch doesn't include mime type info i would imagine it's doing something to prevent the annoying diff spew. --Oliver On Mar 3, 2011, at 8:42 AM, Adam Roben wrote: > On Mar 3, 2011, at 11:40 AM, Oliver Hunt

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Adam Roben
On Mar 3, 2011, at 11:40 AM, Oliver Hunt wrote: > Can the style bot be made aware of .png at least and complain if you don't > set the right flags? Subversion properties aren't captured in patches, so the style bot is too early in the process. We could add a pre-commit hook to check for the rig

Re: [webkit-dev] A tip for committers

2011-03-03 Thread Oliver Hunt
Can the style bot be made aware of .png at least and complain if you don't set the right flags? --Oliver On Mar 3, 2011, at 6:45 AM, Adam Roben wrote: > All committers are encouraged to follow the instructions I just added to >

[webkit-dev] A tip for committers

2011-03-03 Thread Adam Roben
All committers are encouraged to follow the instructions I just added to : > Subversion has a handy feature called auto-props that will ensure that new > binary files you add to the repository are given the correct MIME

Re: [webkit-dev] WebKit Inspector - Working with Breakpoints

2011-03-03 Thread Patrick Mueller
On 3/2/11 4:25 PM, Charles Pritchard wrote: By enriched I mean: I'd like to be able to "save" and/or "load" breakpoints. So, you'd like to be able to save some set of breakpoints (all the ones currently enabled?) into a file, and be able to reload it later? This seems like a good candidate for

[webkit-dev] Mouse event position related to actual element content

2011-03-03 Thread Sergiy Byelozyorov
Hello, I develop an extension to WebKit which adds support for XML3D. For mouse events on XML3D element I have created custom event type XML3DMouseEvent that inherits from MouseEvent. In addition to normal coordinates it also has 3D position and normal of the element under th

Re: [webkit-dev] Query regarding handling of NPObjects in webkit

2011-03-03 Thread Holger Freyther
On 03/03/2011 09:25 AM, Chandan Apsangi wrote: > Hi, > > I'm working on an issue related to NPAPI plugin on QT port of webkit on > Symbian platform. Hi, I would assume this issue is not specific to Qt and Symbian so you could try to debug it on a desktop build. In general we encourage you to cr

[webkit-dev] Query regarding handling of NPObjects in webkit

2011-03-03 Thread Chandan Apsangi
Hi, I'm working on an issue related to NPAPI plugin on QT port of webkit on Symbian platform. Basically our plug-in handles Async requests from JavaScript and does some processing and returns the response in the JavaScript callback asynchronously. In the JS callback, we are passing an NPObject i

Re: [webkit-dev] FYI: "webkit-patch upload" now works for security bugs EOM

2011-03-03 Thread Ryosuke Niwa
This is great! Nice work. - Ryosuke On Thu, Mar 3, 2011 at 5:07 PM, Ojan Vafai wrote: > > > ___ > webkit-dev mailing list > webkit-dev@lists.webkit.org > http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev > >

[webkit-dev] FYI: "webkit-patch upload" now works for security bugs EOM

2011-03-03 Thread Ojan Vafai
___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev