[webkit-dev] Resource Cache in WebKit2

2011-04-05 Thread Aneesh Bhasin
Hi All, I have been looking at the WebKit2 code in the latest git version to get more understanding about it. As fas as I could understand, the Resource Cache is still managed by each WebProcess individually (and the sample application is using the DOCUMENT_VIEWER cache model for now) and there is

Re: [webkit-dev] Canvas backing resolution

2011-04-05 Thread Charles Pritchard
Did this move anywhere? http://www.w3.org/Bugs/Public/show_bug.cgi?id=11328 https://bugs.webkit.org/show_bug.cgi?id=51190 http://code.google.com/p/chromium/issues/detail?id=66656 Firefox is a nasty CSS hack, but it does work, and that's something to be happy about. Microsoft makes it easy; Fire

Re: [webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Osztrogonac Csaba
Hi, The idea is awesome. ;) Getting rid of ~32k checksum files would speedup svn operations. I support you're works, please cc me to the bug report. br, Ossy Tony Chang írta: Yes, reading the checksum is the same speed as before. We write the png comment at the beginning of the file and onl

Re: [webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Tony Chang
Yes, reading the checksum is the same speed as before. We write the png comment at the beginning of the file and only scan the first 2k of the file for the checksum. I also tried converting about 200 tests to use embedded checksums and found no speed difference. I've already updated new-run-webk

Re: [webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Ojan Vafai
This is awesome! On Wed, Apr 6, 2011 at 5:11 AM, Tony Chang wrote: > > c) Update webkit-patch rebaseline to not copy over the .checksum file. > I don't think you need to do this. webkit-patch rebaseline is very basic right now. I think it only does the right thing for dumpAsText tests. _

Re: [webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Darin Adler
Sounds like a great idea, as long as reading the checksum is still fast. I couldn’t tell when you mentioned run-webkit-tests in your steps what your specific plans are for old-run-webkit-tests and new-run-webkit-tests. -- Darin ___ webkit-dev mail

[webkit-dev] embedding pixel result checksum in the png

2011-04-05 Thread Tony Chang
I propose that we move away from checking in separate .checksum files for pixel tests and instead embed the checksum in the .png file as a comment. There are two main benefits of doing this: 1) Less files in the tree -> faster git/svn operations. Currently, in LayoutTests, 32,650 out of 141,170 f

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Adam Roben
On Apr 5, 2011, at 1:17 PM, Pere Martir wrote: > On Tue, Apr 5, 2011 at 7:10 PM, Adam Roben wrote: >> The best way to report a bug like this is to file a new bug at >> . In this case, this is a known issue >> (), so you don't need to do anyt

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Pere Martir
On Tue, Apr 5, 2011 at 7:10 PM, Adam Roben wrote: > The best way to report a bug like this is to file a new bug at > . In this case, this is a known issue > (), so you don't need to do anything. There isn't > a workaround at this time, other

Re: [webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Adam Roben
On Apr 5, 2011, at 1:02 PM, Pere Martir wrote: > 64-bit Window 7. > > run-webkit-tests reported that many tests crashed, in addition to many > other failures due to the metric difference. > > Command line: > > Tools/Scripts/run-webkit-tests compositing/iframes > > Tests that caused DumpRender

[webkit-dev] Many crashs of regresion tests in 64-bit Windows

2011-04-05 Thread Pere Martir
64-bit Window 7. run-webkit-tests reported that many tests crashed, in addition to many other failures due to the metric difference. Command line: Tools/Scripts/run-webkit-tests compositing/iframes Tests that caused DumpRenderTree tool to crash: compositing/iframes/connect-compositing-ifram