[webkit-dev] Is ActiveDOMObject::scriptExecutionContext virtual or not?

2011-04-18 Thread Takashi Toyoshima
Hi, webkit guys. I have a question on ActiveDOMObject::scriptExecutionContext(). Now is was defined as non-virtual function. But currently, half of its inheritors defined this function as virtual. In my understanding, this virtual could not work because it's defined as non-virtual in its super cl

[webkit-dev] Please leave detailed information when you're rolling out patches

2011-04-18 Thread Ryosuke Niwa
Hi, I've seen a few people rolling out patches without leaving adequate explanations on the bugs. In my opinion, rolling out patches without explaining the reason is actively harmful to the project because: - The author and the reviewer have no idea what caused the patch to be rolled out.

Re: [webkit-dev] WebKit unit test framework

2011-04-18 Thread Dirk Pranke
I'd add "maintained" to your list, but otherwise it looks pretty good :) It would also be nice if the testing framework supported parallel or distributed execution, but not many do. -- Dirk On Mon, Apr 18, 2011 at 11:36 AM, David Levin wrote: > Issue: There has been a long standing bug to add u

[webkit-dev] WebKit unit test framework

2011-04-18 Thread David Levin
*Issue: *There has been a long standing bug to add unit tests to WebKit ( https://bugs.webkit.org/show_bug.cgi?id=21010). It was also mentionedon webkit-dev that it would be helpful in various cases. *Landscape:* Surveying

Re: [webkit-dev] mac-ews and cr-mac-ews

2011-04-18 Thread Eric Seidel
I've brought up two additional slaves, one for cr-mac-ews and one for mac-ews. We're back to being at-capacity instead of over-capacity. :) -eric On Fri, Apr 8, 2011 at 10:26 AM, Eric Seidel wrote: > Unfortunately the project's patch submission rate has grown such that > the mac-ews and cr-mac-

Re: [webkit-dev] Todo List for WebKit2

2011-04-18 Thread Balazs Kelemen
Is there any particular work being done on sandboxing like chrome ?? Yes, it is, but currently it is restricted to the Mac port as I know. I believe porting it is a goal for both the Qt and Gtk port. ___ webkit-dev mailing list webkit-dev@lists.webki

Re: [webkit-dev] Todo List for WebKit2

2011-04-18 Thread Alejandro Garcia Castro
On Mon, Apr 18, 2011 at 06:08:33PM +0530, naren.me...@gmail.com wrote: > Hi, > > On Mon, Apr 18, 2011 at 5:37 PM, Balazs Kelemen wrote: > > On 04/14/2011 02:34 PM, naren.me...@gmail.com wrote: > > > > Hi Everybody, > > > > I have recently started understanding webkit2 and am interested > > in par

Re: [webkit-dev] Todo List for WebKit2

2011-04-18 Thread naren . mehra
Hi, On Mon, Apr 18, 2011 at 5:37 PM, Balazs Kelemen wrote: > On 04/14/2011 02:34 PM, naren.me...@gmail.com wrote: > > Hi Everybody, > > I have recently started understanding webkit2 and am interested in > participating and contributing in this project. > So far I have gone through the available w

Re: [webkit-dev] Todo List for WebKit2

2011-04-18 Thread Balazs Kelemen
On 04/14/2011 02:34 PM, naren.me...@gmail.com wrote: Hi Everybody, I have recently started understanding webkit2 and am interested in participating and contributing in this project. So far I have gone through the available webkit2 code through GIT repository and studied the available documents.