Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Alexey Proskuryakov
03.07.2011, в 11:24, Patrick Gansterer написал(а): >>> I see three possible solutions: >>> 1) Always generate all IDL files. >>> 2) Change all [Conditional=XXX] to #if define(ENABLE_XXX). >>> 3) Add the correct #if ENABLE(XXX) around the header includes. >> >> (1) used to be the preferred soluti

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

2011-07-03 Thread Hao Zheng
> There's at least two reasons for divergence .. one is that the port is > actually doing the wrong thing, and the other is that the port is > doing the "right" thing but the output is different anyway (e.g., a > control is rendered differently). We cannot easily separate the two if > we have only

[webkit-dev] WebCL Release

2011-07-03 Thread Gyuyoung Kim
Hello WebKit Developers, Samsung has just open sourced an implementation of "WebCL" for WebKit. This is a prototype of a proposed WebCL standard that aims to define JavaScript APIs for OpenCL. The code is located at http://code.google.com/p/webcl/ and some demo videos at http://www.youtube.com/us

Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Patrick Gansterer
Am 03.07.2011 um 17:33 schrieb Alexey Proskuryakov: > >> I see three possible solutions: >> 1) Always generate all IDL files. >> 2) Change all [Conditional=XXX] to #if define(ENABLE_XXX). >> 3) Add the correct #if ENABLE(XXX) around the header includes. > > (1) used to be the preferred solution.

Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Alexey Proskuryakov
03.07.2011, в 02:12, Patrick Gansterer написал(а): > I see three possible solutions: > 1) Always generate all IDL files. > 2) Change all [Conditional=XXX] to #if define(ENABLE_XXX). > 3) Add the correct #if ENABLE(XXX) around the header includes. (1) used to be the preferred solution. It's so m

Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Adam Barth
Maybe the easier fix to make the code generator generate the proper conditionals for the includes? Adam On Sun, Jul 3, 2011 at 2:43 AM, Patrick Gansterer wrote: >> Does this cause a concrete problem? > > That's the only problem I had, when I compiling with !ENABLE(DATABASE). > IMO we don't requ

Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Patrick Gansterer
> Does this cause a concrete problem? That's the only problem I had, when I compiling with !ENABLE(DATABASE). IMO we don't require a new buildslave for this. Instead that's a more general problem. I think we will see the same problem for ENABLE(SVG) on the Qt minimal bot when we change the #if E

Re: [webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Adam Barth
Does this cause a concrete problem? I guess there are some configurations that don't build? Generally, configurations without buildbot won't actually build. The Qt minimal bot helps keep us honest in this regard, but I suspect there are lots of configurations that don't actually build. Adam O

[webkit-dev] IDL generation: [Conditional=XXX] vs. #if defined(ENABLE_XXX)

2011-07-03 Thread Patrick Gansterer
IMO [Conditional=XXX] does not generate correct output (only tried JSC). It adds top many header includes. Example with DOMWindow.idl: The line attribute [Conditional=DATABASE] SQLExceptionConstructor SQLException; adds #include "JSSQLException.h" independently of ENABLE_DATABASE. The lines #if