Re: [webkit-dev] Switching to new-run-webkit-tests

Update: Snow Leopard - Successful transition. Leopard - Had to roll-back due to a bug in webkitdirs.pm which errors in both ORWT and NRWT, but causes NRWT to fail hard. https://bugs.webkit.org/show_bug.cgi?id=63973 Gtk - Bot seems hard-hung (unclear if NRWT related). Waiting for assistance from a

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 5:40 PM, Dirk Pranke wrote: > > I keep hearing that the syntax is "excessively complicated". It's a > pretty simple syntax, but even you think that it is complicated, but > in what way is it excessively so, given that we actively use all of > the features it supports? > I f

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 5:46 PM, Dirk Pranke wrote: > On Tue, Jul 5, 2011 at 5:40 PM, Dirk Pranke wrote: > > On Tue, Jul 5, 2011 at 5:16 PM, Ojan Vafai wrote: > >> On Tue, Jul 5, 2011 at 4:51 PM, Dirk Pranke > wrote: > >>> > >>> On Tue, Jul 5, 2011 at 1:53 PM, Ryosuke Niwa wrote: > >>> > On Ju

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 5:40 PM, Dirk Pranke wrote: > On Tue, Jul 5, 2011 at 5:16 PM, Ojan Vafai wrote: >> On Tue, Jul 5, 2011 at 4:51 PM, Dirk Pranke wrote: >>> >>> On Tue, Jul 5, 2011 at 1:53 PM, Ryosuke Niwa wrote: >>> > On Jul 5, 2011 1:26 PM, "Dirk Pranke" wrote: >>> >> > However, we can d

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 5:16 PM, Ojan Vafai wrote: > On Tue, Jul 5, 2011 at 4:51 PM, Dirk Pranke wrote: >> >> On Tue, Jul 5, 2011 at 1:53 PM, Ryosuke Niwa wrote: >> > On Jul 5, 2011 1:26 PM, "Dirk Pranke" wrote: >> >> > However, we can do the same with the existing testing framework since >> >>

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 4:51 PM, Dirk Pranke wrote: > On Tue, Jul 5, 2011 at 1:53 PM, Ryosuke Niwa wrote: > > On Jul 5, 2011 1:26 PM, "Dirk Pranke" wrote: > >> > However, we can do the same with the existing testing framework since > we > >> > can > >> > associate a test with a bug by adding a l

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 1:53 PM, Ryosuke Niwa wrote: > On Jul 5, 2011 1:26 PM, "Dirk Pranke" wrote: >> > However, we can do the same with the existing testing framework since we >> > can >> > associate a test with a bug by adding a line like this: >> > BUGWK? my-test.html = PASS >> >> You lost

Re: [webkit-dev] Switching to new-run-webkit-tests

We've turned NRWT back on for the WebKit1 Snow Leopard bots. We believe we've solved the http-lock issue and will be monitoring the bots. -eric On Fri, Jul 1, 2011 at 5:54 PM, Adam Barth wrote: > Thanks for your patience with the disruptions on the tree today.  The > bots are having some troubl

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 3:46 PM, Ojan Vafai wrote: > > So, you could currently add a line like: > BUGWK12345 : fast/canvas/canvastest.html = PASS > > We could simplify the syntax somewhat to not require the "= PASS" at the > end. > How about renaming PASS to MATCH? MATCH will tell us that the act

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 3:22 PM, Maciej Stachowiak wrote: > > On Jul 5, 2011, at 12:29 PM, Dirk Pranke wrote: > > > The problem with your idea is I think what brought this idea up in the > first place: if you just track that the test is failing using the > test_expectations.txt file, but don't tra

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 3:22 PM, Maciej Stachowiak wrote: > > That's right, layout tests were designed to be regression tests rather than > correctness tests. They are supposed to detect changes in behavior. Having > an existing bug is not necessarily a good reason to drop test coverage. > > I thin

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Jul 5, 2011, at 12:29 PM, Dirk Pranke wrote: > > The problem with your idea is I think what brought this idea up in the > first place: if you just track that the test is failing using the > test_expectations.txt file, but don't track *how* it is failing (by > using something like the -failing

[webkit-dev] Fwd: Re: Does NRWT let you indicate that a test should fail with a particular failure diff?

-- Forwarded message -- From: "Ryosuke Niwa" Date: Jul 5, 2011 1:53 PM Subject: Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff? To: "Dirk Pranke" On Jul 5, 2011 1:26 PM, "Dirk Pranke" wrote: > > However, we can do the same with

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Tue, Jul 5, 2011 at 6:41 PM, Simon Fraser wrote: > These don't represent the suite of hardware and OSes that WebKit is used on > these days, nor do they represent the various ports. For example, there's no > way to indicate that a bug is in the QT port. > > Can we clean this up? > I agree the

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 1:21 PM, Ryosuke Niwa wrote: > On Tue, Jul 5, 2011 at 12:29 PM, Dirk Pranke wrote: >> >> The problem with your idea is I think what brought this idea up in the >> first place: if you just track that the test is failing using the >> test_expectations.txt file, but don't trac

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Tue, Jul 5, 2011 at 12:29 PM, Dirk Pranke wrote: > > The problem with your idea is I think what brought this idea up in the > first place: if you just track that the test is failing using the > test_expectations.txt file, but don't track *how* it is failing (by > using something like the -faili

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Tue, Jul 5, 2011 at 11:26 AM, Christopher Marrin wrote: > > Seems like it would be better to just have one field with the sum total of > all WebKit ports. I've seen plenty of combos like Macintosh PowerPC/Windows > 2000. How about: > > Unspecified (the default) > Mac OSX 10.5 > Mac OSX 10.6 >

Re: [webkit-dev] Does NRWT let you indicate that a test should fail with a particular failure diff?

On Sun, Jul 3, 2011 at 10:07 PM, Hao Zheng wrote: >> There's at least two reasons for divergence .. one is that the port is >> actually doing the wrong thing, and the other is that the port is >> doing the "right" thing but the output is different anyway (e.g., a >> control is rendered differently

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Jul 5, 2011, at 11:26 AM, Christopher Marrin wrote: > On Jul 5, 2011, at 9:47 AM, Adam Roben wrote: > >> On Jul 5, 2011, at 12:41 PM, Simon Fraser wrote: >> >>> Can we clean this up? >> >> Definitely! It's easy to change the options for these two fields. I don't >> know what would be involv

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Jul 5, 2011, at 9:47 AM, Adam Roben wrote: > On Jul 5, 2011, at 12:41 PM, Simon Fraser wrote: > >> Can we clean this up? > > Definitely! It's easy to change the options for these two fields. I don't > know what would be involved with replacing these two fields with something > else entirel

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

05.07.2011, в 10:21, Alexis Menard написал(а): > Though the component field let you choose "WebKit Qt". That's how we > catch our bugs :D and the keywords, Qt, QtTriaged. Bugzilla description for this component says that this usage is incorrect:

Re: [webkit-dev] WebCL Release

How has the WebCL spec dealt with the inherent security problems of OpenCL in the face of untrusted content? In the WebGL working group we spent a lot of time working on how to adequately restrict GLSL|ES to prevent security vulnerabilities, and I haven't really heard anything about what approa

Re: [webkit-dev] WebCL Release

Dear Simon, Thanks for your interest in our WebCL prototype in WebKit. Currently, it's integrated with WebKit r78407 and hasn't been checked with WebKit's coding style guidelines. It's tested on Mac with Nvidia GPU which supports OpenCL support. Updating the code to a newer WebKit and Porting th

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Tue, Jul 5, 2011 at 12:41 PM, Simon Fraser wrote: > The platform fields in Bugzilla are pretty much useless now. There's a > "rep_platform" popup (replicated platform?) containing: > > Unspecified > All > Macintosh PowerPC > Macintosh Intel > PC > S60 Hardware > S60 Emulator > Android > Other

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Jul 5, 2011, at 9:47 AM, Adam Roben wrote: > On Jul 5, 2011, at 12:41 PM, Simon Fraser wrote: > >> Can we clean this up? > > Definitely! It's easy to change the options for these two fields. I don't > know what would be involved with replacing these two fields with something > else entirely

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Tue, Jul 5, 2011 at 9:41 AM, Simon Fraser wrote: > The platform fields in Bugzilla are pretty much useless now. There's a > "rep_platform" popup (replicated platform?) containing: > > Unspecified > All > Macintosh PowerPC > Macintosh Intel > PC > S60 Hardware > S60 Emulator > Android > Other >

Re: [webkit-dev] Fixing the Platform fields in Bugzilla

On Jul 5, 2011, at 12:41 PM, Simon Fraser wrote: > Can we clean this up? Definitely! It's easy to change the options for these two fields. I don't know what would be involved with replacing these two fields with something else entirely. Do you have a proposal? -Adam _

[webkit-dev] Fixing the Platform fields in Bugzilla

The platform fields in Bugzilla are pretty much useless now. There's a "rep_platform" popup (replicated platform?) containing: Unspecified All Macintosh PowerPC Macintosh Intel PC S60 Hardware S60 Emulator Android Other and an "op_sys" popup, both containing: Unspecified All Windows 2000 Windo

Re: [webkit-dev] Writing a new XML parser with no external libraries

Writing a new XML parser is a complete waste of time. If libxml has problems, fix them. If you throw out libxml, you'd have to throw out libxslt as well. The end result is not worth the engineering effort it would take to build it and make it work better than libxml/libxslt. dave (hy...@apple.

Re: [webkit-dev] WebCL Release

On Jul 3, 2011, at 6:28 PM, Gyuyoung Kim wrote: > Hello WebKit Developers, > > Samsung has just open sourced an implementation of "WebCL" for WebKit. > This is a prototype of a proposed WebCL standard that aims to define > JavaScript APIs for OpenCL. > The code is located at http://code.google.c

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

Hi, some belated additional thoughts on this thread. On Wed Jun 15 02:41:01 PDT 2011 Holger Freyther wrote: > I am not participating in any W3C group so this might or might have been > discussed but this specification seems to be over simplified, specially if you > compare it what is provided by

Re: [webkit-dev] [webkit-help] Revision 88076 causes compile error 'maxTokenLength' : undeclared identifier

Hi. I figured out. There are 2 blank lines in Keywords.table http://svn.webkit.org/repository/webkit/trunk/Source/JavaScriptCore/parser/Keywords.table After I delete these lines, it seems going well. (still under compiling though.) Cheers! On Tue, Jul 5, 2011 at 3:22 PM, Toshiya TSURU wrote: