Re: [webkit-dev] Top Crasher: Shadow DOM and Editing Collide Again

2011-08-30 Thread Ryosuke Niwa
After reading Dimitri's analysis and talking to him on IRC, I'm convinced that we don't have to call setInnerTextValue in updateFromElement. I've uploaded a work-in-progress patch to the bug 66241 that realizes this idea. - Ryosuke On Mon, Aug 29, 2011 at 2:34 PM, Ryos

Re: [webkit-dev] lots of red in the tree.

2011-08-30 Thread David Levin
On Tue, Aug 30, 2011 at 10:55 AM, Jarred Nicholls wrote: > On Tue, Aug 30, 2011 at 1:52 PM, David Levin wrote: > >> It means that I'm much more likely to cause regressions because I miss new >> test failures caused by my changes among the 12 to 62 failures >> already occurring on the OS X bots.1

Re: [webkit-dev] WTF StackBounds not compatible with Windows fiber threads & custom fiber or thread stack size

2011-08-30 Thread Gavin Barraclough
I had a partially working solution to this using the deallocation stack member of the Win32 Thread Information Block, see https://bugs.webkit.org/show_bug.cgi?id=26276 & http://en.wikipedia.org/wiki/Win32_Thread_Information_Block – but I didn't manage to get this working consistently. Perhaps

Re: [webkit-dev] lots of red in the tree.

2011-08-30 Thread Jarred Nicholls
On Tue, Aug 30, 2011 at 1:52 PM, David Levin wrote: > It means that I'm much more likely to cause regressions because I miss new > test failures caused by my changes among the 12 to 62 failures > already occurring on the OS X bots.1 > Yeah it was wigging me out this morning. > > I think there

[webkit-dev] lots of red in the tree.

2011-08-30 Thread David Levin
It means that I'm much more likely to cause regressions because I miss new test failures caused by my changes among the 12 to 62 failures already occurring on the OS X bots. I think there are a few solutions to the current situation: 1. Live with it. All of the red and green reminds us of the fes

Re: [webkit-dev] WTF StackBounds not compatible with Windows fiber threads & custom fiber or thread stack size

2011-08-30 Thread Darin Adler
Seems more like a Windows question rather than a WebKit question. Can you get the stack size for a Windows thread or not? On platforms where we don’t know how to get the stack size we just have a fixed guess in StackBounds.cpp. -- Darin ___ webki