Re: [webkit-dev] Making PopupMenuClient testable

Please review then? :-) Fady On Mon, Oct 10, 2011 at 9:11 PM, Darin Adler wrote: > On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote: > >> My solution in 69631 is to expose the bounding box rect through the >> PopupMenuClient interface and make it testable through window.internals. >> I've also i

Re: [webkit-dev] Making PopupMenuClient testable

On Oct 10, 2011, at 7:57 AM, Fady Samuel wrote: > My solution in 69631 is to expose the bounding box rect through the > PopupMenuClient interface and make it testable through window.internals. I've > also included a layout test to show how one would test this. Right now the > test fails, but on

Re: [webkit-dev] Making PopupMenuClient testable

Hi Johnny, >>> What I mean is regular render tree dump, not pixel dump, not text dump. >>> Please refer here for test expectation and see in TestShell::dump in DRT >>> chromium port  I don't believe a render tree dump will solve this problem because the issue is the rect that is being passed in

Re: [webkit-dev] Optimization of buffer allocation of Vector and StringBuilder

On Oct 10, 2011, at 4:46 AM, Xianzhu Wang (王显著) wrote: > malloc_good_size() can get the rounded-up size of a required size, but it > seems not available on all platforms. It's easy to implementation it over > tcmalloc. On platforms that malloc_good_size() is not available, it's > possible to ge

Re: [webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

This is nothing to do with RefPtr. - Ryosuke On Mon, Oct 10, 2011 at 10:56 AM, David Levin wrote: > It feels like the material about RefPtr belongs here: > http://www.webkit.org/coding/RefPtr.html instead of the style guide since > that is where everything else about how to properly use RefPtr/

Re: [webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

It feels like the material about RefPtr belongs here: http://www.webkit.org/coding/RefPtr.html instead of the style guide since that is where everything else about how to properly use RefPtr/PassRefPtr is. On Mon, Oct 10, 2011 at 10:42 AM, Ryosuke Niwa wrote: > FYI, a patch has been posted to >

Re: [webkit-dev] Change to style guideline: should use type& instead of type* for out arguments

FYI, a patch has been posted to https://bugs.webkit.org/show_bug.cgi?id=69766 to make this change along with "get" prefix convention for getters that return values via out arguments. - Ryosuke On Tue, Oct 4, 2011 at 2:06 PM, Ryosuke Niwa wrote: > Hi, > > It came to my attention that some people

Re: [webkit-dev] : Modifying expected.txt of layout testcases

On Mon, Oct 10, 2011 at 6:35 AM, Vamshi wrote: > > I proposed patch for the bug ID:20040, https://bugs.webkit.org/show_** > bug.cgi?id=20040 which > resulted in failure of few layout testcases. After analysis, I found that > the expected.txt needs

Re: [webkit-dev] Fwd: Typography in webkit

Hi Meir. This list is primarily for contributors to discuss dev issues in WebKit itself. You will have more luck with http://lists.webkit.org/mailman/listinfo/webkit-help. For more info, see http://www.webkit.org/contact.html Regards, --Tom > Hi to everyone, > > I am developer in a project whi

Re: [webkit-dev] Making PopupMenuClient testable

Fady, please see my comments inline, Thank. 在 2011年10月10日 下午10:57，Fady Samuel 写道： > +darin > > Johnny, I'm not sure what you mean. By the render dump, do you mean the > pixel dump? Popups don't show up in pixel dumps. I'm not sure what > information you can get from that. > > What I mean is regul

Re: [webkit-dev] Making PopupMenuClient testable

+darin Johnny, I'm not sure what you mean. By the render dump, do you mean the pixel dump? Popups don't show up in pixel dumps. I'm not sure what information you can get from that. The bug that I'm trying to address, is, among other things, the bounding box rect of the PopupMenuClient that is pas

[webkit-dev] : Modifying expected.txt of layout testcases

Hi All, I proposed patch for the bug ID:20040, https://bugs.webkit.org/show_bug.cgi?id=20040 which resulted in failure of few layout testcases. After analysis, I found that the expected.txt needs to be modified in order to make the test cases p

[webkit-dev] Optimization of buffer allocation of Vector and StringBuilder

Hi, One aspect of the cost of WTF::Vector and WTF::StringBuilder is about buffer expansion and shrinking. The affecting factors include the minimum capacity, policy of expansion and shrinking, etc. I think the optimal configurations of them are related to not only the application, but also the und

Re: [webkit-dev] Making PopupMenuClient testable

在 2011年10月7日 下午11:56，Fady Samuel 写道： > Hi all, > > I've just uploaded a patch https://bugs.webkit.org/show_bug.cgi?id=69631 > that's > intended to make PopupMenuClient testable. > > On certain Chromium platforms, the position of the element's popup > is incorrect if the page's scale factor is no

[webkit-dev] Fwd: Typography in webkit

Hi to everyone, I am developer in a project which to produce thousands of HTML5 pages. I have lofts of problem with fonts and typography in general (@font-face, kerning, ligatures..). I don't want to spam this mailing list so I wondering is there a webkit dev who is specialist(s) about those ques