Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 2:38 PM, Ryosuke Niwa wrote: > On Fri, Nov 18, 2011 at 2:27 PM, Adam Barth wrote: > >> We move files around all the time. If we're afraid to move files for >> these reasons, we'll be stuck with bad organizational choices we made >> in the distant past. WebKit's philosop

[webkit-dev] Simplifying "hub" classes (was Cleaning up directories in WebCore)

On Fri, Nov 18, 2011 at 2:38 PM, Ryosuke Niwa wrote: > On Fri, Nov 18, 2011 at 2:27 PM, Adam Barth wrote: >> I've done some analysis of header inclusion dependencies, and they're >> actually pretty good for these directories.  The main issues at the >> moment are "hub" classes like Page, Frame, a

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 2:27 PM, Adam Barth wrote: > On Fri, Nov 18, 2011 at 1:47 PM, Ryosuke Niwa wrote: > > Still, if I see a crash in shipped version of Chrome, then I have to > > remember to map between different paths, which will be a huge cognitive > > overhead for the next couple of month

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 1:47 PM, Ryosuke Niwa wrote: > On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth wrote: >> On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa  wrote: >>> >>> What's the benefit of this re-org? >> >> The benefit is mostly to improve the hackability of WebKit by grouping >> related co

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth wrote: > Features/ >  notifications/ (8 files) >  storage/ (195 files) >  fileapi/ (115 files) >  webaudio/ (103 files) >  mediastream/ (28 files; under active development) >  workers/ (43 files) >  websockets/ (20 files) >  inspector/ (426 files) Alon

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 11:21 AM, Adam Barth wrote: > On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa wrote: What's the benefit of this re-org? > > The benefit is mostly to improve the hackability of WebKit by grouping > related code together and separating unrelated code. My hope is that > the

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 1:25 PM, Kenneth Russell wrote: > On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth wrote: >> I've been looking for ways to improve the hackability of WebCore, and >> one thing that's been bothering me is the organization of our files. >> It seems like we're due for a bit of "fa

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth wrote: > I've been looking for ways to improve the hackability of WebCore, and > one thing that's been bothering me is the organization of our files. > It seems like we're due for a bit of "fall cleaning" for directories. > We've talked about some of the

[webkit-dev] Could use some help from SVG and Web Workers experts on leak hunting

Hi all- Darin Adler's been helping me sift through the leaks we're seeing on the Lion Intel Leaks bot. (You can see the results of a recent run here: .) We could use some expert advice for two o

Re: [webkit-dev] 8 Bit Strings Turned On in JavaScriptCore

On Nov 18, 2011, at 11:18 AM, Adam Roben wrote: > On Nov 18, 2011, at 2:14 PM, Michael Saboff wrote: > >> Although the UChar* characters() method for the various string classes still >> works, all new code should check what "flavor" a string is constructed by >> using the new is8Bit() method on

Re: [webkit-dev] Cleaning up directories in WebCore

On Fri, Nov 18, 2011 at 2:06 AM, Ryosuke Niwa wrote:> What's the benefit of this re-org? The benefit is mostly to improve the hackability of WebKit by grouping related code together and separating unrelated code. My hope is that the code in the "Features" directory will become more self-contained

Re: [webkit-dev] 8 Bit Strings Turned On in JavaScriptCore

On Nov 18, 2011, at 2:14 PM, Michael Saboff wrote: > Although the UChar* characters() method for the various string classes still > works, all new code should check what "flavor" a string is constructed by > using the new is8Bit() method on the various string classes. After > determining the f

[webkit-dev] 8 Bit Strings Turned On in JavaScriptCore

With the recently landed changes in (and two subsequent fixes in and ), strings in JavaScriptCore are stored internally in either 8 bit or 16 bit forms. This is implement

Re: [webkit-dev] Removing Support for Python 2.5

The bot step that runs ui_tests uses scripts/slave/runtest.py. You could probably set PATH in that script before launching ui_tests. http://build.chromium.org/p/chromium/builders/Mac10.5%20Tests%20%282%29/builds/10395/steps/ui_tests/logs/stdio http://src.chromium.org/viewvc/chrome/trunk/tools/bui

Re: [webkit-dev] Cleaning up directories in WebCore

On Nov 18, 2011, at 1:51 AM, Adam Barth wrote: > Features/ <-- New folder for (roughly) self-contained features I like the concept, but not the name. I’ll try to think on this and suggest a name I like better than “features”. > notifications/ > storage/ > fileapi/ > webaudio/ > mediastrea

Re: [webkit-dev] Cleaning up directories in WebCore

I agree. My personal favorite is the moving out of the side-loaded features. This looks like a great way to add clarity to what WebCore really means. :DG< On Fri, Nov 18, 2011 at 2:19 AM, Eric Seidel wrote: > SGTM. > > manual-tests is a no-brainer for sure. > > On Fri, Nov 18, 2011 at 1:51 AM, A

Re: [webkit-dev] Cleaning up directories in WebCore

SGTM. manual-tests is a no-brainer for sure. On Fri, Nov 18, 2011 at 1:51 AM, Adam Barth wrote: > I've been looking for ways to improve the hackability of WebCore, and > one thing that's been bothering me is the organization of our files. > It seems like we're due for a bit of "fall cleaning" fo

Re: [webkit-dev] Cleaning up directories in WebCore

I also agree with moving Platform out. That would make the dependencies easier to understand and hopefully avoid more layering violations. Kenneth On Fri, Nov 18, 2011 at 11:06 AM, Ryosuke Niwa wrote: > What's the benefit of this re-org? > Is it really worth the trouble to move these files aroun

Re: [webkit-dev] Cleaning up directories in WebCore

What's the benefit of this re-org? Is it really worth the trouble to move these files around? This would mean that we may need to navigate multiple pages on trac to see revision logs. Other tools may suffer from such file moves as well. I remember I had to create new git checkout when Source move

[webkit-dev] Cleaning up directories in WebCore

I've been looking for ways to improve the hackability of WebCore, and one thing that's been bothering me is the organization of our files. It seems like we're due for a bit of "fall cleaning" for directories. We've talked about some of these ideas before, but I wanted to put them all in one email s