Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

On Jun 6, 2012 10:36 PM, "Peter Kasting" wrote: > > On Wed, Jun 6, 2012 at 10:22 PM, Ryosuke Niwa wrote: >> >> Now that everyone knows the problem, I propose to rename FAIL to DIFF. >> >> FAIL should mean that the test fails, not that it fails with image, text, or image and text failures. >> >> D

Re: [webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

On Wed, Jun 6, 2012 at 10:22 PM, Ryosuke Niwa wrote: > Now that everyone knows the problem, I propose to rename FAIL to DIFF. > > FAIL should mean that the test fails, not that it fails with image, text, > or image and text failures. > > DIFF, on the other hand, has no ambiguity. It can't be inte

[webkit-dev] Rename FAIL to DIFF Was (Re: PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT)

Now that everyone knows the problem, I propose to rename FAIL to DIFF. FAIL should mean that the test fails, not that it fails with image, text, or image and text failures. DIFF, on the other hand, has no ambiguity. It can't be interpreted as timeout, crash, or pass but can easily be associated w

[webkit-dev] PSA: FAIL test expectation does not encompass MISSING, CRASH, or TIMEOUT

Hi, As much as it doesn't make any sense to me, FAIL test expectation doesn't cover MISSING, CRASH, and TIMEOUT test expectations as it is currently interpreted by new-run-webkit-tests. Meaning that BUGRNIWA : some-pixel-test-i-am-adding.html = FAIL is logically equivalent to BUGRNIWA : some-pi

Re: [webkit-dev] DOM tree traversal on detached nodes

On Thu, Jun 7, 2012 at 10:27 AM, Darin Adler wrote: > On Jun 6, 2012, at 6:14 PM, Kentaro Hara wrote: > > IMHO, (a) would be the best semantics. > > > I agree, and I think that the specification actually does require this. > > The real issue here is how to fix this bug efficiently. I believe tha

Re: [webkit-dev] DOM tree traversal on detached nodes

On Jun 6, 2012, at 6:14 PM, Kentaro Hara wrote: > IMHO, (a) would be the best semantics. I agree, and I think that the specification actually does require this. The real issue here is how to fix this bug efficiently. I believe that Geoff Garen has been contemplating this and also has a proposa

Re: [webkit-dev] DOM tree traversal on detached nodes

> The semantics will fix the > FIXME > in JSC GC. Sorry, the link was wrong. Correction: Here

[webkit-dev] DOM tree traversal on detached nodes

[Summary] What values should span.parentNode and span.firstChild return in the following code? (test html ). div = document.createElement("div"); document.body.appendChild(div); div.innerHTML = 'text'; span = document.getElementById("span"); div

Re: [webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

Our past experience with this sort of thing at Apple is that it led to bugs we didn’t find until after we shipped “final” software because they did not show up during earlier testing. Since then, we’ve gone out of our way to avoid differences, since one of the main things we want to do with non-

[webkit-dev] Adding ENABLE_NAVIGATOR_BUILDTYPE to WebCore

Hi webkit-dev! I wanted to let you know that I plan to add support for navigator.buildType (e.g., "nightly", "beta", "final") to WebKit. This feature isn't on the standards track (but neither are a bunch of other similar properties on Navigator). This feature will be behind the ENABLE(NAVIGATOR_BU

Re: [webkit-dev] Using ref tests for repaint bugs

I want to give everyone an update on how things are evolving. For now, I've focused most of the development on the Mac platform. For the ref-tests-as-repaint-tests path, I've added an optional parameter to LTC.display() that should control if the repaint rectangles are tracked or not. If not speci

Re: [webkit-dev] paged media update?

Hey Dave, thanks for the information (and sorry for not answering sooner). Do you have any (rough) ETA on when the required refactorings are going to land in WebKit trunk? Is there maybe a way for me to stay notificated about updates, i.e. some bug report used to track the refactoring? If possi