Re: [webkit-dev] Unprefixing Blob.webkitSlice() ?

2012-06-10 Thread Kinuko Yasuda
On Mon, Jun 11, 2012 at 3:34 PM, Darin Fisher wrote: > Happy to see us support unprefixed too. With other vendors on board, it > seems like a straightforward addition to the platform. > > I'm not sure if you are proposing to also remove the prefixed form. I'm > not sure what it would take to re

Re: [webkit-dev] Unprefixing Blob.webkitSlice() ?

2012-06-10 Thread Darin Fisher
Happy to see us support unprefixed too. With other vendors on board, it seems like a straightforward addition to the platform. I'm not sure if you are proposing to also remove the prefixed form. I'm not sure what it would take to remove the prefixed version. We'd need some way to know when it i

[webkit-dev] Unprefixing Blob.webkitSlice() ?

2012-06-10 Thread Kinuko Yasuda
Hi WebKit folks, We've been vendor-prefixing Blob.slice() since we changed the semantics of slice() to make it alike Array.slice, i.e. from "start, length" to "start, end" semantics in r83873 [1]. The non-prefixed version had only been shipped in Chrome and must have helped apps migrate into the

Re: [webkit-dev] Running layout tests for the chromium port, using the multi-processing architecture and fully sandboxed

2012-06-10 Thread Darin Fisher
On Fri, Jun 8, 2012 at 12:51 PM, Jochen Eisinger wrote: > > > On Fri, Jun 8, 2012 at 9:41 PM, Ryosuke Niwa wrote: > >> On Fri, Jun 8, 2012 at 12:18 PM, Jochen Eisinger wrote: >> >>> I've implemented initial support for running layout tests using >>> chromium's content_shell instead of test_shell

Re: [webkit-dev] Using the WebExposed keyword for web-facing changes

2012-06-10 Thread TAMURA, Kent
Do you want WebExposed for a simple bug fix of an existing feature? Do you want it for bugs with no patches? On Sat, Jun 9, 2012 at 5:24 AM, Peter Beverloo wrote: Hi webkit-dev, *If you work on web-facing features, or run into another bug which does, please consider adding the **"**WebExpos

Re: [webkit-dev] GTK+ port's help needed to get rid of FAIL test expectation

2012-06-10 Thread Žan Doberšek
I think it would suffice to replace all the FAIL occurrences with TEXT, except for the failing reftests - those should have FAIL turned into IMAGE. Gtk bots don't run pixel tests yet so any other IMAGE failures could perhaps be addressed at later time. I'd like some approval on this from the senio

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Antonio Gomes
> Untested code is inherently harder to maintain in my experience. Most of > the time, committing untested code is just implanting technical debt that > someone will have to pay later. > > I think the above, by its own, summarizes what people advocating in favor of tests (for any area of the projec

[webkit-dev] Plug Ins dont work when rebuilding WebKit

2012-06-10 Thread Mark Gilbert
Hi There I know this has been discussed before, but the solution doesn't work for me I am making a tiny behavioural change to WebCore, then rebuilding WebKit to use in a specialist application. When I am done building I move the frameworks into the pre-built WebKit nightly build application. T

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Ojan Vafai
On Sun, Jun 10, 2012 at 4:54 AM, Balazs Kelemen wrote: > > So the unit tests are superfluous. In particular, if I had to pick >> between only having unit tests or only having regression tests, I might >> pick unit tests. But if I already have regression tests then I'm unlikely >> to want to in

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Adam Barth
On Sun, Jun 10, 2012 at 4:54 AM, Balazs Kelemen wrote: > So the unit tests are superfluous. In particular, if I had to pick >> between only having unit tests or only having regression tests, I might >> pick unit tests. But if I already have regression tests then I'm unlikely >> to want to incur

Re: [webkit-dev] can we stop using Skipped files?

2012-06-10 Thread Balazs Kelemen
So the unit tests are superfluous. In particular, if I had to pick between only having unit tests or only having regression tests, I might pick unit tests. But if I already have regression tests then I'm unlikely to want to incur technical debt to build unit tests, particu