[webkit-dev] webkit debug build error - memory exhausted even on 32GB Ram

2012-06-13 Thread Navanshu Mahor
Hello webkit.org community, i am trying to build webkit in debug mode on server that is 64bit and 32GB RAM system. Inspite of having such large ram it is showing following memory exhausted error : /usr/bin/ld: failed to set dynamic section sizes: Memory exhausted collect2: ld returned 1 exit

Re: [webkit-dev] webkit debug build error - memory exhausted even on 32GB Ram

2012-06-13 Thread Sergio Villar Senin
En 13/06/12 10:25, Navanshu Mahor escribiu: Hello webkit.org http://webkit.org community, i am trying to build webkit in debug mode on server that is 64bit and 32GB RAM system. Inspite of having such large ram it is showing following memory exhausted error : /usr/bin/ld: failed to set

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Zoltan Horvath
Hi, The bug report about fastMalloc(0): https://bugs.webkit.org/show_bug.cgi?id=55097 Brewmp had conditions for fastMalloc(0) earlier, but it was removed in: http://trac.webkit.org/changeset/9/trunk/Source/JavaScriptCore/wtf/FastMalloc.cpp Cheers, Zoltan On Wed, 13 Jun 2012 00:08:48

Re: [webkit-dev] build.webkit.org down for upgrade

2012-06-13 Thread Osztrogonac Csaba
Hi, Sorry for the late response, I didn't have to much time last week. But fortunately I managed to fix it today, and uploaded the proposed patches: - Unhide login form on the build.webkit.org - https://bugs.webkit.org/show_bug.cgi?id=88981 - Update buildbot master in autoinstaller to match

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Dan Bernstein
On Jun 12, 2012, at 5:17 PM, Ojan Vafai o...@chromium.org wrote: See https://bugs.webkit.org/show_bug.cgi?id=87772. It's great to use a fuzzer in order to find cases where we're broken and then make reduced layout tests from those. The viewspec-parser tests are themselves just a fuzzer

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Darin Adler
On Jun 12, 2012, at 5:17 PM, Ojan Vafai o...@chromium.org wrote: It's great to use a fuzzer in order to find cases where we're broken and then make reduced layout tests from those. Generally we do require a test each time we fix a bug. So it’s a strategy for the project to always make

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 12:05 PM, Darin Adler da...@apple.com wrote: On Jun 12, 2012, at 5:17 PM, Ojan Vafai o...@chromium.org wrote: It's great to use a fuzzer in order to find cases where we're broken and then make reduced layout tests from those. Generally we do require a test each time

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Darin Adler
On Jun 13, 2012, at 12:12 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Jun 13, 2012 at 12:05 PM, Darin Adler da...@apple.com wrote: On Jun 12, 2012, at 5:17 PM, Ojan Vafai o...@chromium.org wrote: It's great to use a fuzzer in order to find cases where we're broken and then make

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Filip Pizlo
Are we sure that we want to make this a general rule? We have two profitable fuzzers in fast/js that I believe deserve to be in LayoutTests and should be run every time you make any JSC change: LayoutTests/fast/js/dfg-double-vote-fuzz.html LayoutTests/fast/js/dfg-poison-fuzz.html Both are

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Dirk Pranke
I guess I was saying two slightly different things ... 1) I have a strong bias for individual tests that are fast 2) I have a strong bias for individual tests that are simple, focused, easy to understand, and are predictable. All other things being equal (which of course they never are), I would

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Myles C. Maxfield
Thanks for the quick responses and the bug link about fastMalloc(0). In comment 11 https://bugs.webkit.org/show_bug.cgi?id=55097#c11, Eric Seidel says that he was going to start a discussion on webkit-dev, but I haven't been able to find such a conversation (by looking both on gmane and on

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Geoffrey Garen
These tests regularly timeout on the Chromium debug bots and occasionally timeout on the Apple Lion bots. WebKit has a clear policy about this: Tests must be fast enough not to time out. We can fix this issue by making these tests shorter. I don't really see the connection to an abstract

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 12:48 PM, Myles C. Maxfield myles.maxfi...@gmail.com wrote: I don't think that a good solution is to change the interface of ICU and try to upstream a patch to ICU - I think a better solution would be to work around this requirement of ICU inside WebKit. What is exactly

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Myles C. Maxfield
There is still the question of if I can upstream this to ICU, which I'm checking on. In the meantime, Ryosuke Niwa has a good argument for option 3) above. I have uploaded a new patch to https://bugs.webkit.org/show_bug.cgi?id=88936that moves the NULL pointer check to inside the ICU-specific

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Darin Adler
On Jun 13, 2012, at 2:24 PM, Myles C. Maxfield myles.maxfi...@gmail.com wrote: There is still the question of if I can upstream this to ICU, which I'm checking on. I was not proposing changing ICU. In the meantime, Ryosuke Niwa has a good argument for option 3) above. Yes, that’s what I

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 3:27 PM, Darin Adler da...@apple.com wrote: There is still the question of if I can upstream this to ICU, which I'm checking on. I was not proposing changing ICU. I did. In addition to changing WebKit, not using the pointer when the length is zero does not

Re: [webkit-dev] malloc(0)

2012-06-13 Thread Myles C. Maxfield
I started a thread on icu-design (mailing list) about it. As soon as it appears in the archives, I'll post a permalink to the thread. The null pointer check shouldn't matter - if the pointer isn't null, then it's valid anyway :-) --Myles On Wed, Jun 13, 2012 at 3:37 PM, Benjamin Poulain

[webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
Hi all, Because I have infinite patience for bikeshedding, I thought I would send out Yet Another note on the proposed changes to the expectation syntax. Based on the last thread, I'm planning to change ORWT so that it will recognize the syntax in the TestExpectations files and treat any

Re: [webkit-dev] are fuzzer tests appropriate layout tests?

2012-06-13 Thread Maciej Stachowiak
On Jun 13, 2012, at 1:32 PM, Geoffrey Garen gga...@apple.com wrote: These tests regularly timeout on the Chromium debug bots and occasionally timeout on the Apple Lion bots. WebKit has a clear policy about this: Tests must be fast enough not to time out. We can fix this issue by making

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Peter Kasting
On Wed, Jun 13, 2012 at 3:58 PM, Darin Adler da...@apple.com wrote: On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: * we use \ (backslash) as a delimiter instead of : and = Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Ryosuke Niwa
On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.orgwrote: On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: webkit.org/12345 WIN MAC DEBUG \ animations/stop-animation-on-suspend.html \ CRASH TEXT PASS My bikeshedding: -In my opinion, the backslash

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 3:58 PM, Darin Adler da...@apple.com wrote: On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: * we use \ (backslash) as a delimiter instead of : and = Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org wrote: On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: webkit.org/12345 WIN MAC DEBUG \

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Ryosuke Niwa
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org wrote: On Wed, Jun 13, 2012 at 3:53 PM, Dirk Pranke dpra...@chromium.org

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 4:38 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: On Wed, Jun 13, 2012 at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 13, 2012 at 4:12 PM, Benjamin Poulain benja...@webkit.org wrote:

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Benjamin Poulain
On Wed, Jun 13, 2012 at 4:32 PM, Dirk Pranke dpra...@chromium.org wrote: So something like webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html [Crash Text Pass] ? I like that! This seems quite readable to me as well. As mentioned above, I'd be inclined to make the

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Tom Zakrajsek
As long as we're considering TitleCase for the keywords, could we use it to keep all of them as single words? WontFix, SkipCrash, SkipTimeout --Tom On Jun 13, 2012, at 4:46 PM, Dirk Pranke wrote: There's still a distinction between SKIP (temporary) and WONTFIX (permanent until some plan

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
Skip and WontFix have a different purpose than Crash and timeout; the first two (like slow) tell you what to do with the test, and the latter tell you what you expect the test to result in. I don't want to combine them into single tokens because that would cause an explosion of tokens :). --

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Ryosuke Niwa
On Wed, Jun 13, 2012 at 4:55 PM, Tom Zakrajsek t...@codeaurora.org wrote: As long as we're considering TitleCase for the keywords, could we use it to keep all of them as single words? WontFix, SkipCrash, SkipTimeout For skipped tests, it doesn't make sense to have crash, timeout, etc...

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 5:05 PM, Ryosuke Niwa rn...@webkit.org wrote: On Wed, Jun 13, 2012 at 4:55 PM, Tom Zakrajsek t...@codeaurora.org wrote: As long as we're considering TitleCase for the keywords, could we use it to keep all of them as single words? WontFix, SkipCrash, SkipTimeout For

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Maciej Stachowiak
On Jun 13, 2012, at 3:58 PM, Darin Adler da...@apple.com wrote: On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: * we use \ (backslash) as a delimiter instead of : and = Seems worse to me. When I see a backslash I assume it’s a line continuation character or a C

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Dirk Pranke
On Wed, Jun 13, 2012 at 5:42 PM, Maciej Stachowiak m...@apple.com wrote: On Jun 13, 2012, at 3:58 PM, Darin Adler da...@apple.com wrote: On Jun 13, 2012, at 3:53 PM, Dirk Pranke dpra...@chromium.org wrote: * we use \ (backslash) as a delimiter instead of : and = Seems worse to me. When I

Re: [webkit-dev] TestExpectations syntax changes, last call (for a while, at least) ...

2012-06-13 Thread Darin Adler
On Jun 13, 2012, at 4:26 PM, Ryosuke Niwa rn...@webkit.org wrote: So something like webkit.org/12345 [Win Mac Debug] animations/stop-animation-on-suspend.html [Crash Text Pass] ? I like that! Yes, looks good to me too. -- Darin ___ webkit-dev

[webkit-dev] editbugs permission

2012-06-13 Thread Mike Lawther
Hi there, I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has already landed a couple of patches and is helping us triage bugs. thanks! mike ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] editbugs permission

2012-06-13 Thread Dan Bernstein
On Jun 13, 2012, at 9:25 PM, Mike Lawther wrote: Hi there, I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has already landed a couple of patches and is helping us triage bugs. Done ___ webkit-dev mailing list

Re: [webkit-dev] editbugs permission

2012-06-13 Thread Darin Adler
On Jun 13, 2012, at 9:25 PM, Mike Lawther wrote: I'd like to ask for EditBugs permission for dstockw...@chromium.org, who has already landed a couple of patches and is helping us triage bugs. Someone must have seen this and granted permission, because I went to do so and he already had it.