Re: [webkit-dev] Initializing String and AtomicString with literals

On Fri, Aug 24, 2012 at 10:05 PM, Adam Barth wrote: > Thanks! The wiki page is very helpful. I wonder if we should > organize a hack-a-thon to deploy this pattern throughout WebKit. Is > there a way the compiler could give us a list of all the code location > we should update? > We may discov

Re: [webkit-dev] Initializing String and AtomicString with literals

On Fri, Aug 24, 2012 at 10:18 PM, Adam Barth wrote: > [[[ > The difference between the version is if the length of the string is > included or not. Having the size given in the constructor makes the > constructor faster. Having the size also makes the code bigger, which > is a problem when the co

Re: [webkit-dev] Initializing String and AtomicString with literals

On Aug 24, 2012, at 10:18 PM, Adam Barth wrote: > The wiki page says: > > [[[ > The difference between the version is if the length of the string is > included or not. Having the size given in the constructor makes the > constructor faster. Having the size also makes the code bigger, which > is

Re: [webkit-dev] Initializing String and AtomicString with literals

The wiki page says: [[[ The difference between the version is if the length of the string is included or not. Having the size given in the constructor makes the constructor faster. Having the size also makes the code bigger, which is a problem when the code is executed infrequently. ]]] That desc

Re: [webkit-dev] Initializing String and AtomicString with literals

What's the difference between the ASCIILiteral and ConstructFromLiteral versions? - Maciej On Aug 24, 2012, at 8:00 PM, Benjamin Poulain wrote: > Dear webkit-dev, > > > Some recent changes improved the way we can use string classes with literals. > > There are 3 new constructors for initi

Re: [webkit-dev] Initializing String and AtomicString with literals

Thanks! The wiki page is very helpful. I wonder if we should organize a hack-a-thon to deploy this pattern throughout WebKit. Is there a way the compiler could give us a list of all the code location we should update? Adam On Fri, Aug 24, 2012 at 8:00 PM, Benjamin Poulain wrote: > Dear webki

[webkit-dev] Initializing String and AtomicString with literals

Dear webkit-dev, Some recent changes improved the way we can use string classes with literals. There are 3 new constructors for initializing a string from a literal: -String(ASCIILIteral): http://trac.webkit.org/browser/trunk/Source/WTF/wtf/text/WTFString.h#L139 -String(const char[], ConstructFr

[webkit-dev] [WK2] WebContext destructor is never triggered on normal exit

Hi, I've found WebContext destructor is never triggered on normal exit in WK2. This happens because only IPC message from WebProcess could terminate it but won't do that in this case. One possibility for doing this is to create a flow of termination from UIProcess on exit. But, before startin

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

On 08/24/2012 06:49 PM, Ojan Vafai wrote: On Fri, Aug 24, 2012 at 4:42 AM, Žan Doberšek > wrote: On Fri, Aug 24, 2012 at 4:35 AM, Dominik Röttsches mailto:dominik.rottsc...@intel.com>> wrote: Hi Dirk, On 08/22/2012 10:49 PM, Dirk Prank

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

On Fri, Aug 24, 2012 at 4:42 AM, Žan Doberšek wrote: > On Fri, Aug 24, 2012 at 4:35 AM, Dominik Röttsches < > dominik.rottsc...@intel.com> wrote: > >> Hi Dirk, >> >> >> On 08/22/2012 10:49 PM, Dirk Pranke wrote: >> >>> The Chromium canaries now exit after 5000 failures or 1000 >>> crashes/timeout

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

You can mark the failing tests as failing tests or skip them in TestExpectations/Skipped with the change. And then you can rebase and unskip them without disturbing the bot. Dominik Röttsches írta: Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000 fai

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

On Fri, Aug 24, 2012 at 4:35 AM, Dominik Röttsches < dominik.rottsc...@intel.com> wrote: > Hi Dirk, > > > On 08/22/2012 10:49 PM, Dirk Pranke wrote: > >> The Chromium canaries now exit after 5000 failures or 1000 >> crashes/timeouts. >> >> > Can the failure limit be increased to 1 for example?

Re: [webkit-dev] Subpixel layout - requesting help for big rebaseline

Hi Dirk, On 08/22/2012 10:49 PM, Dirk Pranke wrote: The Chromium canaries now exit after 5000 failures or 1000 crashes/timeouts. Can the failure limit be increased to 1 for example? Levi/Emil were saying the rebaseline touches about 8000 cases. Otherwise we'd have to go through a more c

Re: [webkit-dev] RenderStyleConstants.h - enum naming conventions?

On Fri, Aug 24, 2012 at 3:06 PM, Glenn Adams wrote: > [or if there is a name conflict on LineBreak, then will use LineBreakType] > (whether the suffice 'Type' is included also seems somewhat irregular) > s/suffice/suffix/ ___ webkit-dev mailing list we

Re: [webkit-dev] RenderStyleConstants.h - enum naming conventions?

On Fri, Aug 24, 2012 at 2:58 PM, Eric Seidel wrote: > Sorry, I was unclear. I haven't seen someone create a new enum using > E in years. LineBreakType or similar would be better than > ELineBreakType. > > > On Thu, Aug 23, 2012 at 11:53 PM, Glenn Adams wrote: > >> enum LineBreak { LineBreakAut