Re: [webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-15 Thread Maciej Stachowiak
On Nov 15, 2012, at 4:56 PM, Ryosuke Niwa wrote: > On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther wrote: > On 16 November 2012 09:59, Ryosuke Niwa wrote: > > While I don’t want to further agitate the issue or go off on a tangent, and > agree that we must address the security aspect before get

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Chris Evans
On Thu, Nov 15, 2012 at 3:05 PM, Maciej Stachowiak wrote: > > I had a few more thoughts on this email besides the fragmentation aspect. > > On Nov 15, 2012, at 12:22 AM, Chris Evans wrote: > > >> It still seems to me like the key difference is vtable vs no vtable, >> > > It's an important differ

Re: [webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-15 Thread Ryosuke Niwa
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther wrote: > On 16 November 2012 09:59, Ryosuke Niwa wrote: > >> >> While I don’t want to further agitate the issue or go off on a tangent, >> and agree that we must address the security aspect before getting rid of >> RenderArena, only WebKit reviewers c

Re: [webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-15 Thread Adam Barth
On Thu, Nov 15, 2012 at 4:28 PM, Mike Lawther wrote: > On 16 November 2012 09:59, Ryosuke Niwa wrote: >> While I don’t want to further agitate the issue or go off on a tangent, >> and agree that we must address the security aspect before getting rid of >> RenderArena, only WebKit reviewers can r-

[webkit-dev] r- your own patches [was: Re: RenderArena: Teaching an old dog new tricks]

2012-11-15 Thread Mike Lawther
On 16 November 2012 09:59, Ryosuke Niwa wrote: > > While I don’t want to further agitate the issue or go off on a tangent, > and agree that we must address the security aspect before getting rid of > RenderArena, only WebKit reviewers can r- patches written by other > contributors. You’re not eve

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Maciej Stachowiak
On Nov 15, 2012, at 2:59 PM, Ryosuke Niwa wrote: > On Thu, Nov 15, 2012 at 2:16 PM, Chris Evans wrote: > On Thu, Nov 15, 2012 at 11:49 AM, Geoffrey Garen wrote: > On Nov 14, 2012, at 3:19 PM, Chris Evans wrote: > >> A first step might be to make it a platform define. For the Chromium >> pla

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Maciej Stachowiak
I had a few more thoughts on this email besides the fragmentation aspect. On Nov 15, 2012, at 12:22 AM, Chris Evans wrote: > > It still seems to me like the key difference is vtable vs no vtable, > > It's an important difference, but if we partitioned in to two based on that > difference alo

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Ryosuke Niwa
On Thu, Nov 15, 2012 at 2:16 PM, Chris Evans wrote: > On Thu, Nov 15, 2012 at 11:49 AM, Geoffrey Garen wrote: > >> On Nov 14, 2012, at 3:19 PM, Chris Evans wrote: >> >> A first step might be to make it a platform define. For the Chromium >> platform we'd leave the define "on" -- there are some

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Maciej Stachowiak
On Nov 15, 2012, at 2:16 PM, Chris Evans wrote: > On Thu, Nov 15, 2012 at 11:49 AM, Geoffrey Garen wrote: > On Nov 14, 2012, at 3:19 PM, Chris Evans wrote: > >> A first step might be to make it a platform define. For the Chromium >> platform we'd leave the define "on" -- there are some nice

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Chris Evans
On Thu, Nov 15, 2012 at 11:49 AM, Geoffrey Garen wrote: > On Nov 14, 2012, at 3:19 PM, Chris Evans wrote: > > A first step might be to make it a platform define. For the Chromium > platform we'd leave the define "on" -- there are some nice security > properties we get from having the RenderObjec

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Geoffrey Garen
On Nov 14, 2012, at 3:27 PM, Ojan Vafai wrote: > As someone outside all these discussions, this seems like a completely unfair > characterization of what happened. Sam voiced an objection, then there was a > bunch of discussion in which Chris made an argument that Eric found > compelling. Many

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Geoffrey Garen
On Nov 14, 2012, at 3:19 PM, Chris Evans wrote: > A first step might be to make it a platform define. For the Chromium platform > we'd leave the define "on" -- there are some nice security properties we get > from having the RenderObjects in their own spot. I'm happy to go in to more > details

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Oliver Hunt
Since a common theme people are bringing up is vtable overrides, I do recall reading about vtable masking being available in some compilers. I'm wondering if we should push for support for such in compilers we use - I'm not sure what the vcall perf hit is in such cases, but it would knock kill

Re: [webkit-dev] PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet

2012-11-15 Thread Brady Eidson
It sounds like you meant to go to https://bugs.webkit.org/ and file a bug. Thanks, ~Brady On Nov 15, 2012, at 1:13 AM, HIDEKI YOSHIDA wrote: > Hi, > > PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 > tablet. > > Version:Safari 5.1.7(7534.57.2) > > Does anyone know

Re: [webkit-dev] Porting WebKit To a new graphic backend.

2012-11-15 Thread zhang jipeng
, Dominik Röttsches wrote: On 11/14/2012 07:24 AM, ZhangJiPeng wrote: The idea came from an embedded browser development project. Benjamin I want to porting WebKit to a new platform, the platform can only provide video address programming interface. So I need to porting DirectFB, Cairo, GTK an

Re: [webkit-dev] Porting WebKit To a new graphic backend.

2012-11-15 Thread Dominik Röttsches
On 11/14/2012 07:24 AM, ZhangJiPeng wrote: The idea came from an embedded browser development project. Benjamin I want to porting WebKit to a new platform, the platform can only provide video address programming interface. So I need to porting DirectFB, Cairo, GTK and so on. However the hardwar

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Chris Evans
On Thu, Nov 15, 2012 at 12:34 AM, Elliott Sprehn wrote: > > On Thu, Nov 15, 2012 at 3:22 AM, Chris Evans wrote: > >> >>> ... >>> >> >> My read on the Arena is that it's fragmentation resistant (i.e. it will >> not repurpose a larger free chunk to satisfy a smaller allocation.) >> However, memory

[webkit-dev] PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet

2012-11-15 Thread HIDEKI YOSHIDA
Hi, PAN(flick) to left operation collapse screen in Webkit(Safari) on window7 tablet. Version:Safari 5.1.7(7534.57.2) Does anyone know this problem and the patch to resolve? How to reproduce. 1) Launch Safai on Windows tablet. Set its window's width less than 960px. 2) Open http://jquerymobile

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Maciej Stachowiak
On Nov 15, 2012, at 12:22 AM, Chris Evans wrote: > On Wed, Nov 14, 2012 at 11:32 PM, Maciej Stachowiak wrote: > > On Nov 14, 2012, at 11:09 PM, Chris Evans wrote: > >> On Wed, Nov 14, 2012 at 8:59 PM, Ryosuke Niwa wrote: >> On Wed, Nov 14, 2012 at 8:52 PM, Elliott Sprehn wrote: >> I was pr

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Ryosuke Niwa
On Thu, Nov 15, 2012 at 12:22 AM, Chris Evans wrote: > On Wed, Nov 14, 2012 at 11:32 PM, Maciej Stachowiak wrote: > >> rather than DOM vs. not DOM. Also having a per-document arena for DOM >> nodes (as is done for render objects via RenderArena) seems irrelevant to >> the security goal and likel

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Elliott Sprehn
On Thu, Nov 15, 2012 at 3:22 AM, Chris Evans wrote: > >> ... >> > > My read on the Arena is that it's fragmentation resistant (i.e. it will > not repurpose a larger free chunk to satisfy a smaller allocation.) > However, memory usage at any given time is defined by peak usage since it > cannot re

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Maciej Stachowiak
On Nov 15, 2012, at 12:02 AM, Ryosuke Niwa wrote: > On Wed, Nov 14, 2012 at 11:37 PM, Chris Evans wrote: > On Wed, Nov 14, 2012 at 10:29 PM, Ryosuke Niwa wrote: > In other words, why are you interested in using the proposed allocation > mechanism for only DOM nodes/objects instead of everythi

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Chris Evans
On Wed, Nov 14, 2012 at 11:32 PM, Maciej Stachowiak wrote: > > On Nov 14, 2012, at 11:09 PM, Chris Evans wrote: > > On Wed, Nov 14, 2012 at 8:59 PM, Ryosuke Niwa wrote: > >> On Wed, Nov 14, 2012 at 8:52 PM, Elliott Sprehn wrote: >> >>> I was present for one of the discussions about the exploit

Re: [webkit-dev] RenderArena: Teaching an old dog new tricks

2012-11-15 Thread Ryosuke Niwa
On Wed, Nov 14, 2012 at 11:37 PM, Chris Evans wrote: > On Wed, Nov 14, 2012 at 10:29 PM, Ryosuke Niwa wrote: > In other words, why are you interested in using the proposed allocation >> mechanism for only DOM nodes/objects instead of everything in >> WebCore/WebKit? >> > > The challenge is to ad