Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-22 Thread Glenn Adams
On Fri, Mar 22, 2013 at 3:07 PM, Ryosuke Niwa wrote: > > Landed it in http://trac.webkit.org/changeset/146657. Once EWS bots catch > up, we can start grabbing both text and pixel results off of Chromium and > Mac EWS bots. > Thanks, this will be very useful! _

[webkit-dev] PSA: run-webkit-tests now generates pixel results in retry

2013-03-22 Thread Ryosuke Niwa
Hi all, I've made a change to NRWT in http://trac.webkit.org/changeset/146657 so that it always generate pixel results in retries even when pixel tests are disabled by default (on all but Chromium ports). We now enable pixel tests while we're retrying tests and generate -expected.png results. Th

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-22 Thread Ryosuke Niwa
On Fri, Mar 22, 2013 at 1:12 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 1:57 AM, Ryosuke Niwa wrote: > >> On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: >> >>> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >>> I used to pull results from the bots where possible but creating >

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-22 Thread Tim Horton
On Mar 22, 2013, at 1:34 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer > wrote: > On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: > On Mar 21

Re: [webkit-dev] Please don't land patches without rebaselining tests for at least one platform

2013-03-22 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 6:43 PM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 6:39 PM, Silvia Pfeiffer wrote: > >> On Fri, Mar 22, 2013 at 12:30 PM, Ryosuke Niwa wrote: >> >>> On Thu, Mar 21, 2013 at 6:05 PM, Maciej Stachowiak wrote: >>> On Mar 21, 2013, at 5:38 PM, Glenn Adams wrote: >>>

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Eric Seidel
Perhaps useful to you: http://neugierig.org/software/chromium/bloat/ On Fri, Mar 22, 2013 at 12:06 PM, Elliott Sprehn wrote: > I'd be really interesting to see what patches are causing the growth and by > how much. I wonder how much of this is from some of the fancier template > things we have (e

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Elliott Sprehn
I'd be really interesting to see what patches are causing the growth and by how much. I wonder how much of this is from some of the fancier template things we have (ex. the 600 template expansions from StyleBuilder) On Fri, Mar 22, 2013 at 5:22 AM, Eric Seidel wrote: > It seems like it should b

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Eric Seidel
It seems like it should be trivial to set up an EWS bot to track size changes. It would (sadly) need to clobber, as my understanding is that incremental builds are not deterministic in their sizes: https://code.google.com/p/chromium/issues/detail?id=110002 (our bug about this for Chromium Try serv

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Benjamin Poulain
On Fri, Mar 22, 2013 at 12:12 AM, Ryosuke Niwa wrote: > WebKit nightly build for r135421 dated November 21st, 2012 was 46.1MB. > WebKit nightly build for r145786 dated March 13th, 2013 was 49.4MB. > > Our binary size increased by 7.2% in just 4 months. > I have been tracking this issue for a bit

Re: [webkit-dev] Please don't leave entries for rebaseline in TestExpectation files

2013-03-22 Thread Ryosuke Niwa
On Thu, Mar 21, 2013 at 1:57 AM, Ryosuke Niwa wrote: > On Thu, Mar 21, 2013 at 1:31 AM, Robert Hogan wrote: > >> On Thursday, 21 March 2013, Ryosuke Niwa wrote: >> >>> I used to pull results from the bots where possible but creating inconsistency between png/text results is not good. >>

Re: [webkit-dev] Ever increasing binary size

2013-03-22 Thread Ryosuke Niwa
On Fri, Mar 22, 2013 at 12:12 AM, Ryosuke Niwa wrote: > > WebKit nightly build for r135421 dated November 21st, 2012 was 46.1MB. > WebKit nightly build for r145786 dated March 13th, 2013 was 49.4MB. > Correction: r146449 dated March 21st, 2013. ___ webk

[webkit-dev] Ever increasing binary size

2013-03-22 Thread Ryosuke Niwa
Hi, WebKit nightly build for r135421 dated November 21st, 2012 was 46.1MB. WebKit nightly build for r145786 dated March 13th, 2013 was 49.4MB. Our binary size increased by 7.2% in just 4 months. Is this a problem? I think it is. It means that we use more RAM when WebKit is loaded onto memory. I