Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Mario Sanchez Prada
Hi, For the sake of completeness, I'd like to mention that this feature is also used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale from Opera already pointed out in a recent discussion[1]. That, together with what it was mentioned about the SmartTV Alliance using it, means

[webkit-dev] CSS Regions and multi-range Selection

2013-07-25 Thread Javier Fernandez
hi, During the last Contributors Meeting there was a discussion about how to improve the Selection when using CSS Regions. These are some of the conclusions got at that meeting: * multi-range selection would help with this. * come up with a better way to do selection that would allow a

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Kyounga Ra
Hi, First, I filed up my new patch based on the latest webkit without new feature-name even though this discussion wasn't concluded. If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS, I'll make a new patch. If this feature is widely used in TV industry and is included in

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Mario Sanchez Prada
Hi Kyounga, [...] First, I filed up my new patch based on the latest webkit without new feature-name even though this discussion wasn't concluded.  I did not find any patch in bugzilla for bug 66027 newer than the one from Jan 2012 when I started doing the experiments, so that's why I came up

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Antonio Gomes
Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there is no objections, please proceed and guard it behind a build flag. Cheers, On

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Glenn Adams
On Tue, Jul 23, 2013 at 12:17 AM, Kyounga Ra kyounga...@gmail.com wrote: Hi webkit-dev! I'd like to add new feature for CSS nav-[dir] properties. https://bugs.webkit.org/show_bug.cgi?id=66027 This feature is for http://dev.w3.org/csswg/css3-ui/#nav-dir On recent discussion, these nav-*

[webkit-dev] FTL merge (and subsequent mayhem)

2013-07-25 Thread Oliver Hunt
(I meant to send this last night, so many apologies for the delay) Last night I merged over the FTL branch to trunk, currently the FTL itself is guarded by ENABLE_FTL_JIT and HAVE_LLVM guards, however the branch does bring in a lot of general improvements to JSC's existing execution engines.

[webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Thiago Lacerda
Hi, We in the Nix port team (which is going upstream), are facing an issue that we need our WebView to know when the page transition has begun. There was callback, in PageClient, that was making a similar job, called didCommitLoadForMainFrame, but it was removed recently. WebPage does have a

Re: [webkit-dev] FTL merge (and subsequent mayhem)

2013-07-25 Thread Allan Sandfeld Jensen
On Thursday 25 July 2013, Oliver Hunt wrote: I would like to apologise to the maintainers of those platforms that I destroyed, and offer my heart felt thanks to those who have already started getting the builds running. I will be available all day today if help is needed, but to my knowledge

Re: [webkit-dev] Introduce RecursionGuard to prevent recursive calls to a function

2013-07-25 Thread Darin Adler
I like the idea of this class, but I think the proposal needs a little refinement. My first two thoughts: The name of the class should make it clear it’s only an assertion, not a guard that has an effect on non-debug builds. And we should figure out how to deal with the issue that these data

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which is going upstream), are facing an issue that we need our WebView to know when the page transition has begun. There was callback, in PageClient, that was making a similar

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Brady Eidson
On Jul 25, 2013, at 10:10 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi Brady On Thu, Jul 25, 2013 at 1:48 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 9:08 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi, We in the Nix port team (which is

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Thiago Lacerda
On Thu, Jul 25, 2013 at 2:34 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 10:10 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: Hi Brady On Thu, Jul 25, 2013 at 1:48 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 9:08 AM, Thiago Lacerda

Re: [webkit-dev] Notifying PageClient when page transition has begun

2013-07-25 Thread Thiago Lacerda
On Thu, Jul 25, 2013 at 3:56 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 11:28 AM, Thiago Lacerda thiago.lace...@openbossa.org wrote: On Thu, Jul 25, 2013 at 2:34 PM, Brady Eidson beid...@apple.com wrote: On Jul 25, 2013, at 10:10 AM, Thiago Lacerda

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Martin Robinson
On Thu, Jul 25, 2013 at 7:01 AM, Antonio Gomes toniki...@webkit.org wrote: Given that we have a port shipping it (GTK), and usage and interest from on the TV industry and that Opera is working hard to get it included to CSS3 UI spec, it looks good to me for implementing this feature. If there

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Antonio Gomes
Ah, thanks for clarifying. That changes the scenario then. Question is back to open: is there any port that would be willing to have this feature's build flag ON by default? Cheers, On Thu, Jul 25, 2013 at 3:38 PM, Martin Robinson mrobin...@webkit.org wrote: On Thu, Jul 25, 2013 at 7:01 AM,

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Kyounga Ra
Hi Mario, Thanks for your kind comments in detail. I would be very thankful for you to do that work (using/maintaining this feature) for WebKitGTK+ port. Of course, it helps to enhance first patch's quality. (Please keep my comment. Copyright (C) 2013 Alticast Corporation. All rights reserved.

Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to WebCore.

2013-07-25 Thread Kyounga Ra
I'm working with WebKit on Linux and will use and maintain on my WebKit. It could be meaningful as one of the WebKit ports? -Kyounga 2013/7/26 Antonio Gomes toniki...@webkit.org Ah, thanks for clarifying. That changes the scenario then. Question is back to open: is there any port that would