[webkit-dev] Windows (Temporary) Build Turmoil

2014-07-09 Thread Brent Fulgham
If you don’t care about building WebKit on Windows, you can stop reading now! Still here? Okay: I’m attempting to make the Windows build rely less on the Cygwin tool chain. There are a number of reasons for this, but one of the major benefits I hope to derive is to reduce the amount of effort

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 7:25 PM, Maciej Stachowiak wrote: > > On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote: > > On Wednesday, July 9, 2014, Brady Eidson wrote: > >> >> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote: >> >> Again, im not requesting anything new here. The consensus on webkit-de

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 5:05 PM, Brady Eidson wrote: > On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote: > > Since webkitbot doesn't automatically post the details as to what failures > the patch caused, and one line description is almost never adequate (e.g. > needs a hyperlink to buildbot page, t

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Maciej Stachowiak
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote: > > On Wednesday, July 9, 2014, Brady Eidson wrote: > >> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote: >> >> Again, im not requesting anything new here. The consensus on webkit-dev has >> been to ping the author/reviewer on IRC or via ema

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
> On Jul 9, 2014, at 4:45 PM, Ryosuke Niwa wrote: > > On Wednesday, July 9, 2014, Brady Eidson wrote: > >> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote: >> >> Again, im not requesting anything new here. The consensus on webkit-dev has >> been to ping the author/reviewer on IRC or via ema

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wednesday, July 9, 2014, Brady Eidson wrote: > > On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa > wrote: > > Again, im not requesting anything new here. The consensus on webkit-dev > has been to ping the author/reviewer on IRC or via email and comment in the > original bug PRIOR to using webkitbot

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
> On Jul 9, 2014, at 4:15 PM, Ryosuke Niwa wrote: > > Again, im not requesting anything new here. The consensus on webkit-dev has > been to ping the author/reviewer on IRC or via email and comment in the > original bug PRIOR to using webkitbot to start reverting the patch. I went through the

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wednesday, July 9, 2014, Ryosuke Niwa wrote: > > On Wednesday, July 9, 2014, Brady Eidson > wrote: > >> >> On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa wrote: >> >> >> When the bug for a rollout is created, the original bug is automatically >>> reopened. >>> >>> >>> Which makes sense when a patc

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wednesday, July 9, 2014, Brady Eidson wrote: > > On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa > wrote: > > > When the bug for a rollout is created, the original bug is automatically >> reopened. >> >> >> Which makes sense when a patch breaks something, whether the resolution >> is the author foll

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
> On Jul 9, 2014, at 1:43 PM, Ryosuke Niwa wrote: >> When the bug for a rollout is created, the original bug is automatically >> reopened. > > Which makes sense when a patch breaks something, whether the resolution is > the author following up with a fix *or* the rollout committing.’ > > Thi

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Dan Bernstein
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote: > > When the bug for a rollout is created, the original bug is automatically > reopened. This is a long-standing bug in the bot. The original bug should not be reopened until the change that fixed it is reverted. __

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 1:44 PM, Simon Fraser wrote: > > On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote: > > On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote: > >> >> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: >> >> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton >> wrote: >> >>> >>> On Ju

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote: > On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote: > >> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: >> >> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote: >> >>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: >>> >>> >>> C

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 1:35 PM, Brady Eidson wrote: > > On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote: > > On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote: > >> >> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: >> >> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton >> wrote: >> >>> >>> On Ju

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
> On Jul 9, 2014, at 1:15 PM, Ryosuke Niwa wrote: > > On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote: > >> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: >> >> On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote: >> >>> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: >>> >>> >

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 1:08 PM, Brady Eidson wrote: > > On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: > > On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton > wrote: > >> >> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: >> >> >> Could we teach webkitbot to do an appropriate notification wi

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Brady Eidson
> On Jul 9, 2014, at 12:39 PM, Ryosuke Niwa wrote: > > On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote: > >> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: >> >> >> Could we teach webkitbot to do an appropriate notification with a waiting >> period? Either as part of rollout or ad

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
On Wed, Jul 9, 2014 at 12:35 PM, Tim Horton wrote: > > On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: > > > Could we teach webkitbot to do an appropriate notification with a waiting > period? Either as part of rollout or add a new command to do it. > > > It already does. The "waiting peri

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Tim Horton
> On Jul 9, 2014, at 12:10 PM, Maciej Stachowiak wrote: > > > Could we teach webkitbot to do an appropriate notification with a waiting > period? Either as part of rollout or add a new command to do it. It already does. The “waiting period” is defined by when the person who asked for the rol

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Maciej Stachowiak
Could we teach webkitbot to do an appropriate notification with a waiting period? Either as part of rollout or add a new command to do it. - Maciej > On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa wrote: > > Yes. The point is to do these things before telling webkitbot to rollout a > patch. >

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
With any waiting period before actually rolling out? Simon On Jul 9, 2014, at 11:40 AM, Ryosuke Niwa wrote: > Yes. The point is to do these things before telling webkitbot to rollout a > patch. > > - R. Niwa > > > On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser wrote: > On Jul 9, 2014, at 7

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
Yes. The point is to do these things before telling webkitbot to rollout a patch. - R. Niwa On Wed, Jul 9, 2014 at 11:07 AM, Simon Fraser wrote: > On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa wrote: > > Hi all, > > This is a friendly remainder that you should > >- comment on the associated b

Re: [webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Simon Fraser
On Jul 9, 2014, at 7:43 AM, Ryosuke Niwa wrote: > Hi all, > > This is a friendly remainder that you should > comment on the associated bug > email the patch author and the reviewer who reviewed the patch > before rolling out / reverting a patch. If you use webkitbot to roll out, is this necessa

[webkit-dev] Comment on the bug & email author/reviewer before reverting a patch

2014-07-09 Thread Ryosuke Niwa
Hi all, This is a friendly remainder that you should - comment on the associated bug - email the patch author and the reviewer who reviewed the patch before rolling out / reverting a patch. - R. Niwa ___ webkit-dev mailing list webkit-dev@lists.

[webkit-dev] Inactive Committers and Reviewers

2014-07-09 Thread Ryosuke Niwa
Hello WebKittens, WebKit reviewers recently had a discussion about the large number of inactive committers and reviewers left after the Blink fork, and we've come to introduce a new policy to consider committers and reviewers who have not contributed to the project over one year "*inactive*". In