Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Dean Jackson
Just answering this bit because the consensus seems to be to go for the single header file. > On 7 Aug 2014, at 9:57 pm, Laszlo Gombos wrote: > > > While FeatureDefines.h says "Use this file to list _all_ ENABLE() macros" > > it also says "The feature defaults in this file are only taken into

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Mark Rowe
> On Aug 7, 2014, at 09:36, Maciej Stachowiak wrote: > >> >> On Aug 6, 2014, at 2:22 PM, Dean Jackson wrote: >> >> Hi floks, >> >> Things are a bit confusing in the OS X and iOS build configurations because >> we have both a FeatureDefines.h and a set of .xcconfig files, often defining >>

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Filip Pizlo
> On Aug 7, 2014, at 9:36 AM, Maciej Stachowiak wrote: > >> >> On Aug 6, 2014, at 2:22 PM, Dean Jackson wrote: >> >> Hi floks, >> >> Things are a bit confusing in the OS X and iOS build configurations because >> we have both a FeatureDefines.h and a set of .xcconfig files, often defining >

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Maciej Stachowiak
> > > (*) I think Apple's Windows port should probably continue with > FeatureDefines.h because it doesn't use Xcode. BTW, the canonical place (I think) for feature flags for the Windows port is in WebKitLibraries/win/tools/vsprops. Confusion about where the feature flag settings go for diff

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Maciej Stachowiak
> On Aug 6, 2014, at 2:22 PM, Dean Jackson wrote: > > Hi floks, > > Things are a bit confusing in the OS X and iOS build configurations because > we have both a FeatureDefines.h and a set of .xcconfig files, often defining > the same thing, and sometimes inconsistently (or at least I've made

Re: [webkit-dev] Heads up: Incremental build issue on cmake (GTK/EFL) ports

2014-08-07 Thread Ryosuke Niwa
Mac port uses start-queue-mac script that periodically triggers a clean build. Perhaps you guys can try using that as well. It's located in http://trac.webkit.org/browser/trunk/Tools/EWSTools On Wednesday, August 6, 2014, Gyuyoung Kim wrote: > Hello Ossy, > > Thank you. I also restart efl ews w

Re: [webkit-dev] FeatureDefines.h and .xcconfig

2014-08-07 Thread Laszlo Gombos
Hi, I think all ports have the very same problem, not just the OS X and iOS port. Each port need to make a decision if the build system is in control of the complete ENABLE_FEATURE_NAME set of flags or it delegates some of the defaults to FeatureDefines.h. I think it would be desired that all port

Re: [webkit-dev] ftlopt merge - basically done

2014-08-07 Thread Sergio Villar Senin
On 06/08/14 23:35, Filip Pizlo wrote: > Hi everyone, > > The JSC “ftlopt” branch is basically merged. I think I have one more > revision to merge over, and it is a minor one. Please don’t land more things > on the branch. Landing on trunk is fine; it’s unlikely to get in my way as I > merge