On Mon, Feb 23, 2015 at 4:48 PM, Alex Christensen
wrote:
> > Does it matter the function is defined in a header file or that it's an
> inline?
>
> If a function is always inlined that would also cause a problem if the
> linker tried to export a symbol from an object file, but most of those are
>
> Does it matter the function is defined in a header file or that it's an
> inline?
If a function is always inlined that would also cause a problem if the linker
tried to export a symbol from an object file, but most of those are defined in
headers.
On Mon, Feb 23, 2015 at 2:43 PM, Alex Christensen
wrote:
> Last week I switched the iOS and Mac builds to use WEBCORE_EXPORT instead
> of WebCore.exp.in. This should make maintenance easier, but there are a
> few quirks everybody should be aware of:
>
> 1) Do not use WEBCORE_EXPORT before a func
They also seem like prime candidates for stylebot rules.
> On Feb 23, 2015, at 3:31 PM, Darin Adler wrote:
>
> Hooray!
>
> Lets document these somewhere so people don’t have to read the webkit-dev
> archives to learn these rules. Maybe in the header that defines
> WEBCORE_EXPORT? Maybe in a w
Hooray!
Lets document these somewhere so people don’t have to read the webkit-dev
archives to learn these rules. Maybe in the header that defines WEBCORE_EXPORT?
Maybe in a webpage somewhere on webkit.org?
— Darin
___
webkit-dev mailing list
webkit-de
Last week I switched the iOS and Mac builds to use WEBCORE_EXPORT instead of
WebCore.exp.in. This should make maintenance easier, but there are a few
quirks everybody should be aware of:
1) Do not use WEBCORE_EXPORT before a function defined in a header. This will
cause check-for-weak-vtables
> Over the past few weeks I’ve spent a considerable amount of time reviewing
> and correcting a number of problems with the Windows testing infrastructure.
>
> We were skipping thousands of tests, including Accessibility, http tests,
> and large sections of forms, css, and svg tests. Some tests wer
7 matches
Mail list logo