[webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-07 Thread Darin Adler
Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past? Should we use #if or [Conditional]? See for example, HTMLMediaElement.idl, which has a mix of both styles. It’s pretty ugly how the #if look in the IDL files, but even worse is a

Re: [webkit-dev] WorkQueue for Windows?

2015-03-07 Thread Antti Koivisto
On Sat, Mar 7, 2015 at 9:02 PM, Brent Fulgham bfulg...@gmail.com wrote: Hi Antti, Take a look at https://bugs.webkit.org/show_bug.cgi?id=142432. I haven't landed this yet, because I was hoping to get some kind of test for this. However, it seems to introduce no problems, so we could go ahead

Re: [webkit-dev] WorkQueue for Windows?

2015-03-07 Thread Brent Fulgham
Hi Antti, Take a look at https://bugs.webkit.org/show_bug.cgi?id=142432. I haven't landed this yet, because I was hoping to get some kind of test for this. However, it seems to introduce no problems, so we could go ahead and land it. Question: why do we have a separate WorkQueue implementation

[webkit-dev] Image save and repainting inside webkit

2015-03-07 Thread ankit srivastav
Hi Max Thanks for your reply. But may be you took the question into a different direction. We are trying to make changes into Webkit code, so that the functionality works for each and every application/Webpage. We have to achieve two things: 1) An event {from within the webkit} when the whole

Re: [webkit-dev] [Conditional=] vs. #if in IDL files

2015-03-07 Thread Ryosuke Niwa
On Sat, Mar 7, 2015 at 8:55 AM, Darin Adler da...@apple.com wrote: Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past? I think Conditional is a nicer/newer way of if-defing based on feature flags. Should we use #if or