Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

On Aug 21, 2015, at 12:11 PM, Michael Catanzaro mcatanz...@igalia.com wrote: On Wed, 2015-08-19 at 13:08 -0700, Filip Pizlo wrote: TL;DR. Don’t use WTF::SpinLock, WTF::Mutex, std::mutex, WTF::ThreadCondition, std::condition_variable, or std::condition_variable_any. They waste CPU time

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

Hi Filip, very interesting to see you change out such a fundamental algorithm! It's amazing that it works. Reading the code, it seems very comparable to Windows' critical sections [1]. Is that the case? Looking at github and msdn, 4000 seems to be the most common number of spins. I believe your

Re: [webkit-dev] PSA: you should use WTF::Lock and WTF::Condition instead of WTF::SpinLock, WTF::Mutex, WTF::ThreadCondition, std::mutex, std::condition_variable, or std::condition_variable_any

On Wed, 2015-08-19 at 13:08 -0700, Filip Pizlo wrote: TL;DR. Don’t use WTF::SpinLock, WTF::Mutex, std::mutex, WTF::ThreadCondition, std::condition_variable, or std::condition_variable_any. They waste CPU time and they waste memory. Use WTF::Lock and WTF::Condition instead. Hi, I recommend

[webkit-dev] WinCairo Stability

Hi, I grabbed the latest WinCairo (r188436) a few days ago and did a few tests with the debug build. I've only tried a small selection of pages but I'm seeing frequent asserts/crashes, for example see the attached callstacks from espn.com, facebook.com and html5test.com. Are these known

Re: [webkit-dev] WinCairo Stability

Thanks Darin, I've got my release build up now which is sufficient to do some more verification that I wanted to do. I hadn't known about the build dashboard, that will be a handy tool for me in the future. Chris -Original Message- From: Darin Adler [mailto:da...@apple.com] Sent:

Re: [webkit-dev] WinCairo Stability

These all look like backtraces from assertion failures. If you are working on WebKit, the next step would be to figure out which assertion is failing. If you’re looking for greater stability, you could try a release build instead of a debug build, which won’t include the assertions. I’m not

Re: [webkit-dev] WinCairo Stability

Alex Christensen does keep the WinCairo port up and running, and we have a build bot that tracks that. Unfortunately, we don’t have an active WinCairo test bot, so it’s not always possible to know when something is broken in a subtle way on that port. Please let us know what you find out!