Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Konstantin Tokarev
10.02.2016, 05:41, "Eric Wing" : > On 2/7/16, Konstantin Tokarev wrote: >>  Please try updated version of my branch, it now does not use LLVM unless you >>  enable USE_LLVM_DISASSEMBLER. > > I merged your branch. That seemed to build and work. > So what

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Darin Adler
> On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: > > 10.02.2016, 05:41, "Eric Wing" : >> - I don't know what parts JSC actually needs to know what I can safely remove > > I second this request, it would be great if WebKit had a documentation which

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Konstantin Tokarev
10.02.2016, 20:10, "Filip Pizło" : >>  On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: >> >>  10.02.2016, 05:41, "Eric Wing" :  On 2/7/16, Konstantin Tokarev wrote:   Please try updated version of my

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Filip Pizło
> On Feb 10, 2016, at 9:14 AM, Konstantin Tokarev wrote: > > > > 10.02.2016, 20:10, "Filip Pizło" : >>> On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: >>> >>> 10.02.2016, 05:41, "Eric Wing" : > On

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Filip Pizło
> On Feb 10, 2016, at 1:40 AM, Konstantin Tokarev wrote: > > > > 10.02.2016, 05:41, "Eric Wing" : >>> On 2/7/16, Konstantin Tokarev wrote: >>> Please try updated version of my branch, it now does not use LLVM unless >>> you >>>

Re: [webkit-dev] [cmake] Proposal: Move commonly used platform-dependent files in WebCore to .cmake include files.

2016-02-10 Thread Konstantin Tokarev
09.02.2016, 22:19, "Alex Christensen" : >  Let’s go for it. Less duplication is a good thing. The only downside is the > occasional “Which CMake file do I add this to?” but that should be just as > straightforward as adding the file to multiple platform cmake files, if

[webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

2016-02-10 Thread Mark Lam
As I shared in a previous email, I’ll be changing the implementation of WTFCrash() for non-debug OS(DARWIN) builds to use an inlined asm statement that issues a breakpoint instruction. See https://bugs.webkit.org/show_bug.cgi?id=153996 for details and discussion. I will be landing this patch

Re: [webkit-dev] Thought about Nix JavaScriptCore port

2016-02-10 Thread Konstantin Tokarev
10.02.2016, 05:41, "Eric Wing" : > On 2/7/16, Konstantin Tokarev wrote: >>  Please try updated version of my branch, it now does not use LLVM unless you >>  enable USE_LLVM_DISASSEMBLER. > > I merged your branch. That seemed to build and work. > So what

Re: [webkit-dev] PSA: Distinguishing between failed release assertions and other crashes

2016-02-10 Thread Mark Lam
FYI, the change has landed in r196397: . > On Feb 10, 2016, at 3:01 PM, Mark Lam wrote: > > As I shared in a previous email, I’ll be changing the implementation of > WTFCrash() for non-debug OS(DARWIN) builds to use an inlined asm statement