(3) seems like a good idea to me!
I’ll volunteer for (1)
Saam
> On Mar 3, 2016, at 11:35 AM, Darin Adler wrote:
>
> 3) physically restrain me from turning do-webcore-rename into a perl script
> that does this all the code in the entire source tree all at one go, since
> that
I volunteer for any future needs in the physical restraint department -- but in
this case, I think (3) sounds like a good idea.
Geoff
> On Mar 3, 2016, at 11:35 AM, Darin Adler wrote:
>
> OK!
>
> Do we have volunteers to:
>
> 1) update the style guide webpage
> 2) update
OK!
Do we have volunteers to:
1) update the style guide webpage
2) update check-webkit-style
3) physically restrain me from turning do-webcore-rename into a perl script
that does this all the code in the entire source tree all at one go, since that
would be a bad idea, right?
— Darin
Huh, I thought we had already decided on this and have been writing new code in
this style :)
Andreas
> On Mar 3, 2016, at 8:24 PM, Brent Fulgham wrote:
>
> +1. I am in favor of this as well!
>
> -Brent
>
>> On Mar 3, 2016, at 11:23 AM, Saam barati
+1. I am in favor of this as well!
-Brent
> On Mar 3, 2016, at 11:23 AM, Saam barati wrote:
>
> +1.
> I like how “override” only reads.
>
> Saam
>
>> On Mar 3, 2016, at 9:54 AM, Ryosuke Niwa wrote:
>>
>> I think "virtual" + "override" is more of a
+1.
I like how “override” only reads.
Saam
> On Mar 3, 2016, at 9:54 AM, Ryosuke Niwa wrote:
>
> I think "virtual" + "override" is more of a historical artifact than
> the preferred style because we used to have OVERRIDE macro before all
> compilers supported C++11. I think
On Thu, 2016-03-03 at 09:54 -0800, Ryosuke Niwa wrote:
> I think "virtual" + "override" is more of a historical artifact than
> the preferred style because we used to have OVERRIDE macro before all
> compilers supported C++11. I think we should just use only
> "override"
> going forward.
> - R.
I think "virtual" + "override" is more of a historical artifact than
the preferred style because we used to have OVERRIDE macro before all
compilers supported C++11. I think we should just use only "override"
going forward.
- R. Niwa
On Thu, Mar 3, 2016 at 9:38 AM, Darin Adler
Antti proposed using only “override” a while back since it’s less verbose and
still unambiguous. I don’t think we reached consensus on which style to prefer
for the project, though.
— Darin
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
Hello,
Right now there is a lot of code which uses both 'virtual' and 'override' on
overridden methods, but there is also code (e.g., in B3) which uses only
'override'. check-webkit-style accepts both styles.
Which style is preferred in new code?
--
Regards,
Konstantin
10 matches
Mail list logo