Re: [webkit-dev] Asserting versus throwing in internals and testRunner objects

2016-09-23 Thread Alexey Proskuryakov
Note that we are talking about API misuse here, so associating the crash with a test is not really needed - it's the test that you are writing. I've seen tests getting checked in even when they don't run to completion and raise JS exceptions. I want it to be very clear and obvious when a test i

Re: [webkit-dev] Asserting versus throwing in internals and testRunner objects

2016-09-23 Thread Geoffrey Garen
I vote for throwing a JS exception. In my experience, tests that crash are harder to deal with than tests that throw JS exceptions. A backtrace is a less informative than the message “you called internals.X without a frame”. Symbolication takes a long time. And sometimes we have trouble associa

[webkit-dev] Asserting versus throwing in internals and testRunner objects

2016-09-23 Thread Ryosuke Niwa
Hi all, In https://bugs.webkit.org/show_bug.cgi?id=161919, a question was raised as to what would be the best practice when one of internals or testRunner method is called at an undesirable timing or wrong arguments. The case in question was about calling it on a document without a frame when the

[webkit-dev] Fall 2016 WebKit Contributors Meeting – Registration Open

2016-09-23 Thread Jon Davis
Hello WebKit Contributors, You are invited to attend the annual WebKit Contributors Meeting to be held at the Hyatt House San Jose/Silicon Valley hotel on October 26th 8 AM to 6 PM. Breakfast and sign-in will begin at 8 AM. Presentations will run between 9:30 AM to 6 PM. Lunch will be provided

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-23 Thread Alex Christensen
Updating to CMake 3.2 would also not cause us a problem. > On Sep 23, 2016, at 1:14 AM, Konstantin Tokarev wrote: > > > > 23.09.2016, 00:59, "Alex Christensen" >: >> Requiring CMake 3.0 would not cause us a problem. > > Looks like anyone is fine with updating CM

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-23 Thread Fujii Hironori
On Fri, Sep 23, 2016 at 5:14 PM, Konstantin Tokarev wrote: > > > 23.09.2016, 00:59, "Alex Christensen" : >> Requiring CMake 3.0 would not cause us a problem. > > Looks like anyone is fine with updating CMake to 3.0, however Fujii Hironori > is asking about CMake 3.2, and AFAIU updating to 3.0 won

[webkit-dev] https://webkit-queues.webkit.org down?

2016-09-23 Thread youenn fablet
Hi all, It seems https://webkit-queues.webkit.org is down (I got 503 responses). Can somebody check this? Thanks y ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] [CMake] Bumping cmake_minimum_required

2016-09-23 Thread Konstantin Tokarev
23.09.2016, 00:59, "Alex Christensen" : > Requiring CMake 3.0 would not cause us a problem. Looks like anyone is fine with updating CMake to 3.0, however Fujii Hironori is asking about CMake 3.2, and AFAIU updating to 3.0 won't help for his patch. . >>  On Sep 21, 2016, at 5:06 AM, Michael Cat