Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Maciej Stachowiak
> On Jul 31, 2017, at 5:04 PM, Michael Catanzaro wrote: > > On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler wrote: >> I don’t think we should add lots of includes of “config.h”, though. I think >> we can come up with something better. > > Like what? The

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Michael Catanzaro
On Mon, Jul 31, 2017 at 9:27 PM, Darin Adler wrote: I don’t think we should add lots of includes of “config.h”, though. I think we can come up with something better. Like what? The only alternative is to pass defines as preprocessor flags via -D. Our command lines are

Re: [webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Darin Adler
We originally adopted this “config.h” style to make WebKit buildable with autotools. Since that has not been a consideration for years I would be willing to abandon this and change how we do things. I don’t think we should add lots of includes of “config.h”, though. I think we can come up with

[webkit-dev] What's the rationale for not including config.h in any header files?

2017-07-31 Thread Alicia Boya García
Hi all. The other day I noticed this in the Code Style Guidelines (https://webkit.org/code-style-guidelines/#include-statements): > Header files should never include config.h. Is there a rationale for it? config.h is a header file that pulls the compilation flags set in CMake, some macro

Re: [webkit-dev] Removing support for CSS regions

2017-07-31 Thread Håkon Wium Lie
Michael Catanzaro wrote: > > Some time has passed, and it seems that adoption of CSS regions on > > the web is not gonna happen. > > Yeah, it does indeed. > > Does anyone have a good explanation for what went wrong? Why did Blink > remove its support? Just curious. Some answers can be

Re: [webkit-dev] Removing support for CSS regions

2017-07-31 Thread Michael Catanzaro
On Mon, Jul 31, 2017 at 9:49 AM, Andreas Kling wrote: Hi folks, Some time has passed, and it seems that adoption of CSS regions on the web is not gonna happen. Yeah, it does indeed. Does anyone have a good explanation for what went wrong? Why did Blink remove its

[webkit-dev] Removing support for CSS regions

2017-07-31 Thread Andreas Kling
Hi folks, Some time has passed, and it seems that adoption of CSS regions on the web is not gonna happen. Blink has long since removed their support. Firefox never supported it AFAIK. (The new) IE has some amount of support behind a prefix, but no plans to unprefix AFAIK. I think it’s time we