Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
> On Jun 6, 2018, at 9:39 AM, Dan Bernstein wrote: > > libwebrtc.xcconfig sets CLANG_ENABLE_OBJC_ARC to YES for the libwebrtc > target. Since RTCVideoCodecH264.mm is part of that target the file is > compiled with ARC. OK, great. That’s what I missed. I’ll get rid of the stray -fobjc-arc in

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Dan Bernstein
> On Jun 6, 2018, at 9:28 AM, Darin Adler wrote: > > Hi folks. > > As some of you have probably noticed, I’ve begun making changes with the goal > of preparing us to move most Objective-C code in WebKit to ARC. In doing so, > I have been exploring the existing code in the tree and the

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread youenn fablet
Dave suggested the same approach in https://bugs.webkit.org/show_bug.cgi?id=185324. ARC should be enabled for the whole libwebrtc project in WebKit ToT. Y Le mer. 6 juin 2018 à 09:28, Darin Adler a écrit : > Hi folks. > > As some of you have probably noticed, I’ve begun making changes with

Re: [webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
> On Jun 6, 2018, at 9:28 AM, Darin Adler wrote: > > best keep working with manual retain and release best kept working > a non-tribal amount of code that already seems to assume ARC a non-trivial amount — Darin ___ webkit-dev mailing list

[webkit-dev] Objective-C code in libwebrtc already assuming ARC?

2018-06-06 Thread Darin Adler
Hi folks. As some of you have probably noticed, I’ve begun making changes with the goal of preparing us to move most Objective-C code in WebKit to ARC. In doing so, I have been exploring the existing code in the tree and the various projects in our source tree. The nine projects with